| Message ID | 20210507170634.2058801-2-philmd@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | virtio-blk: Convert QEMUBH callback to "bitops.h" API | expand |
On 5/7/21 10:06 AM, Philippe Mathieu-Daudé wrote: > Document the following functions return the bitmap size > if not matching bit is found: > > - find_first_bit > - find_next_bit > - find_last_bit > - find_first_zero_bit > - find_next_zero_bit > > Signed-off-by: Philippe Mathieu-Daudé<philmd@redhat.com> > --- > include/qemu/bitops.h | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 5/7/21 12:06 PM, Philippe Mathieu-Daudé wrote: > Document the following functions return the bitmap size > if not matching bit is found: s/not/no/ > > - find_first_bit > - find_next_bit > - find_last_bit > - find_first_zero_bit > - find_next_zero_bit > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > include/qemu/bitops.h | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > @@ -150,6 +151,9 @@ unsigned long find_last_bit(const unsigned long *addr, > * @addr: The address to base the search on > * @offset: The bitnumber to start searching at > * @size: The bitmap size in bits > + * > + * Returns the bit number of the next set bit, > + * or @size if there is no set bit in the bitmap. > */ > unsigned long find_next_bit(const unsigned long *addr, Misleading - there might be a set bit prior to @offset. Better might be: or @size if there are no further set bits in the bitmap. > unsigned long size, > @@ -160,6 +164,9 @@ unsigned long find_next_bit(const unsigned long *addr, > * @addr: The address to base the search on > * @offset: The bitnumber to start searching at > * @size: The bitmap size in bits > + * > + * Returns the bit number of the next cleared bit, > + * or @size if there is no clear bit in the bitmap. > */ > > unsigned long find_next_zero_bit(const unsigned long *addr, similarly, or @size if there are no further clear bits in the bitmap.
diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h index 3acbf3384c6..eb0fc5416a9 100644 --- a/include/qemu/bitops.h +++ b/include/qemu/bitops.h @@ -140,7 +140,8 @@ static inline int test_bit(long nr, const unsigned long *addr) * @addr: The address to start the search at * @size: The maximum size to search * - * Returns the bit number of the first set bit, or size. + * Returns the bit number of the last set bit, + * or @size if there is no set bit in the bitmap. */ unsigned long find_last_bit(const unsigned long *addr, unsigned long size); @@ -150,6 +151,9 @@ unsigned long find_last_bit(const unsigned long *addr, * @addr: The address to base the search on * @offset: The bitnumber to start searching at * @size: The bitmap size in bits + * + * Returns the bit number of the next set bit, + * or @size if there is no set bit in the bitmap. */ unsigned long find_next_bit(const unsigned long *addr, unsigned long size, @@ -160,6 +164,9 @@ unsigned long find_next_bit(const unsigned long *addr, * @addr: The address to base the search on * @offset: The bitnumber to start searching at * @size: The bitmap size in bits + * + * Returns the bit number of the next cleared bit, + * or @size if there is no clear bit in the bitmap. */ unsigned long find_next_zero_bit(const unsigned long *addr, @@ -171,7 +178,8 @@ unsigned long find_next_zero_bit(const unsigned long *addr, * @addr: The address to start the search at * @size: The maximum size to search * - * Returns the bit number of the first set bit. + * Returns the bit number of the first set bit, + * or @size if there is no set bit in the bitmap. */ static inline unsigned long find_first_bit(const unsigned long *addr, unsigned long size) @@ -194,7 +202,8 @@ static inline unsigned long find_first_bit(const unsigned long *addr, * @addr: The address to start the search at * @size: The maximum size to search * - * Returns the bit number of the first cleared bit. + * Returns the bit number of the first cleared bit, + * or @size if there is no clear bit in the bitmap. */ static inline unsigned long find_first_zero_bit(const unsigned long *addr, unsigned long size)
Document the following functions return the bitmap size if not matching bit is found: - find_first_bit - find_next_bit - find_last_bit - find_first_zero_bit - find_next_zero_bit Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- include/qemu/bitops.h | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)