| Message ID | 20210505135803.67896-2-vsementsov@virtuozzo.com |
|---|---|
| State | New |
| Headers | show |
| Series | qapi & doc: deprecate drive-backup | expand |
On 5/5/21 9:58 AM, Vladimir Sementsov-Ogievskiy wrote: > We are going to deprecate drive-backup, so don't mention it here. > Moreover, blockdev-backup seems more correct in the context. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Reviewed-by: John Snow <jsnow@redhat.com> > --- > docs/block-replication.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/docs/block-replication.txt b/docs/block-replication.txt > index 108e9166a8..59eb2b33b3 100644 > --- a/docs/block-replication.txt > +++ b/docs/block-replication.txt > @@ -79,7 +79,7 @@ Primary | || Secondary disk <--------- hidden-disk 5 <--------- > || | | > || | | > || '-------------------------' > - || drive-backup sync=none 6 > + || blockdev-backup sync=none 6 > > 1) The disk on the primary is represented by a block device with two > children, providing replication between a primary disk and the host that > @@ -101,7 +101,7 @@ should support bdrv_make_empty() and backing file. > that is modified by the primary VM. It should also start as an empty disk, > and the driver supports bdrv_make_empty() and backing file. > > -6) The drive-backup job (sync=none) is run to allow hidden-disk to buffer > +6) The blockdev-backup job (sync=none) is run to allow hidden-disk to buffer > any state that would otherwise be lost by the speculative write-through > of the NBD server into the secondary disk. So before block replication, > the primary disk and secondary disk should contain the same data. >
diff --git a/docs/block-replication.txt b/docs/block-replication.txt index 108e9166a8..59eb2b33b3 100644 --- a/docs/block-replication.txt +++ b/docs/block-replication.txt @@ -79,7 +79,7 @@ Primary | || Secondary disk <--------- hidden-disk 5 <--------- || | | || | | || '-------------------------' - || drive-backup sync=none 6 + || blockdev-backup sync=none 6 1) The disk on the primary is represented by a block device with two children, providing replication between a primary disk and the host that @@ -101,7 +101,7 @@ should support bdrv_make_empty() and backing file. that is modified by the primary VM. It should also start as an empty disk, and the driver supports bdrv_make_empty() and backing file. -6) The drive-backup job (sync=none) is run to allow hidden-disk to buffer +6) The blockdev-backup job (sync=none) is run to allow hidden-disk to buffer any state that would otherwise be lost by the speculative write-through of the NBD server into the secondary disk. So before block replication, the primary disk and secondary disk should contain the same data.
We are going to deprecate drive-backup, so don't mention it here. Moreover, blockdev-backup seems more correct in the context. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> --- docs/block-replication.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)