diff mbox series

[v5,11/11] block/io: allow 64bit discard requests

Message ID 20210505075001.45041-12-vsementsov@virtuozzo.com
State New
Headers show
Series 64bit block-layer: part II | expand

Commit Message

Vladimir Sementsov-Ogievskiy May 5, 2021, 7:50 a.m. UTC 
Now, when all drivers are updated by previous commit, we can drop the
last limiter on pdiscard path: INT_MAX in bdrv_co_pdiscard().

Now everything is prepared for implementing incredibly cool and fast
big-discard requests in NBD and qcow2. And any other driver which wants
it of course.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 block/io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eric Blake June 7, 2021, 6:15 p.m. UTC | #1 
On Wed, May 05, 2021 at 10:50:01AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Now, when all drivers are updated by previous commit, we can drop the

Now that all drivers are updated by the previous commit,

> last limiter on pdiscard path: INT_MAX in bdrv_co_pdiscard().
> 
> Now everything is prepared for implementing incredibly cool and fast
> big-discard requests in NBD and qcow2. And any other driver which wants
> it of course.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>  block/io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>
diff mbox series

Patch

diff --git a/block/io.c b/block/io.c
index a7edb1ef54..e0b3ebcc37 100644
--- a/block/io.c
+++ b/block/io.c
@@ -3036,7 +3036,7 @@  int coroutine_fn bdrv_co_pdiscard(BdrvChild *child, int64_t offset,
         goto out;
     }
 
-    max_pdiscard = QEMU_ALIGN_DOWN(MIN_NON_ZERO(bs->bl.max_pdiscard, INT_MAX),
+    max_pdiscard = QEMU_ALIGN_DOWN(MIN_NON_ZERO(bs->bl.max_pdiscard, INT64_MAX),
                                    align);
     assert(max_pdiscard >= bs->bl.request_alignment);