| Message ID | 20210503211020.894589-13-philmd@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | qtests: Check accelerator available at runtime via QMP 'query-accels' | expand |
On Mon, 3 May 2021 23:10:20 +0200 Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > Since commit 82bf7ae84ce ("target/arm: Remove KVM support for > 32-bit Arm hosts") we can remove the comment / check added in > commit ab6b6a77774 and directly run the bios-tables-test. However I no longer recall what exactly was wrong with TCG, the later commit adds comment about broken TCG, so I'm not sure how it's tied to the first commit > Reviewed-by: Eric Blake <eblake@redhat.com> > Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > Tested-by: Alex Bennée <alex.bennee@linaro.org> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > tests/qtest/meson.build | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > index 0c767389217..46de073d155 100644 > --- a/tests/qtest/meson.build > +++ b/tests/qtest/meson.build > @@ -175,14 +175,13 @@ > 'boot-serial-test', > 'hexloader-test'] > > -# TODO: once aarch64 TCG is fixed on ARM 32 bit host, make bios-tables-test unconditional > qtests_aarch64 = \ > - (cpu != 'arm' ? ['bios-tables-test'] : []) + \ > (config_all_devices.has_key('CONFIG_TPM_TIS_SYSBUS') ? ['tpm-tis-device-test'] : []) + \ > (config_all_devices.has_key('CONFIG_TPM_TIS_SYSBUS') ? ['tpm-tis-device-swtpm-test'] : []) + \ > ['arm-cpu-features', > 'numa-test', > 'boot-serial-test', > + 'bios-tables-test', > 'xlnx-can-test', > 'migration-test'] >
diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index 0c767389217..46de073d155 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -175,14 +175,13 @@ 'boot-serial-test', 'hexloader-test'] -# TODO: once aarch64 TCG is fixed on ARM 32 bit host, make bios-tables-test unconditional qtests_aarch64 = \ - (cpu != 'arm' ? ['bios-tables-test'] : []) + \ (config_all_devices.has_key('CONFIG_TPM_TIS_SYSBUS') ? ['tpm-tis-device-test'] : []) + \ (config_all_devices.has_key('CONFIG_TPM_TIS_SYSBUS') ? ['tpm-tis-device-swtpm-test'] : []) + \ ['arm-cpu-features', 'numa-test', 'boot-serial-test', + 'bios-tables-test', 'xlnx-can-test', 'migration-test']
Since commit 82bf7ae84ce ("target/arm: Remove KVM support for 32-bit Arm hosts") we can remove the comment / check added in commit ab6b6a77774 and directly run the bios-tables-test. Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Tested-by: Alex Bennée <alex.bennee@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- tests/qtest/meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)