Message ID | 20210422170221.285006-4-kwolf@redhat.com |
---|---|
State | New |
Headers | show |
Series | vhost-user-blk: Error handling fixes during initialistion | expand |
Acked-by: Raphael Norwitz <raphael.norwitz@nutanix.com> On Thu, Apr 22, 2021 at 07:02:19PM +0200, Kevin Wolf wrote: > VIRTIO_F_RING_PACKED and VIRTIO_F_IOMMU_PLATFORM need to be supported by > the vhost device, otherwise advertising it to the guest doesn't result > in a working configuration. They are currently not supported by the > vhost-user-blk export in QEMU. > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1935020 > Signed-off-by: Kevin Wolf <kwolf@redhat.com> > --- > hw/block/vhost-user-blk.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c > index 8422a29470..b6f4bb3f6f 100644 > --- a/hw/block/vhost-user-blk.c > +++ b/hw/block/vhost-user-blk.c > @@ -47,6 +47,8 @@ static const int user_feature_bits[] = { > VIRTIO_RING_F_INDIRECT_DESC, > VIRTIO_RING_F_EVENT_IDX, > VIRTIO_F_NOTIFY_ON_EMPTY, > + VIRTIO_F_RING_PACKED, > + VIRTIO_F_IOMMU_PLATFORM, > VHOST_INVALID_FEATURE_BIT > }; > > -- > 2.30.2 >
diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c index 8422a29470..b6f4bb3f6f 100644 --- a/hw/block/vhost-user-blk.c +++ b/hw/block/vhost-user-blk.c @@ -47,6 +47,8 @@ static const int user_feature_bits[] = { VIRTIO_RING_F_INDIRECT_DESC, VIRTIO_RING_F_EVENT_IDX, VIRTIO_F_NOTIFY_ON_EMPTY, + VIRTIO_F_RING_PACKED, + VIRTIO_F_IOMMU_PLATFORM, VHOST_INVALID_FEATURE_BIT };
VIRTIO_F_RING_PACKED and VIRTIO_F_IOMMU_PLATFORM need to be supported by the vhost device, otherwise advertising it to the guest doesn't result in a working configuration. They are currently not supported by the vhost-user-blk export in QEMU. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1935020 Signed-off-by: Kevin Wolf <kwolf@redhat.com> --- hw/block/vhost-user-blk.c | 2 ++ 1 file changed, 2 insertions(+)