| Message ID | 20210413124800.216095-1-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Tue, 13 Apr 2021 at 13:50, Paolo Bonzini <pbonzini@redhat.com> wrote: > > The following changes since commit c1e90def01bdb8fcbdbebd9d1eaa8e4827ece620: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210412' into staging (2021-04-12 12:12:09 +0100) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to 12763913a3e44d9968a9ab0da01a0880fc7d61df: > > osdep: protect qemu/osdep.h with extern "C" (2021-04-13 13:00:37 +0200) > > ---------------------------------------------------------------- > Fix C++ compilation of qemu/osdep.h. I had some unaddressed review comments on patch 2... thanks -- PMM
Patchew URL: https://patchew.org/QEMU/20210413124800.216095-1-pbonzini@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210413124800.216095-1-pbonzini@redhat.com Subject: [PULL 0/2] osdep.h changes for QEMU 6.0-rc3 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 2f6308e osdep: protect qemu/osdep.h with extern "C" 9aed404 osdep: include glib-compat.h before other QEMU headers === OUTPUT BEGIN === 1/2 Checking commit 9aed404591cb (osdep: include glib-compat.h before other QEMU headers) 2/2 Checking commit 2f6308e1b524 (osdep: protect qemu/osdep.h with extern "C") WARNING: architecture specific defines should be avoided #51: FILE: include/qemu/compiler.h:14: +#ifdef __cplusplus ERROR: storage class should be at the beginning of the declaration #52: FILE: include/qemu/compiler.h:15: +#define QEMU_EXTERN_C extern "C" ERROR: storage class should be at the beginning of the declaration #54: FILE: include/qemu/compiler.h:17: +#define QEMU_EXTERN_C extern WARNING: architecture specific defines should be avoided #77: FILE: include/qemu/osdep.h:116: +#ifdef __cplusplus WARNING: architecture specific defines should be avoided #88: FILE: include/qemu/osdep.h:730: +#ifdef __cplusplus total: 2 errors, 3 warnings, 47 lines checked Patch 2/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210413124800.216095-1-pbonzini@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
The following changes since commit c1e90def01bdb8fcbdbebd9d1eaa8e4827ece620: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210412' into staging (2021-04-12 12:12:09 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to 12763913a3e44d9968a9ab0da01a0880fc7d61df: osdep: protect qemu/osdep.h with extern "C" (2021-04-13 13:00:37 +0200) ---------------------------------------------------------------- Fix C++ compilation of qemu/osdep.h. ---------------------------------------------------------------- Paolo Bonzini (2): osdep: include glib-compat.h before other QEMU headers osdep: protect qemu/osdep.h with extern "C" disas/nanomips.cpp | 2 +- include/qemu/compiler.h | 6 ++++++ include/qemu/osdep.h | 13 +++++++++++-- 3 files changed, 18 insertions(+), 3 deletions(-)