Message ID | 20210409160406.1800272-2-rvkagan@yandex-team.ru |
---|---|
State | New |
Headers | show |
Series | block/nbd: assorted bugfixes | expand |
09.04.2021 19:04, Roman Kagan wrote: > nbd_free_connect_thread leaks the channel object if it hasn't been > stolen. > > Unref it and fix the leak. > > Signed-off-by: Roman Kagan<rvkagan@yandex-team.ru> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
diff --git a/block/nbd.c b/block/nbd.c index c26dc5a54f..d86df3afcb 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -385,6 +385,7 @@ static void nbd_free_connect_thread(NBDConnectThread *thr) { if (thr->sioc) { qio_channel_close(QIO_CHANNEL(thr->sioc), NULL); + object_unref(OBJECT(thr->sioc)); } error_free(thr->err); qapi_free_SocketAddress(thr->saddr);
nbd_free_connect_thread leaks the channel object if it hasn't been stolen. Unref it and fix the leak. Signed-off-by: Roman Kagan <rvkagan@yandex-team.ru> --- block/nbd.c | 1 + 1 file changed, 1 insertion(+)