| Message ID | 20210325142702.790-1-yuzenghui@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | hw/arm/smmuv3: Drop unused CDM_VALID() and is_cd_valid() | expand |
Hi Zenghui, On 3/25/21 3:27 PM, Zenghui Yu wrote: > They were introduced in commit 9bde7f0674fe ("hw/arm/smmuv3: Implement > translate callback") but never actually used. Drop them. > > Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> > --- > hw/arm/smmuv3-internal.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/hw/arm/smmuv3-internal.h b/hw/arm/smmuv3-internal.h > index b6f7e53b7c..3dac5766ca 100644 > --- a/hw/arm/smmuv3-internal.h > +++ b/hw/arm/smmuv3-internal.h > @@ -595,13 +595,6 @@ static inline int pa_range(STE *ste) > #define CD_A(x) extract32((x)->word[1], 14, 1) > #define CD_AARCH64(x) extract32((x)->word[1], 9 , 1) > > -#define CDM_VALID(x) ((x)->word[0] & 0x1) > - > -static inline int is_cd_valid(SMMUv3State *s, STE *ste, CD *cd) > -{ > - return CD_VALID(cd); > -} > - > /** > * tg2granule - Decodes the CD translation granule size field according > * to the ttbr in use > Acked-by: Eric Auger <eric.auger@redhat.com> Thanks Eric
On Thu, 25 Mar 2021 at 14:27, Zenghui Yu <yuzenghui@huawei.com> wrote: > > They were introduced in commit 9bde7f0674fe ("hw/arm/smmuv3: Implement > translate callback") but never actually used. Drop them. > > Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> > --- Applied to target-arm.next, thanks. -- PMM
diff --git a/hw/arm/smmuv3-internal.h b/hw/arm/smmuv3-internal.h index b6f7e53b7c..3dac5766ca 100644 --- a/hw/arm/smmuv3-internal.h +++ b/hw/arm/smmuv3-internal.h @@ -595,13 +595,6 @@ static inline int pa_range(STE *ste) #define CD_A(x) extract32((x)->word[1], 14, 1) #define CD_AARCH64(x) extract32((x)->word[1], 9 , 1) -#define CDM_VALID(x) ((x)->word[0] & 0x1) - -static inline int is_cd_valid(SMMUv3State *s, STE *ste, CD *cd) -{ - return CD_VALID(cd); -} - /** * tg2granule - Decodes the CD translation granule size field according * to the ttbr in use
They were introduced in commit 9bde7f0674fe ("hw/arm/smmuv3: Implement translate callback") but never actually used. Drop them. Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> --- hw/arm/smmuv3-internal.h | 7 ------- 1 file changed, 7 deletions(-)