| Message ID | 20210306105419.110503-1-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
Patchew URL: https://patchew.org/QEMU/20210306105419.110503-1-pbonzini@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210306105419.110503-1-pbonzini@redhat.com
Subject: [PULL 00/23] Misc patches for 2021-03-06
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210306105419.110503-1-pbonzini@redhat.com -> patchew/20210306105419.110503-1-pbonzini@redhat.com
Switched to a new branch 'test'
e8ca3ae meson: Stop if cfi is enabled with system slirp
07dbcab trace: skip qemu_set_log_filename if no "-D" option was passed
f4066a9 trace: fix "-trace file=..."
e68de4e meson: adjust timeouts for some slower tests
77a9ebc build-sys: invoke ninja with -d keepdepfile
c0f4778 qemu-option: do not suggest using the delay option
e9e318f scsi: move host_status handling into SCSI drivers
fee64ec scsi: inline sg_io_sense_from_errno() into the callers.
162e7a7 scsi-generic: do not snoop the output of failed commands
c69f058 scsi: Add mapping for generic SCSI_HOST status to sense codes
3dc14e2 scsi: Rename linux-specific SG_ERR codes to generic SCSI_HOST error codes
72d7f7c qemu-config: add error propagation to qemu_config_parse
39a40cc x86/pvh: extract only 4 bytes of start address for 32 bit kernels
7bc6f42 elf_ops: correct loading of 32 bit PVH kernel
eee7136 lsilogic: Use PCIDevice::exit instead of DeviceState::unrealize
9a5c9ce accel: kvm: Add aligment assert for kvm_log_clear_one_slot
d3955f4 accel: kvm: Fix memory waste under mismatch page size
52c0f08 vl.c: do not execute trace_init_backends() before daemonizing
bacc541 qom: Check for wellformed id in user_creatable_add_type()
4a7a94a chardev: add nodelay option
bbdceab qga-vss: Use dynamic linking for GLib
351c41a KVM: x86: deprecate -M kernel-irqchip=off except for -M isapc
713ab1d KVM: x86: do not fail if software breakpoint has already been removed
=== OUTPUT BEGIN ===
1/23 Checking commit 713ab1db9c9f (KVM: x86: do not fail if software breakpoint has already been removed)
2/23 Checking commit 351c41a16c9f (KVM: x86: deprecate -M kernel-irqchip=off except for -M isapc)
WARNING: line over 80 characters
#60: FILE: hw/intc/apic.c:881:
+ warn_report("Do not use kernel-irqchip except for the -M isapc machine type.");
total: 0 errors, 1 warnings, 31 lines checked
Patch 2/23 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/23 Checking commit bbdceab56d88 (qga-vss: Use dynamic linking for GLib)
4/23 Checking commit 4a7a94a4597c (chardev: add nodelay option)
5/23 Checking commit bacc5417205b (qom: Check for wellformed id in user_creatable_add_type())
6/23 Checking commit 52c0f083d216 (vl.c: do not execute trace_init_backends() before daemonizing)
7/23 Checking commit d3955f44d7fa (accel: kvm: Fix memory waste under mismatch page size)
8/23 Checking commit 9a5c9cea2bd4 (accel: kvm: Add aligment assert for kvm_log_clear_one_slot)
9/23 Checking commit eee713683833 (lsilogic: Use PCIDevice::exit instead of DeviceState::unrealize)
10/23 Checking commit 7bc6f4223f01 (elf_ops: correct loading of 32 bit PVH kernel)
11/23 Checking commit 39a40ccab60f (x86/pvh: extract only 4 bytes of start address for 32 bit kernels)
12/23 Checking commit 72d7f7ce1df7 (qemu-config: add error propagation to qemu_config_parse)
WARNING: line over 80 characters
#136: FILE: util/qemu-config.c:353:
+int qemu_config_parse(FILE *fp, QemuOptsList **lists, const char *fname, Error **errp)
total: 0 errors, 1 warnings, 144 lines checked
Patch 12/23 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/23 Checking commit 3dc14e2345fc (scsi: Rename linux-specific SG_ERR codes to generic SCSI_HOST error codes)
14/23 Checking commit c69f05834a13 (scsi: Add mapping for generic SCSI_HOST status to sense codes)
15/23 Checking commit 162e7a771b90 (scsi-generic: do not snoop the output of failed commands)
16/23 Checking commit fee64ec0ceb5 (scsi: inline sg_io_sense_from_errno() into the callers.)
ERROR: line over 90 characters
#107: FILE: hw/scsi/scsi-disk.c:2820:
+ aiocb = blk_aio_ioctl(s->qdev.conf.blk, SG_IO, io_header, scsi_block_sgio_complete, req);
total: 1 errors, 0 warnings, 166 lines checked
Patch 16/23 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/23 Checking commit e9e318f92d6c (scsi: move host_status handling into SCSI drivers)
18/23 Checking commit c0f4778ff786 (qemu-option: do not suggest using the delay option)
ERROR: line over 90 characters
#50: FILE: util/qemu-option.c:789:
+ error_printf("Please use nodelay=%s instead\n", prefix[0] ? "on" : "off");
total: 1 errors, 0 warnings, 24 lines checked
Patch 18/23 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/23 Checking commit 77a9ebc4bb31 (build-sys: invoke ninja with -d keepdepfile)
20/23 Checking commit e68de4e6792d (meson: adjust timeouts for some slower tests)
21/23 Checking commit f4066a9e3296 (trace: fix "-trace file=...")
22/23 Checking commit 07dbcab76e3b (trace: skip qemu_set_log_filename if no "-D" option was passed)
23/23 Checking commit e8ca3ae2f936 (meson: Stop if cfi is enabled with system slirp)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210306105419.110503-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Sat, 6 Mar 2021 at 10:56, Paolo Bonzini <pbonzini@redhat.com> wrote: > > The following changes since commit e586edcb410543768ef009eaa22a2d9dd4a53846: > > virtiofs: drop remapped security.capability xattr as needed (2021-03-04 10:26:16 +0000) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to c715343fd96bcf93263fda38d81af815fdb5a7fa: > > meson: Stop if cfi is enabled with system slirp (2021-03-06 11:42:57 +0100) > > ---------------------------------------------------------------- > * fix tracing vs -daemonize (Daniel) > * detect invalid CFI configuration (Daniele) > * 32-bit PVH fix (David) > * forward SCSI passthrough host-status to the SCSI HBA (Hannes) > * detect ill-formed id in QMP object-add (Kevin) > * miscellaneous bugfixes and cleanups (Keqian, Kostiantyn, myself, Peng Liang) > * add nodelay option for chardev (myself) > * deprecate -M kernel-irqchip=off on x86 (myself) > * keep .d files (myself) > * Fix -trace file (myself) Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0 for any user-visible changes. -- PMM
The following changes since commit e586edcb410543768ef009eaa22a2d9dd4a53846: virtiofs: drop remapped security.capability xattr as needed (2021-03-04 10:26:16 +0000) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to c715343fd96bcf93263fda38d81af815fdb5a7fa: meson: Stop if cfi is enabled with system slirp (2021-03-06 11:42:57 +0100) ---------------------------------------------------------------- * fix tracing vs -daemonize (Daniel) * detect invalid CFI configuration (Daniele) * 32-bit PVH fix (David) * forward SCSI passthrough host-status to the SCSI HBA (Hannes) * detect ill-formed id in QMP object-add (Kevin) * miscellaneous bugfixes and cleanups (Keqian, Kostiantyn, myself, Peng Liang) * add nodelay option for chardev (myself) * deprecate -M kernel-irqchip=off on x86 (myself) * keep .d files (myself) * Fix -trace file (myself) ---------------------------------------------------------------- Daniel Henrique Barboza (1): vl.c: do not execute trace_init_backends() before daemonizing Daniele Buono (1): meson: Stop if cfi is enabled with system slirp David Edmondson (2): elf_ops: correct loading of 32 bit PVH kernel x86/pvh: extract only 4 bytes of start address for 32 bit kernels Hannes Reinecke (4): scsi: Rename linux-specific SG_ERR codes to generic SCSI_HOST error codes scsi: Add mapping for generic SCSI_HOST status to sense codes scsi: inline sg_io_sense_from_errno() into the callers. scsi: move host_status handling into SCSI drivers Keqian Zhu (2): accel: kvm: Fix memory waste under mismatch page size accel: kvm: Add aligment assert for kvm_log_clear_one_slot Kevin Wolf (1): qom: Check for wellformed id in user_creatable_add_type() Kostiantyn Kostiuk (1): qga-vss: Use dynamic linking for GLib Paolo Bonzini (10): KVM: x86: do not fail if software breakpoint has already been removed KVM: x86: deprecate -M kernel-irqchip=off except for -M isapc chardev: add nodelay option qemu-config: add error propagation to qemu_config_parse scsi-generic: do not snoop the output of failed commands qemu-option: do not suggest using the delay option build-sys: invoke ninja with -d keepdepfile meson: adjust timeouts for some slower tests trace: fix "-trace file=..." trace: skip qemu_set_log_filename if no "-D" option was passed Peng Liang (1): lsilogic: Use PCIDevice::exit instead of DeviceState::unrealize Makefile | 2 +- accel/kvm/kvm-all.c | 13 ++++++++- block/blkdebug.c | 3 +- chardev/char-socket.c | 13 +++++++-- chardev/char.c | 3 ++ docs/system/deprecated.rst | 13 +++++++++ gdbstub.c | 2 +- hw/i386/x86.c | 6 ++-- hw/intc/apic.c | 6 ++++ hw/scsi/lsi53c895a.c | 4 +-- hw/scsi/scsi-bus.c | 33 +++++++++++++++++++-- hw/scsi/scsi-disk.c | 47 ++++++++++++++++++++++++++---- hw/scsi/scsi-generic.c | 25 +++++++++++----- hw/scsi/virtio-scsi.c | 46 +++++++++++++++++++++++++++++ hw/scsi/vmw_pvscsi.c | 39 +++++++++++++++++++++++++ include/hw/elf_ops.h | 4 +-- include/hw/scsi/scsi.h | 5 +++- include/qemu/config-file.h | 5 ++-- include/scsi/utils.h | 27 ++++++++++------- meson.build | 12 ++++++++ qemu-options.hx | 14 ++++----- qga/vss-win32/meson.build | 4 +-- qom/object_interfaces.c | 9 ++++++ scsi/qemu-pr-helper.c | 24 +++++++++++----- scsi/utils.c | 72 ++++++++++++++++++++++++++++++++-------------- softmmu/vl.c | 51 ++++++++++++++++---------------- target/i386/kvm/kvm.c | 9 ++++-- tests/fp/meson.build | 2 +- tests/meson.build | 8 ++++++ tests/qtest/meson.build | 15 ++++++++++ trace/control.c | 13 +++++---- util/qemu-config.c | 23 ++++++++------- util/qemu-option.c | 6 +++- 33 files changed, 434 insertions(+), 124 deletions(-)