diff mbox series

target/hexagon/opcodes: Add missing varargs cleanup

Message ID 20210223111253.2831285-1-f4bug@amsat.org
State New
Headers show
Series target/hexagon/opcodes: Add missing varargs cleanup | expand

Commit Message

Philippe Mathieu-Daudé Feb. 23, 2021, 11:12 a.m. UTC
Fix a trivial incorrect usage of variable argument macros detected
by Coverity (missing_va_end: va_end was not called for ap).

Fixes: Coverity CID 1446720 (VARARGS)
Fixes: e3c00c2ed75 ("Hexagon (target/hexagon) opcode data structures")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/hexagon/opcodes.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Richard Henderson Feb. 23, 2021, 6:47 p.m. UTC | #1
On 2/23/21 3:12 AM, Philippe Mathieu-Daudé wrote:
> Fix a trivial incorrect usage of variable argument macros detected
> by Coverity (missing_va_end: va_end was not called for ap).
> 
> Fixes: Coverity CID 1446720 (VARARGS)
> Fixes: e3c00c2ed75 ("Hexagon (target/hexagon) opcode data structures")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/hexagon/opcodes.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
Taylor Simpson Feb. 23, 2021, 8:40 p.m. UTC | #2
> -----Original Message-----
> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Tuesday, February 23, 2021 5:13 AM
> To: qemu-devel@nongnu.org
> Cc: Richard Henderson <richard.henderson@linaro.org>; Taylor Simpson
> <tsimpson@quicinc.com>; Philippe Mathieu-Daudé <f4bug@amsat.org>
> Subject: [PATCH] target/hexagon/opcodes: Add missing varargs cleanup
>
> Fix a trivial incorrect usage of variable argument macros detected
> by Coverity (missing_va_end: va_end was not called for ap).
>
> Fixes: Coverity CID 1446720 (VARARGS)
> Fixes: e3c00c2ed75 ("Hexagon (target/hexagon) opcode data structures")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/hexagon/opcodes.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/target/hexagon/opcodes.c b/target/hexagon/opcodes.c
> index 4eef5fc40f6..35d790cdd5b 100644
> --- a/target/hexagon/opcodes.c
> +++ b/target/hexagon/opcodes.c
> @@ -82,6 +82,7 @@ static void init_attribs(int tag, ...)
>      while ((attr = va_arg(ap, int)) != 0) {
>          set_bit(attr, opcode_attribs[tag]);
>      }
> +    va_end(ap);
>  }
>

Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Tested-by: Taylor Simpson <tsimpson@quicinc.com>
diff mbox series

Patch

diff --git a/target/hexagon/opcodes.c b/target/hexagon/opcodes.c
index 4eef5fc40f6..35d790cdd5b 100644
--- a/target/hexagon/opcodes.c
+++ b/target/hexagon/opcodes.c
@@ -82,6 +82,7 @@  static void init_attribs(int tag, ...)
     while ((attr = va_arg(ap, int)) != 0) {
         set_bit(attr, opcode_attribs[tag]);
     }
+    va_end(ap);
 }
 
 const OpcodeEncoding opcode_encodings[] = {