| Message ID | 20210211125215.985593-1-its@irrelevant.dk |
|---|---|
| State | New |
| Headers | show |
On Feb 11 13:52, Klaus Jensen wrote: > From: Klaus Jensen <k.jensen@samsung.com> > > Moving namespace registration to the nvme-ns realization function had > the unintended side-effect of breaking legacy namespace registration. > Fix this. > > Fixes: 15d024d4aa9b ("hw/block/nvme: split setup and register for namespace") > Reported-by: Alexander Graf <agraf@csgraf.de> > Cc: Minwoo Im <minwoo.im.dev@gmail.com> > Tested-by: Alexander Graf <agraf@csgraf.de> > Signed-off-by: Klaus Jensen <k.jensen@samsung.com> > --- > hw/block/nvme.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index 5ce21b7100b3..d36e14fe13e2 100644 > --- a/hw/block/nvme.c > +++ b/hw/block/nvme.c > @@ -4507,6 +4507,12 @@ static void nvme_realize(PCIDevice *pci_dev, Error **errp) > if (nvme_ns_setup(ns, errp)) { > return; > } > + > + if (nvme_register_namespace(n, ns, errp)) { > + error_propagate_prepend(errp, local_err, > + "could not register namespace: "); > + return; > + } > } > } > Argh, sorry Peter. I just spotted a mistake here. Please ignore until v2...
From: Klaus Jensen <k.jensen@samsung.com> Hi Peter, Two small fixes for emulated nvme for regressions reported by Alexander Graf and Bin Meng. Please pull! The following changes since commit 83339e21d05c824ebc9131d644f25c23d0e41ecf: Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-02-10 15:42:20 +0000) are available in the Git repository at: git://git.infradead.org/qemu-nvme.git tags/nvme-fixes-pull-request for you to fetch changes up to b4471900d5328b66eeecdbc79de83992cc109d04: hw/block/nvme: Fix a build error in nvme_get_feature() (2021-02-11 13:46:50 +0100) ---------------------------------------------------------------- Two small fixes for regressions reported by Alexander Graf and Bin Meng. ---------------------------------------------------------------- Bin Meng (1): hw/block/nvme: Fix a build error in nvme_get_feature() Klaus Jensen (1): hw/block/nvme: fix legacy namespace registration hw/block/nvme.c | 7 +++++++ 1 file changed, 7 insertions(+)