| Message ID | 20210205144345.2068758-4-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | hw/arm/virt: Improve CPU help and fix testing under KVM | expand |
On Fri, Feb 05, 2021 at 03:43:39PM +0100, Philippe Mathieu-Daudé wrote: > When using KVM, using a specific cpu type will only work if the > host CPU really is that exact CPU type. > > During testing we can simply use the 'max' CPU which will select > all the features available from the host. > > This allow running this test on a Cavium CN8890 (ThunderX cores). > > Suggested-by: Peter Maydell <peter.maydell@linaro.org> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > tests/qtest/boot-serial-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/boot-serial-test.c b/tests/qtest/boot-serial-test.c > index b6b1c23cd01..d74509b1c57 100644 > --- a/tests/qtest/boot-serial-test.c > +++ b/tests/qtest/boot-serial-test.c > @@ -149,7 +149,7 @@ static testdef_t tests[] = { > { "arm", "raspi2", "", "TT", sizeof(bios_raspi2), 0, bios_raspi2 }, > /* For hppa, force bios to output to serial by disabling graphics. */ > { "hppa", "hppa", "-vga none", "SeaBIOS wants SYSTEM HALT" }, > - { "aarch64", "virt", "-cpu cortex-a57", "TT", sizeof(kernel_aarch64), > + { "aarch64", "virt", "-cpu max", "TT", sizeof(kernel_aarch64), > kernel_aarch64 }, > { "arm", "microbit", "", "T", sizeof(kernel_nrf51), kernel_nrf51 }, > > -- > 2.26.2 > > Reviewed-by: Andrew Jones <drjones@redhat.com>
diff --git a/tests/qtest/boot-serial-test.c b/tests/qtest/boot-serial-test.c index b6b1c23cd01..d74509b1c57 100644 --- a/tests/qtest/boot-serial-test.c +++ b/tests/qtest/boot-serial-test.c @@ -149,7 +149,7 @@ static testdef_t tests[] = { { "arm", "raspi2", "", "TT", sizeof(bios_raspi2), 0, bios_raspi2 }, /* For hppa, force bios to output to serial by disabling graphics. */ { "hppa", "hppa", "-vga none", "SeaBIOS wants SYSTEM HALT" }, - { "aarch64", "virt", "-cpu cortex-a57", "TT", sizeof(kernel_aarch64), + { "aarch64", "virt", "-cpu max", "TT", sizeof(kernel_aarch64), kernel_aarch64 }, { "arm", "microbit", "", "T", sizeof(kernel_nrf51), kernel_nrf51 },
When using KVM, using a specific cpu type will only work if the host CPU really is that exact CPU type. During testing we can simply use the 'max' CPU which will select all the features available from the host. This allow running this test on a Cavium CN8890 (ThunderX cores). Suggested-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- tests/qtest/boot-serial-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)