| Message ID | 20210128144144.27617-1-vsementsov@virtuozzo.com |
|---|---|
| State | New |
| Headers | show |
| Series | MAINTAINERS: suggest myself as co-maintainer for Block Jobs | expand |
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes: > I'm developing Qemu backup for several years, and finally new backup > architecture, including block-copy generic engine and backup-top filter > landed upstream, great thanks to reviewers and especially to > Max Reitz! > > I also have plans of moving other block-jobs onto block-copy, so that > we finally have one generic block copying path, fast and well-formed. > > So, now I suggest to bring all parts of backup architecture into > "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and > qemu-co-shared-resource can be reused somewhere else, but I'd keep an > eye on them in context of block-jobs) and add myself as co-maintainer. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> With pleasure: Reviewed-by: Markus Armbruster <armbru@redhat.com>
On 1/28/21 10:09 AM, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes: > >> I'm developing Qemu backup for several years, and finally new backup >> architecture, including block-copy generic engine and backup-top filter >> landed upstream, great thanks to reviewers and especially to >> Max Reitz! >> >> I also have plans of moving other block-jobs onto block-copy, so that >> we finally have one generic block copying path, fast and well-formed. >> >> So, now I suggest to bring all parts of backup architecture into >> "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and >> qemu-co-shared-resource can be reused somewhere else, but I'd keep an >> eye on them in context of block-jobs) and add myself as co-maintainer. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > > With pleasure: > Reviewed-by: Markus Armbruster <armbru@redhat.com> > Absolutely! Glad to see it. Reviewed-by: John Snow <jsnow@redhat.com>
On 28.01.21 15:41, Vladimir Sementsov-Ogievskiy wrote: > I'm developing Qemu backup for several years, and finally new backup > architecture, including block-copy generic engine and backup-top filter > landed upstream, great thanks to reviewers and especially to > Max Reitz! > > I also have plans of moving other block-jobs onto block-copy, so that > we finally have one generic block copying path, fast and well-formed. > > So, now I suggest to bring all parts of backup architecture into > "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and > qemu-co-shared-resource can be reused somewhere else, but I'd keep an > eye on them in context of block-jobs) and add myself as co-maintainer. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > --- > MAINTAINERS | 9 +++++++++ > 1 file changed, 9 insertions(+) Great! :) Reviewed-by: Max Reitz <mreitz@redhat.com>
28.01.2021 18:28, John Snow wrote: > On 1/28/21 10:09 AM, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes: >> >>> I'm developing Qemu backup for several years, and finally new backup >>> architecture, including block-copy generic engine and backup-top filter >>> landed upstream, great thanks to reviewers and especially to >>> Max Reitz! >>> >>> I also have plans of moving other block-jobs onto block-copy, so that >>> we finally have one generic block copying path, fast and well-formed. >>> >>> So, now I suggest to bring all parts of backup architecture into >>> "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and >>> qemu-co-shared-resource can be reused somewhere else, but I'd keep an >>> eye on them in context of block-jobs) and add myself as co-maintainer. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> >> >> With pleasure: >> Reviewed-by: Markus Armbruster <armbru@redhat.com> >> > > Absolutely! Glad to see it. > > Reviewed-by: John Snow <jsnow@redhat.com> > [..] > Great! > > Reviewed-by: Max Reitz <mreitz@redhat.com> Thanks! Could someone pull it? I don't have any signed PGP key for now, to send pull requests :\ Interesting, could I get one while sitting in Moscow?
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes: > 28.01.2021 18:28, John Snow wrote: >> On 1/28/21 10:09 AM, Markus Armbruster wrote: >>> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes: >>> >>>> I'm developing Qemu backup for several years, and finally new backup >>>> architecture, including block-copy generic engine and backup-top filter >>>> landed upstream, great thanks to reviewers and especially to >>>> Max Reitz! <snip> >> Great! >> >> Reviewed-by: Max Reitz <mreitz@redhat.com> > > > Thanks! > > Could someone pull it? > > I don't have any signed PGP key for now, to send pull requests :\ > Interesting, could I get one while sitting in Moscow? Hmm this does point somewhat to a hole in our maintainer process that has previously relied on semi-regular physical meet-up for key signing purposes. It might be some time before we return to a new normal. Are there any other maintainers in Moscow that you could safely meet for a socially distanced key-signing?
On Mon, Feb 01, 2021 at 01:50:26PM +0000, Alex Bennée wrote: > > Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes: > > > 28.01.2021 18:28, John Snow wrote: > >> On 1/28/21 10:09 AM, Markus Armbruster wrote: > >>> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes: > >>> > >>>> I'm developing Qemu backup for several years, and finally new backup > >>>> architecture, including block-copy generic engine and backup-top filter > >>>> landed upstream, great thanks to reviewers and especially to > >>>> Max Reitz! > <snip> > >> Great! > >> > >> Reviewed-by: Max Reitz <mreitz@redhat.com> > > > > > > Thanks! > > > > Could someone pull it? > > > > I don't have any signed PGP key for now, to send pull requests :\ > > Interesting, could I get one while sitting in Moscow? > > Hmm this does point somewhat to a hole in our maintainer process that has > previously relied on semi-regular physical meet-up for key signing > purposes. It might be some time before we return to a new normal. Are > there any other maintainers in Moscow that you could safely meet for a > socially distanced key-signing? AFAIK, we've never actually set expectations for what process a key signing must use. Merely that key should be signed by one or more people who are already QEMU maintainers. It is more or less up to the person signing the key what hoops they want to jump through before adding their signature. So while physically meeting is a traditional standard, some might be fine to do key signing verification over a video conference system, especially if both sides already know each other by sight after previous physical meetings. Regards, Daniel
Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben: > 28.01.2021 18:28, John Snow wrote: > > On 1/28/21 10:09 AM, Markus Armbruster wrote: > > > Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes: > > > > > > > I'm developing Qemu backup for several years, and finally new backup > > > > architecture, including block-copy generic engine and backup-top filter > > > > landed upstream, great thanks to reviewers and especially to > > > > Max Reitz! > > > > > > > > I also have plans of moving other block-jobs onto block-copy, so that > > > > we finally have one generic block copying path, fast and well-formed. > > > > > > > > So, now I suggest to bring all parts of backup architecture into > > > > "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and > > > > qemu-co-shared-resource can be reused somewhere else, but I'd keep an > > > > eye on them in context of block-jobs) and add myself as co-maintainer. > > > > > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > > > > > > With pleasure: > > > Reviewed-by: Markus Armbruster <armbru@redhat.com> > > > > > > > Absolutely! Glad to see it. > > > > Reviewed-by: John Snow <jsnow@redhat.com> > > > > [..] > > > Great! > > > > Reviewed-by: Max Reitz <mreitz@redhat.com> > > Thanks! > > Could someone pull it? I've put it in my block branch (with s/suggest myself/Add Vladimir/ in the subject line), but I don't know when I'll send the next pull request. If someone else sends one first, feel free to include it with: Acked-by: Kevin Wolf <kwolf@redhat.com> > I don't have any signed PGP key for now, to send pull requests :\ > Interesting, could I get one while sitting in Moscow? If you're planning to send pull requests, should a git tree of yours be added to the MAINTAINERS sections, too? Kevin
01.02.2021 17:50, Kevin Wolf wrote: > Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 28.01.2021 18:28, John Snow wrote: >>> On 1/28/21 10:09 AM, Markus Armbruster wrote: >>>> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes: >>>> >>>>> I'm developing Qemu backup for several years, and finally new backup >>>>> architecture, including block-copy generic engine and backup-top filter >>>>> landed upstream, great thanks to reviewers and especially to >>>>> Max Reitz! >>>>> >>>>> I also have plans of moving other block-jobs onto block-copy, so that >>>>> we finally have one generic block copying path, fast and well-formed. >>>>> >>>>> So, now I suggest to bring all parts of backup architecture into >>>>> "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and >>>>> qemu-co-shared-resource can be reused somewhere else, but I'd keep an >>>>> eye on them in context of block-jobs) and add myself as co-maintainer. >>>>> >>>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> >>>> >>>> With pleasure: >>>> Reviewed-by: Markus Armbruster <armbru@redhat.com> >>>> >>> >>> Absolutely! Glad to see it. >>> >>> Reviewed-by: John Snow <jsnow@redhat.com> >>> >> >> [..] >> >>> Great! >>> >>> Reviewed-by: Max Reitz <mreitz@redhat.com> >> >> Thanks! >> >> Could someone pull it? > > I've put it in my block branch (with s/suggest myself/Add Vladimir/ in > the subject line), but I don't know when I'll send the next pull > request. If someone else sends one first, feel free to include it with: > > Acked-by: Kevin Wolf <kwolf@redhat.com> > >> I don't have any signed PGP key for now, to send pull requests :\ >> Interesting, could I get one while sitting in Moscow? > > If you're planning to send pull requests, should a git tree of yours be > added to the MAINTAINERS sections, too? > I didn't add it because of signed key absence. As it turned out, Denis Lunev (my boss) already has a signed key, so it's not a problem. I think it's appropriate to add T: git https://src.openvz.org/scm/~vsementsov/qemu.git jobs
Am 01.02.2021 um 17:20 hat Vladimir Sementsov-Ogievskiy geschrieben: > 01.02.2021 17:50, Kevin Wolf wrote: > > Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 28.01.2021 18:28, John Snow wrote: > > > > On 1/28/21 10:09 AM, Markus Armbruster wrote: > > > > > Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes: > > > > > > > > > > > I'm developing Qemu backup for several years, and finally new backup > > > > > > architecture, including block-copy generic engine and backup-top filter > > > > > > landed upstream, great thanks to reviewers and especially to > > > > > > Max Reitz! > > > > > > > > > > > > I also have plans of moving other block-jobs onto block-copy, so that > > > > > > we finally have one generic block copying path, fast and well-formed. > > > > > > > > > > > > So, now I suggest to bring all parts of backup architecture into > > > > > > "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and > > > > > > qemu-co-shared-resource can be reused somewhere else, but I'd keep an > > > > > > eye on them in context of block-jobs) and add myself as co-maintainer. > > > > > > > > > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > > > > > > > > > > With pleasure: > > > > > Reviewed-by: Markus Armbruster <armbru@redhat.com> > > > > > > > > > > > > > Absolutely! Glad to see it. > > > > > > > > Reviewed-by: John Snow <jsnow@redhat.com> > > > > > > > > > > [..] > > > > > > > Great! > > > > > > > > Reviewed-by: Max Reitz <mreitz@redhat.com> > > > > > > Thanks! > > > > > > Could someone pull it? > > > > I've put it in my block branch (with s/suggest myself/Add Vladimir/ in > > the subject line), but I don't know when I'll send the next pull > > request. If someone else sends one first, feel free to include it with: > > > > Acked-by: Kevin Wolf <kwolf@redhat.com> > > > > > I don't have any signed PGP key for now, to send pull requests :\ > > > Interesting, could I get one while sitting in Moscow? > > > > If you're planning to send pull requests, should a git tree of yours be > > added to the MAINTAINERS sections, too? > > > > I didn't add it because of signed key absence. As it turned out, Denis > Lunev (my boss) already has a signed key, so it's not a problem. > > I think it's appropriate to add > > T: git https://src.openvz.org/scm/~vsementsov/qemu.git jobs I've added it to the patch in my queue. Now you just need to actually create that branch. :-) Kevin
01.02.2021 19:58, Kevin Wolf wrote: > Am 01.02.2021 um 17:20 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 01.02.2021 17:50, Kevin Wolf wrote: >>> Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben: >>>> 28.01.2021 18:28, John Snow wrote: >>>>> On 1/28/21 10:09 AM, Markus Armbruster wrote: >>>>>> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes: >>>>>> >>>>>>> I'm developing Qemu backup for several years, and finally new backup >>>>>>> architecture, including block-copy generic engine and backup-top filter >>>>>>> landed upstream, great thanks to reviewers and especially to >>>>>>> Max Reitz! >>>>>>> >>>>>>> I also have plans of moving other block-jobs onto block-copy, so that >>>>>>> we finally have one generic block copying path, fast and well-formed. >>>>>>> >>>>>>> So, now I suggest to bring all parts of backup architecture into >>>>>>> "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and >>>>>>> qemu-co-shared-resource can be reused somewhere else, but I'd keep an >>>>>>> eye on them in context of block-jobs) and add myself as co-maintainer. >>>>>>> >>>>>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> >>>>>> >>>>>> With pleasure: >>>>>> Reviewed-by: Markus Armbruster <armbru@redhat.com> >>>>>> >>>>> >>>>> Absolutely! Glad to see it. >>>>> >>>>> Reviewed-by: John Snow <jsnow@redhat.com> >>>>> >>>> >>>> [..] >>>> >>>>> Great! >>>>> >>>>> Reviewed-by: Max Reitz <mreitz@redhat.com> >>>> >>>> Thanks! >>>> >>>> Could someone pull it? >>> >>> I've put it in my block branch (with s/suggest myself/Add Vladimir/ in >>> the subject line), but I don't know when I'll send the next pull >>> request. If someone else sends one first, feel free to include it with: >>> >>> Acked-by: Kevin Wolf <kwolf@redhat.com> >>> >>>> I don't have any signed PGP key for now, to send pull requests :\ >>>> Interesting, could I get one while sitting in Moscow? >>> >>> If you're planning to send pull requests, should a git tree of yours be >>> added to the MAINTAINERS sections, too? >>> >> >> I didn't add it because of signed key absence. As it turned out, Denis >> Lunev (my boss) already has a signed key, so it's not a problem. >> >> I think it's appropriate to add >> >> T: git https://src.openvz.org/scm/~vsementsov/qemu.git jobs > > I've added it to the patch in my queue. Now you just need to actually > create that branch. :-) > done :)
01.02.2021 19:20, Vladimir Sementsov-Ogievskiy wrote: > 01.02.2021 17:50, Kevin Wolf wrote: >> Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> 28.01.2021 18:28, John Snow wrote: >>>> On 1/28/21 10:09 AM, Markus Armbruster wrote: >>>>> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes: >>>>> >>>>>> I'm developing Qemu backup for several years, and finally new backup >>>>>> architecture, including block-copy generic engine and backup-top filter >>>>>> landed upstream, great thanks to reviewers and especially to >>>>>> Max Reitz! >>>>>> >>>>>> I also have plans of moving other block-jobs onto block-copy, so that >>>>>> we finally have one generic block copying path, fast and well-formed. >>>>>> >>>>>> So, now I suggest to bring all parts of backup architecture into >>>>>> "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and >>>>>> qemu-co-shared-resource can be reused somewhere else, but I'd keep an >>>>>> eye on them in context of block-jobs) and add myself as co-maintainer. >>>>>> >>>>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> >>>>> >>>>> With pleasure: >>>>> Reviewed-by: Markus Armbruster <armbru@redhat.com> >>>>> >>>> >>>> Absolutely! Glad to see it. >>>> >>>> Reviewed-by: John Snow <jsnow@redhat.com> >>>> >>> >>> [..] >>> >>>> Great! >>>> >>>> Reviewed-by: Max Reitz <mreitz@redhat.com> >>> >>> Thanks! >>> >>> Could someone pull it? >> >> I've put it in my block branch (with s/suggest myself/Add Vladimir/ in >> the subject line), but I don't know when I'll send the next pull >> request. If someone else sends one first, feel free to include it with: >> >> Acked-by: Kevin Wolf <kwolf@redhat.com> >> >>> I don't have any signed PGP key for now, to send pull requests :\ >>> Interesting, could I get one while sitting in Moscow? >> >> If you're planning to send pull requests, should a git tree of yours be >> added to the MAINTAINERS sections, too? >> > > I didn't add it because of signed key absence. As it turned out, Denis Lunev (my boss) already has a signed key, so it's not a problem. > Unfortunately, Den doesn't have an access to his private key, so this variant doesn't work. So, probably someone could recognize me in a video call? My key is here: http://keys.gnupg.net/pks/lookup?search=Vladimir+Sementsov-Ogievskiy&fingerprint=on&op=index (note that there is only one Vladimir Sementsov-Ogievskiy, so I can't imagine who can that be other than me :)
On 2/3/21 3:22 AM, Vladimir Sementsov-Ogievskiy wrote: > 01.02.2021 19:20, Vladimir Sementsov-Ogievskiy wrote: >> 01.02.2021 17:50, Kevin Wolf wrote: >>> Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben: >>>> 28.01.2021 18:28, John Snow wrote: >>>>> On 1/28/21 10:09 AM, Markus Armbruster wrote: >>>>>> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes: >>>>>> >>>>>>> I'm developing Qemu backup for several years, and finally new backup >>>>>>> architecture, including block-copy generic engine and backup-top >>>>>>> filter >>>>>>> landed upstream, great thanks to reviewers and especially to >>>>>>> Max Reitz! >>>>>>> >>>>>>> I also have plans of moving other block-jobs onto block-copy, so >>>>>>> that >>>>>>> we finally have one generic block copying path, fast and >>>>>>> well-formed. >>>>>>> >>>>>>> So, now I suggest to bring all parts of backup architecture into >>>>>>> "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and >>>>>>> qemu-co-shared-resource can be reused somewhere else, but I'd >>>>>>> keep an >>>>>>> eye on them in context of block-jobs) and add myself as >>>>>>> co-maintainer. >>>>>>> >>>>>>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>>>>>> <vsementsov@virtuozzo.com> >>>>>> >>>>>> With pleasure: >>>>>> Reviewed-by: Markus Armbruster <armbru@redhat.com> >>>>>> >>>>> >>>>> Absolutely! Glad to see it. >>>>> >>>>> Reviewed-by: John Snow <jsnow@redhat.com> >>>>> >>>> >>>> [..] >>>> >>>>> Great! >>>>> >>>>> Reviewed-by: Max Reitz <mreitz@redhat.com> >>>> >>>> Thanks! >>>> >>>> Could someone pull it? >>> >>> I've put it in my block branch (with s/suggest myself/Add Vladimir/ in >>> the subject line), but I don't know when I'll send the next pull >>> request. If someone else sends one first, feel free to include it with: >>> >>> Acked-by: Kevin Wolf <kwolf@redhat.com> >>> >>>> I don't have any signed PGP key for now, to send pull requests :\ >>>> Interesting, could I get one while sitting in Moscow? >>> >>> If you're planning to send pull requests, should a git tree of yours be >>> added to the MAINTAINERS sections, too? >>> >> >> I didn't add it because of signed key absence. As it turned out, Denis >> Lunev (my boss) already has a signed key, so it's not a problem. >> > > Unfortunately, Den doesn't have an access to his private key, so this > variant doesn't work. So, probably someone could recognize me in a video > call? > > My key is here: > http://keys.gnupg.net/pks/lookup?search=Vladimir+Sementsov-Ogievskiy&fingerprint=on&op=index > (note that there is only one Vladimir Sementsov-Ogievskiy, so I can't > imagine who can that be other than me :) > I'm not sure what protocol here is, but you and I and several others met face to face in edinburgh and could at least weakly identify you. Maybe we can sign with a low level of trust for now, and improve it when we get a chance to do a real key signing meetup later? I think Peter needs to trust your key, ultimately, so I think it's up to him for what criteria he will personally trust. --js
diff --git a/MAINTAINERS b/MAINTAINERS index 34359a99b8..9957f39eba 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2207,6 +2207,7 @@ F: scsi/* Block Jobs M: John Snow <jsnow@redhat.com> +M: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> L: qemu-block@nongnu.org S: Supported F: blockjob.c @@ -2219,6 +2220,14 @@ F: block/commit.c F: block/stream.c F: block/mirror.c F: qapi/job.json +F: block/block-copy.c +F: include/block/block-copy.c +F: block/backup-top.h +F: block/backup-top.c +F: include/block/aio_task.h +F: block/aio_task.c +F: util/qemu-co-shared-resource.c +F: include/qemu/co-shared-resource.h T: git https://gitlab.com/jsnow/qemu.git jobs Block QAPI, monitor, command line
I'm developing Qemu backup for several years, and finally new backup architecture, including block-copy generic engine and backup-top filter landed upstream, great thanks to reviewers and especially to Max Reitz! I also have plans of moving other block-jobs onto block-copy, so that we finally have one generic block copying path, fast and well-formed. So, now I suggest to bring all parts of backup architecture into "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and qemu-co-shared-resource can be reused somewhere else, but I'd keep an eye on them in context of block-jobs) and add myself as co-maintainer. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> --- MAINTAINERS | 9 +++++++++ 1 file changed, 9 insertions(+)