Message ID | 20210117164813.4101761-2-f4bug@amsat.org |
---|---|
State | New |
Headers | show |
Series | accel: Restrict TCG-specific code | expand |
On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote: > cpu_gen_init() is TCG specific, only used in tcg/translate-all.c. > No need to export it to other accelerators, declare it statically. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > We could also inline the 1-line call.. > --- > include/exec/exec-all.h | 2 -- > accel/tcg/translate-all.c | 2 +- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h > index 2e5b4bba48f..516013e735a 100644 > --- a/include/exec/exec-all.h > +++ b/include/exec/exec-all.h > @@ -47,8 +47,6 @@ void gen_intermediate_code(CPUState *cpu, TranslationBlock *tb, int max_insns); > void restore_state_to_opc(CPUArchState *env, TranslationBlock *tb, > target_ulong *data); > > -void cpu_gen_init(void); > - > /** > * cpu_restore_state: > * @cpu: the vCPU state is to be restore to > diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c > index e9de6ff9dd7..ca7ef6aa177 100644 > --- a/accel/tcg/translate-all.c > +++ b/accel/tcg/translate-all.c > @@ -243,7 +243,7 @@ static void page_table_config_init(void) > assert(v_l2_levels >= 0); > } > > -void cpu_gen_init(void) > +static void cpu_gen_init(void) > { > tcg_context_init(&tcg_init_ctx); > } > Reviewed-by: Claudio Fontana <cfontana@suse.de>
On 1/17/21 6:48 AM, Philippe Mathieu-Daudé wrote: > cpu_gen_init() is TCG specific, only used in tcg/translate-all.c. > No need to export it to other accelerators, declare it statically. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > We could also inline the 1-line call.. > --- > include/exec/exec-all.h | 2 -- > accel/tcg/translate-all.c | 2 +- > 2 files changed, 1 insertion(+), 3 deletions(-) Applied to tcg-next. r~
diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 2e5b4bba48f..516013e735a 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec-all.h @@ -47,8 +47,6 @@ void gen_intermediate_code(CPUState *cpu, TranslationBlock *tb, int max_insns); void restore_state_to_opc(CPUArchState *env, TranslationBlock *tb, target_ulong *data); -void cpu_gen_init(void); - /** * cpu_restore_state: * @cpu: the vCPU state is to be restore to diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index e9de6ff9dd7..ca7ef6aa177 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -243,7 +243,7 @@ static void page_table_config_init(void) assert(v_l2_levels >= 0); } -void cpu_gen_init(void) +static void cpu_gen_init(void) { tcg_context_init(&tcg_init_ctx); }
cpu_gen_init() is TCG specific, only used in tcg/translate-all.c. No need to export it to other accelerators, declare it statically. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- We could also inline the 1-line call.. --- include/exec/exec-all.h | 2 -- accel/tcg/translate-all.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-)