| Message ID | 20210107202135.52379-1-david@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | target/s390x: Fix ALGSI | expand |
On 07.01.21 21:21, David Hildenbrand wrote: > Looks like something went wrong while touching that line. Instead of "r1" > we need a new temporary. Also, we have to pass MO_TEQ, to indicate that > we are working with 64-bit values. Let's revert these changes. > > Fixes: ff26d287bddc ("target/s390x: Improve cc computation for ADD LOGICAL") > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > target/s390x/insn-data.def | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def > index 26badb663a..eac5136ee5 100644 > --- a/target/s390x/insn-data.def > +++ b/target/s390x/insn-data.def > @@ -76,7 +76,7 @@ > /* ADD LOGICAL WITH SIGNED IMMEDIATE */ > D(0xeb6e, ALSI, SIY, GIE, la1, i2_32u, new, 0, asi, addu32, MO_TEUL) > C(0xecda, ALHSIK, RIE_d, DO, r3_32u, i2_32u, new, r1_32, add, addu32) > - C(0xeb7e, ALGSI, SIY, GIE, la1, i2, r1, 0, asiu64, addu64) > + D(0xeb7e, ALGSI, SIY, GIE, la1, i2, new, 0, asiu64, addu64, MO_TEQ) > C(0xecdb, ALGHSIK, RIE_d, DO, r3, i2, r1, 0, addu64, addu64) > /* ADD LOGICAL WITH SIGNED IMMEDIATE HIGH */ > C(0xcc0a, ALSIH, RIL_a, HW, r1_sr32, i2_32u, new, r1_32h, add, addu32) > Subject should be "s390x/tcg" ...
diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index 26badb663a..eac5136ee5 100644 --- a/target/s390x/insn-data.def +++ b/target/s390x/insn-data.def @@ -76,7 +76,7 @@ /* ADD LOGICAL WITH SIGNED IMMEDIATE */ D(0xeb6e, ALSI, SIY, GIE, la1, i2_32u, new, 0, asi, addu32, MO_TEUL) C(0xecda, ALHSIK, RIE_d, DO, r3_32u, i2_32u, new, r1_32, add, addu32) - C(0xeb7e, ALGSI, SIY, GIE, la1, i2, r1, 0, asiu64, addu64) + D(0xeb7e, ALGSI, SIY, GIE, la1, i2, new, 0, asiu64, addu64, MO_TEQ) C(0xecdb, ALGHSIK, RIE_d, DO, r3, i2, r1, 0, addu64, addu64) /* ADD LOGICAL WITH SIGNED IMMEDIATE HIGH */ C(0xcc0a, ALSIH, RIL_a, HW, r1_sr32, i2_32u, new, r1_32h, add, addu32)
Looks like something went wrong while touching that line. Instead of "r1" we need a new temporary. Also, we have to pass MO_TEQ, to indicate that we are working with 64-bit values. Let's revert these changes. Fixes: ff26d287bddc ("target/s390x: Improve cc computation for ADD LOGICAL") Signed-off-by: David Hildenbrand <david@redhat.com> --- target/s390x/insn-data.def | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)