diff mbox series

[3/4] configure: accept --enable-slirp

Message ID 20201217085005.10644-4-pbonzini@redhat.com
State New
Headers show
Series First batch of configure cleanups | expand

Commit Message

Paolo Bonzini Dec. 17, 2020, 8:50 a.m. UTC 
Meson understands -Dslirp=enabled, so there is no reason not to
accept the configure option as well.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Huth Dec. 17, 2020, 9:06 a.m. UTC | #1 
On 17/12/2020 09.50, Paolo Bonzini wrote:
> Meson understands -Dslirp=enabled, so there is no reason not to
> accept the configure option as well.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  configure | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/configure b/configure
> index 18af8207d9..568818e72d 100755
> --- a/configure
> +++ b/configure
> @@ -1083,6 +1083,8 @@ for opt do
>    ;;
>    --disable-slirp) slirp="disabled"
>    ;;
> +  --enable-slirp) slirp="enabled"
> +  ;;
>    --enable-slirp=git) slirp="internal"
>    ;;
>    --enable-slirp=system) slirp="system"
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>
Marc-André Lureau Dec. 17, 2020, 10:22 a.m. UTC | #2 
On Thu, Dec 17, 2020 at 12:52 PM Paolo Bonzini <pbonzini@redhat.com> wrote:

> Meson understands -Dslirp=enabled, so there is no reason not to
> accept the configure option as well.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

---
>  configure | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/configure b/configure
> index 18af8207d9..568818e72d 100755
> --- a/configure
> +++ b/configure
> @@ -1083,6 +1083,8 @@ for opt do
>    ;;
>    --disable-slirp) slirp="disabled"
>    ;;
> +  --enable-slirp) slirp="enabled"
> +  ;;
>    --enable-slirp=git) slirp="internal"
>    ;;
>    --enable-slirp=system) slirp="system"
> --
> 2.29.2
>
>
>
>
diff mbox series

Patch

diff --git a/configure b/configure
index 18af8207d9..568818e72d 100755
--- a/configure
+++ b/configure
@@ -1083,6 +1083,8 @@  for opt do
   ;;
   --disable-slirp) slirp="disabled"
   ;;
+  --enable-slirp) slirp="enabled"
+  ;;
   --enable-slirp=git) slirp="internal"
   ;;
   --enable-slirp=system) slirp="system"