| Message ID | 20201129203923.10622-5-peter.maydell@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | Improve reporting of ROM blob overlap errors | expand |
On 11/29/20 2:39 PM, Peter Maydell wrote: > Instead of making the ROM blob name something like: > phdr #0: /home/petmay01/linaro/qemu-misc-tests/ldmia-fault.axf > make it a little more self-explanatory for people who don't know > ELF format details: > /home/petmay01/linaro/qemu-misc-tests/ldmia-fault.axf ELF program header segment 0 > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h index 53e0152af53..8e8436831d2 100644 --- a/include/hw/elf_ops.h +++ b/include/hw/elf_ops.h @@ -544,7 +544,8 @@ static int glue(load_elf, SZ)(const char *name, int fd, if (mem_size != 0) { if (load_rom) { g_autofree char *label = - g_strdup_printf("phdr #%d: %s", i, name); + g_strdup_printf("%s ELF program header segment %d", + name, i); /* * rom_add_elf_program() takes its own reference to
Instead of making the ROM blob name something like: phdr #0: /home/petmay01/linaro/qemu-misc-tests/ldmia-fault.axf make it a little more self-explanatory for people who don't know ELF format details: /home/petmay01/linaro/qemu-misc-tests/ldmia-fault.axf ELF program header segment 0 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- This seems nicer to me, but it's a matter of taste, so if people prefer the current name form we should probably leave it be. --- include/hw/elf_ops.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)