| Message ID | 20201119161710.1985083-2-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | linux-user: Support o32 ABI with 64-bit MIPS CPUs | expand |
On 11/19/20 8:17 AM, Philippe Mathieu-Daudé wrote: > 64-bit MIPS targets lost setup_frame() during the refactor in commit > 8949bef18b9. Restore it declaring TARGET_ARCH_HAS_SETUP_FRAME, to be > able to build the o32 ABI target. > > Fixes: 8949bef18b9 ("linux-user: move mips/mips64 signal.c parts to mips directory") > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > linux-user/mips64/target_signal.h | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
Le 19/11/2020 à 17:17, Philippe Mathieu-Daudé a écrit : > 64-bit MIPS targets lost setup_frame() during the refactor in commit > 8949bef18b9. Restore it declaring TARGET_ARCH_HAS_SETUP_FRAME, to be > able to build the o32 ABI target. > > Fixes: 8949bef18b9 ("linux-user: move mips/mips64 signal.c parts to mips directory") > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > linux-user/mips64/target_signal.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/linux-user/mips64/target_signal.h b/linux-user/mips64/target_signal.h > index 799f7a668cd..f1f0ed7f706 100644 > --- a/linux-user/mips64/target_signal.h > +++ b/linux-user/mips64/target_signal.h > @@ -67,4 +67,8 @@ typedef struct target_sigaltstack { > #define TARGET_MINSIGSTKSZ 2048 > #define TARGET_SIGSTKSZ 8192 > > +#if defined(TARGET_ABI_MIPSO32) > +/* compare linux/arch/mips/kernel/signal.c:setup_frame() */ > +#define TARGET_ARCH_HAS_SETUP_FRAME > +#endif > #endif /* MIPS64_TARGET_SIGNAL_H */ > Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Le 19/11/2020 à 17:17, Philippe Mathieu-Daudé a écrit : > 64-bit MIPS targets lost setup_frame() during the refactor in commit > 8949bef18b9. Restore it declaring TARGET_ARCH_HAS_SETUP_FRAME, to be > able to build the o32 ABI target. > > Fixes: 8949bef18b9 ("linux-user: move mips/mips64 signal.c parts to mips directory") > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > linux-user/mips64/target_signal.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/linux-user/mips64/target_signal.h b/linux-user/mips64/target_signal.h > index 799f7a668cd..f1f0ed7f706 100644 > --- a/linux-user/mips64/target_signal.h > +++ b/linux-user/mips64/target_signal.h > @@ -67,4 +67,8 @@ typedef struct target_sigaltstack { > #define TARGET_MINSIGSTKSZ 2048 > #define TARGET_SIGSTKSZ 8192 > > +#if defined(TARGET_ABI_MIPSO32) > +/* compare linux/arch/mips/kernel/signal.c:setup_frame() */ > +#define TARGET_ARCH_HAS_SETUP_FRAME > +#endif > #endif /* MIPS64_TARGET_SIGNAL_H */ > Applied to my linux-user-for-6.0 branch. Thanks, Laurent
diff --git a/linux-user/mips64/target_signal.h b/linux-user/mips64/target_signal.h index 799f7a668cd..f1f0ed7f706 100644 --- a/linux-user/mips64/target_signal.h +++ b/linux-user/mips64/target_signal.h @@ -67,4 +67,8 @@ typedef struct target_sigaltstack { #define TARGET_MINSIGSTKSZ 2048 #define TARGET_SIGSTKSZ 8192 +#if defined(TARGET_ABI_MIPSO32) +/* compare linux/arch/mips/kernel/signal.c:setup_frame() */ +#define TARGET_ARCH_HAS_SETUP_FRAME +#endif #endif /* MIPS64_TARGET_SIGNAL_H */
64-bit MIPS targets lost setup_frame() during the refactor in commit 8949bef18b9. Restore it declaring TARGET_ARCH_HAS_SETUP_FRAME, to be able to build the o32 ABI target. Fixes: 8949bef18b9 ("linux-user: move mips/mips64 signal.c parts to mips directory") Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- linux-user/mips64/target_signal.h | 4 ++++ 1 file changed, 4 insertions(+)