diff mbox series

[1/1] gitlab-ci: Use $CI_REGISTRY instead of hard-coding registry.gitlab.com

Message ID 20201113172519.31056-1-rebecca@nuviainc.com
State New
Headers show
Series [1/1] gitlab-ci: Use $CI_REGISTRY instead of hard-coding registry.gitlab.com | expand

Commit Message

Rebecca Cran Nov. 13, 2020, 5:25 p.m. UTC
Update containers.yml to use the $CI_REGISTRY variable as other files
such as edk2.yml do.

Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
 .gitlab-ci.d/containers.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé Nov. 16, 2020, 11:59 a.m. UTC | #1
On 11/13/20 6:25 PM, Rebecca Cran wrote:
> Update containers.yml to use the $CI_REGISTRY variable as other files
> such as edk2.yml do.
> 
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
>  .gitlab-ci.d/containers.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.d/containers.yml b/.gitlab-ci.d/containers.yml
> index 11d079ea5810..892ca8d838ce 100644
> --- a/.gitlab-ci.d/containers.yml
> +++ b/.gitlab-ci.d/containers.yml
> @@ -8,7 +8,7 @@
>      - export COMMON_TAG="$CI_REGISTRY/qemu-project/qemu/$NAME:latest"
>      - apk add python3
>      - docker info
> -    - docker login registry.gitlab.com -u "$CI_REGISTRY_USER" -p "$CI_REGISTRY_PASSWORD"
> +    - docker login $CI_REGISTRY -u "$CI_REGISTRY_USER" -p "$CI_REGISTRY_PASSWORD"
>    script:
>      - echo "TAG:$TAG"
>      - echo "COMMON_TAG:$COMMON_TAG"
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff mbox series

Patch

diff --git a/.gitlab-ci.d/containers.yml b/.gitlab-ci.d/containers.yml
index 11d079ea5810..892ca8d838ce 100644
--- a/.gitlab-ci.d/containers.yml
+++ b/.gitlab-ci.d/containers.yml
@@ -8,7 +8,7 @@ 
     - export COMMON_TAG="$CI_REGISTRY/qemu-project/qemu/$NAME:latest"
     - apk add python3
     - docker info
-    - docker login registry.gitlab.com -u "$CI_REGISTRY_USER" -p "$CI_REGISTRY_PASSWORD"
+    - docker login $CI_REGISTRY -u "$CI_REGISTRY_USER" -p "$CI_REGISTRY_PASSWORD"
   script:
     - echo "TAG:$TAG"
     - echo "COMMON_TAG:$COMMON_TAG"