| Message ID | 20201109030452.2197-3-fangying1@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | hw/arm/virt: Introduce cpu and cache topology support | expand |
Hi Fangying, Same here. Why not club [01/13] and [02/13] together and send it separately? Thanks > From: fangying > Sent: Monday, November 9, 2020 3:05 AM > To: peter.maydell@linaro.org > Cc: qemu-devel@nongnu.org; qemu-arm@nongnu.org; drjones@redhat.com; > imammedo@redhat.com; shannon.zhaosl@gmail.com; alistair.francis@wdc.com; > Zhanghailiang <zhang.zhanghailiang@huawei.com>; Salil Mehta > <salil.mehta@huawei.com> > Subject: [RFC PATCH v3 02/13] hw/arm/virt: Remove unused variable > > From: Andrew Jones <drjones@redhat.com> > > We no longer use the smp_cpus virtual machine state variable. > Remove it. > > Signed-off-by: Andrew Jones <drjones@redhat.com> > --- > hw/arm/virt.c | 2 -- > include/hw/arm/virt.h | 1 - > 2 files changed, 3 deletions(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 0069fa1298..ea24b576c6 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -1820,8 +1820,6 @@ static void machvirt_init(MachineState *machine) > exit(1); > } > > - vms->smp_cpus = smp_cpus; > - > if (vms->virt && kvm_enabled()) { > error_report("mach-virt: KVM does not support providing " > "Virtualization extensions to the guest CPU"); > diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h > index 953d94acc0..010f24f580 100644 > --- a/include/hw/arm/virt.h > +++ b/include/hw/arm/virt.h > @@ -151,7 +151,6 @@ struct VirtMachineState { > MemMapEntry *memmap; > char *pciehb_nodename; > const int *irqmap; > - int smp_cpus; > void *fdt; > int fdt_size; > uint32_t clock_phandle; > -- > 2.23.0
diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 0069fa1298..ea24b576c6 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1820,8 +1820,6 @@ static void machvirt_init(MachineState *machine) exit(1); } - vms->smp_cpus = smp_cpus; - if (vms->virt && kvm_enabled()) { error_report("mach-virt: KVM does not support providing " "Virtualization extensions to the guest CPU"); diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h index 953d94acc0..010f24f580 100644 --- a/include/hw/arm/virt.h +++ b/include/hw/arm/virt.h @@ -151,7 +151,6 @@ struct VirtMachineState { MemMapEntry *memmap; char *pciehb_nodename; const int *irqmap; - int smp_cpus; void *fdt; int fdt_size; uint32_t clock_phandle;