| Message ID | 20201020193555.1493936-7-jsnow@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | python: create installable package | expand |
On Tue, Oct 20, 2020 at 03:35:46PM -0400, John Snow wrote: > Pylint 2.5.x and 2.6.x have regressions that make import checking > inconsistent, see: > > https: //github.com/PyCQA/pylint/issues/3609 > https: //github.com/PyCQA/pylint/issues/3624 > https: //github.com/PyCQA/pylint/issues/3651 > Are these whitespaces on purpose? > Pinning to 2.4.4 is worse, because it mandates versions of shared > dependencies that are too old for features we want in isort and mypy. > Oh well. > > Signed-off-by: John Snow <jsnow@redhat.com> Other than that, Reviewed-by: Cleber Rosa <crosa@redhat.com>
On 10/28/20 6:24 PM, Cleber Rosa wrote: > On Tue, Oct 20, 2020 at 03:35:46PM -0400, John Snow wrote: >> Pylint 2.5.x and 2.6.x have regressions that make import checking >> inconsistent, see: >> >> https: //github.com/PyCQA/pylint/issues/3609 >> https: //github.com/PyCQA/pylint/issues/3624 >> https: //github.com/PyCQA/pylint/issues/3651 >> > > Are these whitespaces on purpose? > Uh, nope. How'd that happen? >> Pinning to 2.4.4 is worse, because it mandates versions of shared >> dependencies that are too old for features we want in isort and mypy. >> Oh well. >> >> Signed-off-by: John Snow <jsnow@redhat.com> > > Other than that, > > Reviewed-by: Cleber Rosa <crosa@redhat.com> >
diff --git a/python/qemu/machine/__init__.py b/python/qemu/machine/__init__.py index 27b0b19abd..15e466a8d3 100644 --- a/python/qemu/machine/__init__.py +++ b/python/qemu/machine/__init__.py @@ -26,6 +26,9 @@ # the COPYING file in the top-level directory. # +# pylint: disable=import-error +# see: https://github.com/PyCQA/pylint/issues/3624 +# see: https://github.com/PyCQA/pylint/issues/3651 from .accel import kvm_available, list_accel, tcg_available from .machine import QEMUMachine from .qtest import QEMUQtestMachine, QEMUQtestProtocol diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py index a5dc305539..88c51f5052 100644 --- a/python/qemu/machine/machine.py +++ b/python/qemu/machine/machine.py @@ -38,7 +38,7 @@ Type, ) -from qemu.qmp import ( +from qemu.qmp import ( # pylint: disable=import-error QEMUMonitorProtocol, QMPMessage, QMPReturnValue, diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py index 53926e434a..c3adf4e301 100644 --- a/python/qemu/machine/qtest.py +++ b/python/qemu/machine/qtest.py @@ -26,7 +26,7 @@ TextIO, ) -from qemu.qmp import SocketAddrT +from qemu.qmp import SocketAddrT # pylint: disable=import-error from .machine import QEMUMachine
Pylint 2.5.x and 2.6.x have regressions that make import checking inconsistent, see: https: //github.com/PyCQA/pylint/issues/3609 https: //github.com/PyCQA/pylint/issues/3624 https: //github.com/PyCQA/pylint/issues/3651 Pinning to 2.4.4 is worse, because it mandates versions of shared dependencies that are too old for features we want in isort and mypy. Oh well. Signed-off-by: John Snow <jsnow@redhat.com> --- python/qemu/machine/__init__.py | 3 +++ python/qemu/machine/machine.py | 2 +- python/qemu/machine/qtest.py | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-)