diff mbox series

[2/3] Acceptance tests: do not show canceled test logs on GitLab CI

Message ID 20201009205513.751968-3-crosa@redhat.com
State New
Headers show
Series Acceptance Tests: improve usage on GitLab CI | expand

Commit Message

Cleber Rosa Oct. 9, 2020, 8:55 p.m. UTC
Tests resulting in "CANCEL" in Avocado are usually canceled on
purpose, and are almost identical to "SKIP".  The logs for canceled
tests are adding a lot of noise to the logs being shown on GitLab CI,
and causing distraction from real failures.

As a side note, this "after script" is scheduled for removal once the
feature is implemented within Avocado itself.

Reference: https://github.com/avocado-framework/avocado/issues/4266
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 .gitlab-ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé Oct. 10, 2020, 9:10 a.m. UTC | #1
On 10/9/20 10:55 PM, Cleber Rosa wrote:
> Tests resulting in "CANCEL" in Avocado are usually canceled on
> purpose, and are almost identical to "SKIP".  The logs for canceled
> tests are adding a lot of noise to the logs being shown on GitLab CI,
> and causing distraction from real failures.

Thanks, big improvement!!!

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> 
> As a side note, this "after script" is scheduled for removal once the
> feature is implemented within Avocado itself.
> 
> Reference: https://github.com/avocado-framework/avocado/issues/4266
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>   .gitlab-ci.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index a51c89554f..bed5fe6161 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -63,7 +63,7 @@ include:
>         fi
>     after_script:
>       - cd build
> -    - python3 -c 'import json; r = json.load(open("tests/results/latest/results.json")); [print(t["logfile"]) for t in r["tests"] if t["status"] not in ("PASS", "SKIP")]' | xargs cat
> +    - python3 -c 'import json; r = json.load(open("tests/results/latest/results.json")); [print(t["logfile"]) for t in r["tests"] if t["status"] not in ("PASS", "SKIP", "CANCEL")]' | xargs cat
>       - du -chs ${CI_PROJECT_DIR}/avocado-cache
>   
>   build-system-ubuntu:
>
diff mbox series

Patch

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index a51c89554f..bed5fe6161 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -63,7 +63,7 @@  include:
       fi
   after_script:
     - cd build
-    - python3 -c 'import json; r = json.load(open("tests/results/latest/results.json")); [print(t["logfile"]) for t in r["tests"] if t["status"] not in ("PASS", "SKIP")]' | xargs cat
+    - python3 -c 'import json; r = json.load(open("tests/results/latest/results.json")); [print(t["logfile"]) for t in r["tests"] if t["status"] not in ("PASS", "SKIP", "CANCEL")]' | xargs cat
     - du -chs ${CI_PROJECT_DIR}/avocado-cache
 
 build-system-ubuntu: