| Message ID | 20200922211802.4083666-14-jsnow@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | qapi: static typing conversion, pt3 | expand |
On Tue, Sep 22, 2020 at 05:18:01PM -0400, John Snow wrote: > Objects may have variants, but those variants must themselves be > objects. This is difficult to express with our current type system and > hierarchy, so instead pepper in an assertion. > > Note: These assertions don't appear to be useful yet because schema.py > is not yet typed. Once it is, these assertions will matter. > > Signed-off-by: John Snow <jsnow@redhat.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
diff --git a/scripts/qapi/doc.py b/scripts/qapi/doc.py index b96d9046d3..3de592e220 100644 --- a/scripts/qapi/doc.py +++ b/scripts/qapi/doc.py @@ -206,6 +206,7 @@ def texi_members(doc: QAPIDoc, if base: items += '@item The members of @code{%s}\n' % base.doc_type() for variant in variants.variants if variants else (): + assert isinstance(variant.type, QAPISchemaObjectType) when = ' when @code{%s} is @t{"%s"}%s' % ( variants.tag_member.name, variant.name, texi_if(variant.ifcond, " (", ")"))
Objects may have variants, but those variants must themselves be objects. This is difficult to express with our current type system and hierarchy, so instead pepper in an assertion. Note: These assertions don't appear to be useful yet because schema.py is not yet typed. Once it is, these assertions will matter. Signed-off-by: John Snow <jsnow@redhat.com> --- scripts/qapi/doc.py | 1 + 1 file changed, 1 insertion(+)