| Message ID | 20200910054516.405777-1-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] configure: Do not intent to build WHPX on 32-bit host | expand |
Am 10.09.20 um 07:45 schrieb Philippe Mathieu-Daudé: > Hyper-V is available on 64-bit versions of Windows, > do not try to build its support on 32-bit versions. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > Since v1: Handle MinGW automatic detection (Thomas, Stefan) > --- > configure | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 4231d56bcc0..91c5d781845 100755 > --- a/configure > +++ b/configure > @@ -2980,7 +2980,10 @@ fi > > ########################################## > # Windows Hypervisor Platform accelerator (WHPX) check > -if test "$whpx" != "no" ; then > +if test "$whpx" = "yes" && test "$ARCH" != "x86_64"; then > + error_exit "WHPX requires 64-bit host" > +fi > +if test "$whpx" != "no" && test "$ARCH" = "x86_64"; then > if check_include "WinHvPlatform.h" && check_include "WinHvEmulation.h"; then > whpx="yes" > else Reviewed-by: Stefan Weil <sw@weilnetz.de> Thanks!
On 10/09/20 07:45, Philippe Mathieu-Daudé wrote: > Hyper-V is available on 64-bit versions of Windows, > do not try to build its support on 32-bit versions. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > Since v1: Handle MinGW automatic detection (Thomas, Stefan) > --- > configure | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 4231d56bcc0..91c5d781845 100755 > --- a/configure > +++ b/configure > @@ -2980,7 +2980,10 @@ fi > > ########################################## > # Windows Hypervisor Platform accelerator (WHPX) check > -if test "$whpx" != "no" ; then > +if test "$whpx" = "yes" && test "$ARCH" != "x86_64"; then > + error_exit "WHPX requires 64-bit host" > +fi > +if test "$whpx" != "no" && test "$ARCH" = "x86_64"; then > if check_include "WinHvPlatform.h" && check_include "WinHvEmulation.h"; then > whpx="yes" > else > Queued this one instead. Paolo
On 9/10/20 12:45 AM, Philippe Mathieu-Daudé wrote: In the subject, s/intent/attempt/ > Hyper-V is available on 64-bit versions of Windows, > do not try to build its support on 32-bit versions. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > Since v1: Handle MinGW automatic detection (Thomas, Stefan) > --- > configure | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
On 9/11/20 7:18 PM, Eric Blake wrote: > On 9/10/20 12:45 AM, Philippe Mathieu-Daudé wrote: > > In the subject, s/intent/attempt/ Oops thanks... Paolo can you fix that directly, or should I repost? > >> Hyper-V is available on 64-bit versions of Windows, >> do not try to build its support on 32-bit versions. >> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- >> Since v1: Handle MinGW automatic detection (Thomas, Stefan) >> --- >> configure | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3226 > Virtualization: qemu.org | libvirt.org > >
diff --git a/configure b/configure index 4231d56bcc0..91c5d781845 100755 --- a/configure +++ b/configure @@ -2980,7 +2980,10 @@ fi ########################################## # Windows Hypervisor Platform accelerator (WHPX) check -if test "$whpx" != "no" ; then +if test "$whpx" = "yes" && test "$ARCH" != "x86_64"; then + error_exit "WHPX requires 64-bit host" +fi +if test "$whpx" != "no" && test "$ARCH" = "x86_64"; then if check_include "WinHvPlatform.h" && check_include "WinHvEmulation.h"; then whpx="yes" else
Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- Since v1: Handle MinGW automatic detection (Thomas, Stefan) --- configure | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)