| Message ID | 20200904164258.240278-4-crosa@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | gitlab pipeline check/watch script improvements | expand |
On 9/4/20 6:42 PM, Cleber Rosa wrote: > When waiting for a pipeline to run and finish, it's better to give > early feedback, and then sleep and wait, than the other wait around. > > Specially for the first iteration, it's frustrating to see nothing > while the script is sleeping. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > scripts/ci/gitlab-pipeline-status | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/ci/gitlab-pipeline-status b/scripts/ci/gitlab-pipeline-status > index 2a36f74696..18609553be 100755 > --- a/scripts/ci/gitlab-pipeline-status > +++ b/scripts/ci/gitlab-pipeline-status > @@ -77,8 +77,8 @@ def wait_on_pipeline_success(timeout, interval, > > status = get_pipeline_status(project_id, commit_sha) > if status['status'] == 'running': > - time.sleep(interval) > print('running...') > + time.sleep(interval) > continue > > if status['status'] == 'success': >
diff --git a/scripts/ci/gitlab-pipeline-status b/scripts/ci/gitlab-pipeline-status index 2a36f74696..18609553be 100755 --- a/scripts/ci/gitlab-pipeline-status +++ b/scripts/ci/gitlab-pipeline-status @@ -77,8 +77,8 @@ def wait_on_pipeline_success(timeout, interval, status = get_pipeline_status(project_id, commit_sha) if status['status'] == 'running': - time.sleep(interval) print('running...') + time.sleep(interval) continue if status['status'] == 'success':
When waiting for a pipeline to run and finish, it's better to give early feedback, and then sleep and wait, than the other wait around. Specially for the first iteration, it's frustrating to see nothing while the script is sleeping. Signed-off-by: Cleber Rosa <crosa@redhat.com> --- scripts/ci/gitlab-pipeline-status | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)