Message ID | 20200815151245.10640-1-rohit.shinde12194@gmail.com |
---|---|
State | New |
Headers | show |
Series | Fixes: Fallthrough warning on line 270 of qemu/qapi/opts-visitor.c | expand |
This is v3 with no change w.r.t. v1/v2 (except this time you correctly Cc'ed the maintainers). Maybe something is wrong in your setup? On 8/15/20 5:12 PM, Rohit Shinde wrote: > Added the fallthrough comment so that the compiler doesn't emit an error on compiling with the -Wimplicit-fallthrough flag. > > Signed-off-by: Rohit Shinde <rohit.shinde12194@gmail.com> > --- > qapi/opts-visitor.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c > index 7781c23a42..43cf60d3a0 100644 > --- a/qapi/opts-visitor.c > +++ b/qapi/opts-visitor.c > @@ -266,6 +266,7 @@ opts_next_list(Visitor *v, GenericList *tail, size_t size) > } > ov->list_mode = LM_IN_PROGRESS; > /* range has been completed, fall through in order to pop option */ > + __attribute__((fallthrough)); > > case LM_IN_PROGRESS: { > const QemuOpt *opt; >
Patchew URL: https://patchew.org/QEMU/20200815151245.10640-1-rohit.shinde12194@gmail.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make docker-image-centos7 V=1 NETWORK=1 time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 === TEST SCRIPT END === CC qapi/qapi-visit-rdma.o CC qapi/qapi-visit-rocker.o /tmp/qemu-test/src/qapi/opts-visitor.c: In function 'opts_next_list': /tmp/qemu-test/src/qapi/opts-visitor.c:269:9: error: empty declaration [-Werror] __attribute__((fallthrough)); ^ cc1: all warnings being treated as errors make: *** [qapi/opts-visitor.o] Error 1 make: *** Waiting for unfinished jobs.... Traceback (most recent call last): File "./tests/docker/docker.py", line 709, in <module> --- raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=b5dcb092e02343cf9cd6f3efc4966930', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-vem4s832/src/docker-src.2020-08-15-12.28.53.24667:/var/tmp/qemu:z,ro', 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2. filter=--filter=label=com.qemu.instance.uuid=b5dcb092e02343cf9cd6f3efc4966930 make[1]: *** [docker-run] Error 1 make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-vem4s832/src' make: *** [docker-run-test-quick@centos7] Error 2 real 1m44.566s user 0m9.282s The full log is available at http://patchew.org/logs/20200815151245.10640-1-rohit.shinde12194@gmail.com/testing.docker-quick@centos7/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index 7781c23a42..43cf60d3a0 100644 --- a/qapi/opts-visitor.c +++ b/qapi/opts-visitor.c @@ -266,6 +266,7 @@ opts_next_list(Visitor *v, GenericList *tail, size_t size) } ov->list_mode = LM_IN_PROGRESS; /* range has been completed, fall through in order to pop option */ + __attribute__((fallthrough)); case LM_IN_PROGRESS: { const QemuOpt *opt;
Added the fallthrough comment so that the compiler doesn't emit an error on compiling with the -Wimplicit-fallthrough flag. Signed-off-by: Rohit Shinde <rohit.shinde12194@gmail.com> --- qapi/opts-visitor.c | 1 + 1 file changed, 1 insertion(+)