| Message ID | 20200804170055.2851-7-thuth@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Run cross-compilation build tests in the gitlab-CI | expand |
On 8/4/20 10:00 AM, Thomas Huth wrote: > In case we ever want to compile this for Windows, we need the $(EXESUF) > here. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 8/4/20 7:00 PM, Thomas Huth wrote: > In case we ever want to compile this for Windows, we need the $(EXESUF) > here. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 2806e062d0..e2532e12e2 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -687,7 +687,7 @@ check-report.tap: $(patsubst %,check-report-qtest-%.tap, $(QTEST_TARGETS)) check > # generic Makefile expansions. Once we are cleanly passing all > # the tests we can simplify the make syntax. > > -FP_TEST_BIN=$(BUILD_DIR)/tests/fp/fp-test > +FP_TEST_BIN=$(BUILD_DIR)/tests/fp/fp-test$(EXESUF) > > # the build dir is created by configure > $(FP_TEST_BIN): config-host.h $(test-util-obj-y) > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
On 04/08/20 19:00, Thomas Huth wrote: > In case we ever want to compile this for Windows, we need the $(EXESUF) > here. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 2806e062d0..e2532e12e2 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -687,7 +687,7 @@ check-report.tap: $(patsubst %,check-report-qtest-%.tap, $(QTEST_TARGETS)) check > # generic Makefile expansions. Once we are cleanly passing all > # the tests we can simplify the make syntax. > > -FP_TEST_BIN=$(BUILD_DIR)/tests/fp/fp-test > +FP_TEST_BIN=$(BUILD_DIR)/tests/fp/fp-test$(EXESUF) > > # the build dir is created by configure > $(FP_TEST_BIN): config-host.h $(test-util-obj-y) > When converting it to Meson, fptest broke badly for me on Windows due to namespace pollution (Windows headers use FLOAT128 and LITTLEENDIAN symbols). I would just leave out this patch since check-softfloat has been converted to meson already. Paolo
diff --git a/tests/Makefile.include b/tests/Makefile.include index 2806e062d0..e2532e12e2 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -687,7 +687,7 @@ check-report.tap: $(patsubst %,check-report-qtest-%.tap, $(QTEST_TARGETS)) check # generic Makefile expansions. Once we are cleanly passing all # the tests we can simplify the make syntax. -FP_TEST_BIN=$(BUILD_DIR)/tests/fp/fp-test +FP_TEST_BIN=$(BUILD_DIR)/tests/fp/fp-test$(EXESUF) # the build dir is created by configure $(FP_TEST_BIN): config-host.h $(test-util-obj-y)
In case we ever want to compile this for Windows, we need the $(EXESUF) here. Signed-off-by: Thomas Huth <thuth@redhat.com> --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)