From patchwork Tue Aug 4 14:00:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Helge Deller X-Patchwork-Id: 1340871 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=cWVXHol1; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BLc072r4Tz9sTC for ; Wed, 5 Aug 2020 00:02:47 +1000 (AEST) Received: from localhost ([::1]:46398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2xWe-0000kj-V6 for incoming@patchwork.ozlabs.org; Tue, 04 Aug 2020 10:02:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2xV6-0000kE-8f for qemu-devel@nongnu.org; Tue, 04 Aug 2020 10:01:08 -0400 Received: from mout.gmx.net ([212.227.15.18]:42905) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2xV4-000383-A4 for qemu-devel@nongnu.org; Tue, 04 Aug 2020 10:01:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1596549659; bh=2t00/wToPXdci/sCMNt4gNmLdt2OOd+Fs0qy1+SNfwk=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=cWVXHol1mx9oz21RpXiTpcVwOsuUpYgjApfP8ti1JDEMclhP3PauaGhfrdKnCbiP4 j7JbbtkP2HEA4DTrZiKEGb3kEuASP+cauyseKcFNV5Q3kye6if9l7ozoCpLEhDKHtQ Vgilmc4aMfvsyT8Yng00lzSGlxErVpo5+kbizFpQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from ls3530.fritz.box ([92.116.144.148]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MN5eR-1kLJra2nhd-00J2xE; Tue, 04 Aug 2020 16:00:59 +0200 From: Helge Deller To: peter.maydell@linaro.org, qemu-devel@nongnu.org Subject: [PATCH v3 5/8] hw/hppa/lasi: Don't abort on invalid IMR value Date: Tue, 4 Aug 2020 16:00:53 +0200 Message-Id: <20200804140056.7690-6-deller@gmx.de> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200804140056.7690-1-deller@gmx.de> References: <20200804140056.7690-1-deller@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:2Rl3PMapyfvrI/et7avVNtw3KKpxJ48Fgn/ai0em8/Jvuf/fH8l SIHWKHAQX+4pnLqt6qtapLU8xfM/mJOY6zBlBQg8+KWN2zmBZ4PXX3okGw38aAESySJ323r 8fQtiaG6yIPH1sMAEIpZ1akZHIxKJe4npag2oeKeoQZpdP2dNYnmTQIVIZokal9seKD6I29 +on5d2vaqN1dmCeyfyauw== X-UI-Out-Filterresults: notjunk:1;V03:K0:pWyls6/Nt1Y=:Pi8aC16AabB1sa91WrLrpf bjjKbkIYhGevGM+sqtPdqM+Un2YVjH+DMlgbMwAbDlFNVutIlCpr6fXsvAZp5oeHMJFyvfC0z G4E6JMj9iPN1YQP8/m2VYCoiYbvi/7w66NJEBuLuh2p/YkRn5xCEiqSkW1sr8wIyosAaSl5TN gEBRpxT7jmIHKzZZP/49JJKog0l8YyeV9EMZDSH46gjAteOYm8wU+DVL4YvLsQpfFtTxv3Ck6 cVugv18Bhr4Dk3BALVqk/lDDgfdoQpFrpCh49Z07ecBhM5q7v8R2ER+vQ6XJxrDXjI1JbsaIy ynyQOhdGyhMxFgWSJiDBKvy2K5Q5S7Wyg1uxSYj2p924FnvV+6W7e8qM9Tao8cogMeJ8iTvQ0 vyB/Q9/iIL6atba0Yd7BU+MT/O7/UrvKuMRGUQx/3AB5Xv59pEvq7CT6OFFX5Qk9qwzcyFJ3C oTTK6gJgPfRlWwHYPaHbcRr7o32r2aTl2HDUjnFB7azYQjDKfw0/FTL0+Rm4/KsT01Ap2hX8t aw0cJdzlTzTYB2aLZpW6TLLfoS5yDeyo1s+wtw6q4UJLjAnP/duwJrg8hu5SZ2UG1X49ayffy zOBwBPFxhzyTr1IehYML+BnehbsJyjOY/FSoyBYAZXUxVUa/PagYLG/Z1Iqh4wixbFvgSzgzS VBEixbsIYV7RkBfvgUurHFOz+cI58QtfcDV2pB5naM2fTDYsOCHdI+XLS+uxym+qovVRIYa3p g0jEu0u18kXrhZ4R71MUxGRNjovj9sDQmVvYaEAHsWVzD55/XP9JBO8t962Mn8PI850IhW/Kh Ye35QptL5ySM4+AonxHa022hepf0U/U23vWFPWd/8geQ9rq3AnOIziftwlaqLsIp9vQxKs21e DmO4lUzccrTSC3KxIbm2gfeHu1cNepJaiUU+U5JquJUeYe8PmWDh0wa2aYR7rDmh85t4dIdTn n4w9kLplX9luQwVP0RgN9UP7lVWrQqqSaFadIo0GufwPe69iI7fiL7gECp9/1vDhhwdQ/h8MB GZFO1jQOt3meM6A9bl85UcAH/bdng2D/Y7N4cmTvG5p7wWnZoO6PzXA1DN9R+LriUNIFre/8f PJh/REwejD1Lfh0n1PB42xsdnYK5efokSFk48z9fTig5brEtVQMBYuQjQ8o8poSSlscRFE6FY QfNeYQK/T7HAlgXD7Zy0GaStJ/Quu6j4QwYkfn0Q5q+eddl7iNhb/pGpV2MIXqg76bEZiV5hB sI6sCjMlwLSb8tnaB Received-SPF: pass client-ip=212.227.15.18; envelope-from=deller@gmx.de; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/04 09:08:36 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Helge Deller , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" NetBSD initializes the LASI IMR value with 0xffffffff to disable all LASI interrupts. This triggered an assert() and stopped the emulation. By replacing the check with a warning in the guest log we now allow NetBSD to boot again. Signed-off-by: Helge Deller --- hw/hppa/lasi.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.21.3 diff --git a/hw/hppa/lasi.c b/hw/hppa/lasi.c index ffcbb988b8..7b4a168468 100644 --- a/hw/hppa/lasi.c +++ b/hw/hppa/lasi.c @@ -11,6 +11,7 @@ #include "qemu/osdep.h" #include "qemu/units.h" +#include "qemu/log.h" #include "qapi/error.h" #include "cpu.h" #include "trace.h" @@ -170,8 +171,10 @@ static MemTxResult lasi_chip_write_with_attrs(void *opaque, hwaddr addr, /* read-only. */ break; case LASI_IMR: - s->imr = val; /* 0x20 ?? */ - assert((val & LASI_IRQ_BITS) == val); + s->imr = val; + if (((val & LASI_IRQ_BITS) != val) && (val != 0xffffffff)) + qemu_log_mask(LOG_GUEST_ERROR, + "LASI: tried to set invalid %lx IMR value.\n", val); break; case LASI_IPR: /* Any write to IPR clears the register. */