Message ID | 20200803105647.22223-4-f4bug@amsat.org |
---|---|
State | New |
Headers | show |
Series | hw/arm/xilinx_zynq: Call qdev_connect_clock_in() before DeviceRealize | expand |
On Mon, Aug 3, 2020 at 3:57 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > We want to assert the device is not realized. To avoid overloading > this header including "hw/qdev-core.h", uninline the function first. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > include/hw/qdev-clock.h | 6 +----- > hw/core/qdev-clock.c | 5 +++++ > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/include/hw/qdev-clock.h b/include/hw/qdev-clock.h > index a340f65ff9..a897f7c9d0 100644 > --- a/include/hw/qdev-clock.h > +++ b/include/hw/qdev-clock.h > @@ -71,11 +71,7 @@ Clock *qdev_get_clock_out(DeviceState *dev, const char *name); > * Set the source clock of input clock @name of device @dev to @source. > * @source period update will be propagated to @name clock. > */ > -static inline void qdev_connect_clock_in(DeviceState *dev, const char *name, > - Clock *source) > -{ > - clock_set_source(qdev_get_clock_in(dev, name), source); > -} > +void qdev_connect_clock_in(DeviceState *dev, const char *name, Clock *source); > > /** > * qdev_alias_clock: > diff --git a/hw/core/qdev-clock.c b/hw/core/qdev-clock.c > index 5cc1e82e51..f139b68b88 100644 > --- a/hw/core/qdev-clock.c > +++ b/hw/core/qdev-clock.c > @@ -183,3 +183,8 @@ Clock *qdev_alias_clock(DeviceState *dev, const char *name, > > return ncl->clock; > } > + > +void qdev_connect_clock_in(DeviceState *dev, const char *name, Clock *source) > +{ > + clock_set_source(qdev_get_clock_in(dev, name), source); > +} > -- > 2.21.3 > >
diff --git a/include/hw/qdev-clock.h b/include/hw/qdev-clock.h index a340f65ff9..a897f7c9d0 100644 --- a/include/hw/qdev-clock.h +++ b/include/hw/qdev-clock.h @@ -71,11 +71,7 @@ Clock *qdev_get_clock_out(DeviceState *dev, const char *name); * Set the source clock of input clock @name of device @dev to @source. * @source period update will be propagated to @name clock. */ -static inline void qdev_connect_clock_in(DeviceState *dev, const char *name, - Clock *source) -{ - clock_set_source(qdev_get_clock_in(dev, name), source); -} +void qdev_connect_clock_in(DeviceState *dev, const char *name, Clock *source); /** * qdev_alias_clock: diff --git a/hw/core/qdev-clock.c b/hw/core/qdev-clock.c index 5cc1e82e51..f139b68b88 100644 --- a/hw/core/qdev-clock.c +++ b/hw/core/qdev-clock.c @@ -183,3 +183,8 @@ Clock *qdev_alias_clock(DeviceState *dev, const char *name, return ncl->clock; } + +void qdev_connect_clock_in(DeviceState *dev, const char *name, Clock *source) +{ + clock_set_source(qdev_get_clock_in(dev, name), source); +}
We want to assert the device is not realized. To avoid overloading this header including "hw/qdev-core.h", uninline the function first. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- include/hw/qdev-clock.h | 6 +----- hw/core/qdev-clock.c | 5 +++++ 2 files changed, 6 insertions(+), 5 deletions(-)