| Message ID | 20200722072613.10390-1-kraxel@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | ehci: drop pointless warn_report for guest bugs. | expand |
On 7/22/20 9:26 AM, Gerd Hoffmann wrote: > We have a tracepoint at the same place which can be enabled if needed. > > Buglink: https://bugzilla.redhat.com//show_bug.cgi?id=1859236 > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > hw/usb/hcd-ehci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c > index 1495e8f7fab1..4266765f8682 100644 > --- a/hw/usb/hcd-ehci.c > +++ b/hw/usb/hcd-ehci.c > @@ -352,7 +352,6 @@ static void ehci_trace_sitd(EHCIState *s, hwaddr addr, > static void ehci_trace_guest_bug(EHCIState *s, const char *message) > { > trace_usb_ehci_guest_bug(message); > - warn_report("%s", message); > } > > static inline bool ehci_enabled(EHCIState *s) > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 1495e8f7fab1..4266765f8682 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -352,7 +352,6 @@ static void ehci_trace_sitd(EHCIState *s, hwaddr addr, static void ehci_trace_guest_bug(EHCIState *s, const char *message) { trace_usb_ehci_guest_bug(message); - warn_report("%s", message); } static inline bool ehci_enabled(EHCIState *s)
We have a tracepoint at the same place which can be enabled if needed. Buglink: https://bugzilla.redhat.com//show_bug.cgi?id=1859236 Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- hw/usb/hcd-ehci.c | 1 - 1 file changed, 1 deletion(-)