Message ID | 20200722035016.469075-8-bauerman@linux.ibm.com |
---|---|
State | New |
Headers | show |
Series | Generalize start-powered-off property from ARM | expand |
On 7/22/20 5:50 AM, Thiago Jung Bauermann wrote: > Remove setting of cs->halted from cpu_devinit(), which seems out of place > when compared to similar code in other architectures (e.g., ppce500_init() > in hw/ppc/e500.c). > > Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com> > --- > hw/sparc/sun4m.c | 1 - > 1 file changed, 1 deletion(-) > > NB: I was only able to test that this patch builds. I wasn't able to > run it. > > diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c > index 766e79bb5e..7b3042a801 100644 > --- a/hw/sparc/sun4m.c > +++ b/hw/sparc/sun4m.c > @@ -831,7 +831,6 @@ static void cpu_devinit(const char *cpu_type, unsigned int id, > } else { > qemu_register_reset(secondary_cpu_reset, cpu); > cs = CPU(cpu); > - cs->halted = 1; > object_property_set_bool(OBJECT(cs), "start-powered-off", true, > &error_abort); > } > Why not squash with previous patch?
Philippe Mathieu-Daudé <philmd@redhat.com> writes: > On 7/22/20 5:50 AM, Thiago Jung Bauermann wrote: >> Remove setting of cs->halted from cpu_devinit(), which seems out of place >> when compared to similar code in other architectures (e.g., ppce500_init() >> in hw/ppc/e500.c). >> >> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com> >> --- >> hw/sparc/sun4m.c | 1 - >> 1 file changed, 1 deletion(-) >> >> NB: I was only able to test that this patch builds. I wasn't able to >> run it. >> >> diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c >> index 766e79bb5e..7b3042a801 100644 >> --- a/hw/sparc/sun4m.c >> +++ b/hw/sparc/sun4m.c >> @@ -831,7 +831,6 @@ static void cpu_devinit(const char *cpu_type, unsigned int id, >> } else { >> qemu_register_reset(secondary_cpu_reset, cpu); >> cs = CPU(cpu); >> - cs->halted = 1; >> object_property_set_bool(OBJECT(cs), "start-powered-off", true, >> &error_abort); >> } >> > > Why not squash with previous patch? I wasn't sure about this change, and it's also not strictly necessary for this patch set so I wanted to make it easy for maintainers to not apply it. I squashed it for v3. -- Thiago Jung Bauermann IBM Linux Technology Center
diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c index 766e79bb5e..7b3042a801 100644 --- a/hw/sparc/sun4m.c +++ b/hw/sparc/sun4m.c @@ -831,7 +831,6 @@ static void cpu_devinit(const char *cpu_type, unsigned int id, } else { qemu_register_reset(secondary_cpu_reset, cpu); cs = CPU(cpu); - cs->halted = 1; object_property_set_bool(OBJECT(cs), "start-powered-off", true, &error_abort); }
Remove setting of cs->halted from cpu_devinit(), which seems out of place when compared to similar code in other architectures (e.g., ppce500_init() in hw/ppc/e500.c). Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com> --- hw/sparc/sun4m.c | 1 - 1 file changed, 1 deletion(-) NB: I was only able to test that this patch builds. I wasn't able to run it.