diff mbox series

qtest: bios-tables-test: fix a memory leak

Message ID 20200714153536.66060-1-liq3ea@163.com
State New
Headers show
Series qtest: bios-tables-test: fix a memory leak | expand

Commit Message

Li Qiang July 14, 2020, 3:35 p.m. UTC 
Fixes: 5da7c35e25a("bios-tables-test: Add Q35/TPM-TIS test")
Signed-off-by: Li Qiang <liq3ea@163.com>
---
 tests/qtest/bios-tables-test.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Eric Auger July 15, 2020, 9:07 a.m. UTC | #1 
Hi Li,

On 7/14/20 5:35 PM, Li Qiang wrote:
> Fixes: 5da7c35e25a("bios-tables-test: Add Q35/TPM-TIS test")
> Signed-off-by: Li Qiang <liq3ea@163.com>
> ---
>  tests/qtest/bios-tables-test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index c315156858..d49b3988ec 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -924,6 +924,7 @@ static void test_acpi_tcg_tpm(const char *machine, const char *tpm_if,
>      g_free(variant);
>      g_free(tmp_path);
>      g_free(tmp_dir_name);
> +    g_free(args);
>      free_test_data(&data);
>  #else
>      g_test_skip("TPM disabled");
> 
Reviewed-by: Eric Auger <eric.auger@redhat.com>

Thanks!

Eric
Igor Mammedov July 15, 2020, 1:47 p.m. UTC | #2 
On Tue, 14 Jul 2020 08:35:36 -0700
Li Qiang <liq3ea@163.com> wrote:

> Fixes: 5da7c35e25a("bios-tables-test: Add Q35/TPM-TIS test")
> Signed-off-by: Li Qiang <liq3ea@163.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  tests/qtest/bios-tables-test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index c315156858..d49b3988ec 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -924,6 +924,7 @@ static void test_acpi_tcg_tpm(const char *machine, const char *tpm_if,
>      g_free(variant);
>      g_free(tmp_path);
>      g_free(tmp_dir_name);
> +    g_free(args);
>      free_test_data(&data);
>  #else
>      g_test_skip("TPM disabled");
diff mbox series

Patch

diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index c315156858..d49b3988ec 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -924,6 +924,7 @@  static void test_acpi_tcg_tpm(const char *machine, const char *tpm_if,
     g_free(variant);
     g_free(tmp_path);
     g_free(tmp_dir_name);
+    g_free(args);
     free_test_data(&data);
 #else
     g_test_skip("TPM disabled");