| Message ID | 20200713085528.5608-1-lekiravi@yandex-team.ru |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] configure: fix incorrect have_keyring check | expand |
Hi Alexey, On 7/13/20 10:55 AM, Alexey Kirillov wrote: > In some shells, we can't use == sign (as example, in dash). > > Signed-off-by: Alexey Kirillov <lekiravi@yandex-team.ru> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 31e2ddbf28..f65914f98f 100755 > --- a/configure > +++ b/configure > @@ -6486,7 +6486,7 @@ EOF > fi > if test "$secret_keyring" != "no" > then > - if test "$have_keyring" == "yes" > + if test "$have_keyring" = "yes" > then > secret_keyring=yes > else > Thanks, but David already sent the same fix: https://www.mail-archive.com/qemu-devel@nongnu.org/msg713765.html It should be merged in today or tomorrow via Alex Bennée tree.
diff --git a/configure b/configure index 31e2ddbf28..f65914f98f 100755 --- a/configure +++ b/configure @@ -6486,7 +6486,7 @@ EOF fi if test "$secret_keyring" != "no" then - if test "$have_keyring" == "yes" + if test "$have_keyring" = "yes" then secret_keyring=yes else
In some shells, we can't use == sign (as example, in dash). Signed-off-by: Alexey Kirillov <lekiravi@yandex-team.ru> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)