| Message ID | 20200710215718.13034-2-jsnow@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | MAINTAINERS: Add Python library stanza | expand |
On 7/10/20 11:57 PM, John Snow wrote: > I'm proposing that I split the actual Python library off from the other > miscellaneous python scripts we have and declare it maintained. Add > myself as a maintainer of this folder, along with Cleber. > > Signed-off-by: John Snow <jsnow@redhat.com> > --- > MAINTAINERS | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 6aa54f7f8f..fe1dcd5a76 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2280,11 +2280,18 @@ S: Maintained > F: include/sysemu/cryptodev*.h > F: backends/cryptodev*.c > > +Python library > +M: John Snow <jsnow@redhat.com> > +M: Cleber Rosa <crosa@redhat.com> > +R: Eduardo Habkost <ehabkost@redhat.com> > +S: Maintained > +F: python/* > +T: git https://gitlab.com/jsnow/qemu.git python > + > Python scripts > M: Eduardo Habkost <ehabkost@redhat.com> > M: Cleber Rosa <crosa@redhat.com> > S: Odd fixes > -F: python/qemu/*py > F: scripts/*.py > F: tests/*.py > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
John Snow <jsnow@redhat.com> writes: > I'm proposing that I split the actual Python library off from the other > miscellaneous python scripts we have and declare it maintained. Add > myself as a maintainer of this folder, along with Cleber. > > Signed-off-by: John Snow <jsnow@redhat.com> > --- > MAINTAINERS | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 6aa54f7f8f..fe1dcd5a76 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2280,11 +2280,18 @@ S: Maintained > F: include/sysemu/cryptodev*.h > F: backends/cryptodev*.c > > +Python library > +M: John Snow <jsnow@redhat.com> > +M: Cleber Rosa <crosa@redhat.com> > +R: Eduardo Habkost <ehabkost@redhat.com> > +S: Maintained > +F: python/* I don't think that's equivalent to what you drop bellow: F: drivers/net/ all files in and below drivers/net F: drivers/net/* all files in drivers/net, but not below So I think you should drop the * > +T: git https://gitlab.com/jsnow/qemu.git python > + > Python scripts > M: Eduardo Habkost <ehabkost@redhat.com> > M: Cleber Rosa <crosa@redhat.com> > S: Odd fixes > -F: python/qemu/*py > F: scripts/*.py > F: tests/*.py Otherwise: Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
On 7/13/20 9:35 AM, Alex Bennée wrote: > > John Snow <jsnow@redhat.com> writes: > >> I'm proposing that I split the actual Python library off from the other >> miscellaneous python scripts we have and declare it maintained. Add >> myself as a maintainer of this folder, along with Cleber. >> >> Signed-off-by: John Snow <jsnow@redhat.com> >> --- >> MAINTAINERS | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 6aa54f7f8f..fe1dcd5a76 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -2280,11 +2280,18 @@ S: Maintained >> F: include/sysemu/cryptodev*.h >> F: backends/cryptodev*.c >> >> +Python library >> +M: John Snow <jsnow@redhat.com> >> +M: Cleber Rosa <crosa@redhat.com> >> +R: Eduardo Habkost <ehabkost@redhat.com> >> +S: Maintained >> +F: python/* > > I don't think that's equivalent to what you drop bellow: > > F: drivers/net/ all files in and below drivers/net > F: drivers/net/* all files in drivers/net, but not below > > So I think you should drop the * > I didn't realize that, thanks for correcting it. >> +T: git https://gitlab.com/jsnow/qemu.git python >> + >> Python scripts >> M: Eduardo Habkost <ehabkost@redhat.com> >> M: Cleber Rosa <crosa@redhat.com> >> S: Odd fixes >> -F: python/qemu/*py >> F: scripts/*.py >> F: tests/*.py > > Otherwise: > > Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > I swear I talked to Cleber and Eduardo before sending this, we'll wait for them to say hi :)
On 7/13/20 3:59 PM, John Snow wrote: > On 7/13/20 9:35 AM, Alex Bennée wrote: >> >> John Snow <jsnow@redhat.com> writes: >> >>> I'm proposing that I split the actual Python library off from the other >>> miscellaneous python scripts we have and declare it maintained. Add >>> myself as a maintainer of this folder, along with Cleber. >>> >>> Signed-off-by: John Snow <jsnow@redhat.com> >>> --- >>> MAINTAINERS | 9 ++++++++- >>> 1 file changed, 8 insertions(+), 1 deletion(-) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 6aa54f7f8f..fe1dcd5a76 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -2280,11 +2280,18 @@ S: Maintained >>> F: include/sysemu/cryptodev*.h >>> F: backends/cryptodev*.c >>> >>> +Python library >>> +M: John Snow <jsnow@redhat.com> >>> +M: Cleber Rosa <crosa@redhat.com> >>> +R: Eduardo Habkost <ehabkost@redhat.com> >>> +S: Maintained >>> +F: python/* >> >> I don't think that's equivalent to what you drop bellow: >> >> F: drivers/net/ all files in and below drivers/net >> F: drivers/net/* all files in drivers/net, but not below >> >> So I think you should drop the * I can fix that if I do the next python pull req. >> > > I didn't realize that, thanks for correcting it. > >>> +T: git https://gitlab.com/jsnow/qemu.git python >>> + >>> Python scripts >>> M: Eduardo Habkost <ehabkost@redhat.com> >>> M: Cleber Rosa <crosa@redhat.com> >>> S: Odd fixes >>> -F: python/qemu/*py >>> F: scripts/*.py >>> F: tests/*.py >> >> Otherwise: >> >> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> >> > > I swear I talked to Cleber and Eduardo before sending this, we'll wait > for them to say hi :) >
On Mon, Jul 13, 2020 at 09:59:49AM -0400, John Snow wrote: > > > On 7/13/20 9:35 AM, Alex Bennée wrote: > > > > John Snow <jsnow@redhat.com> writes: > > > >> I'm proposing that I split the actual Python library off from the other > >> miscellaneous python scripts we have and declare it maintained. Add > >> myself as a maintainer of this folder, along with Cleber. > >> > >> Signed-off-by: John Snow <jsnow@redhat.com> > >> --- > >> MAINTAINERS | 9 ++++++++- > >> 1 file changed, 8 insertions(+), 1 deletion(-) > >> > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index 6aa54f7f8f..fe1dcd5a76 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -2280,11 +2280,18 @@ S: Maintained > >> F: include/sysemu/cryptodev*.h > >> F: backends/cryptodev*.c > >> > >> +Python library > >> +M: John Snow <jsnow@redhat.com> > >> +M: Cleber Rosa <crosa@redhat.com> > >> +R: Eduardo Habkost <ehabkost@redhat.com> > >> +S: Maintained > >> +F: python/* > > > > I don't think that's equivalent to what you drop bellow: > > > > F: drivers/net/ all files in and below drivers/net > > F: drivers/net/* all files in drivers/net, but not below > > > > So I think you should drop the * > > > > I didn't realize that, thanks for correcting it. > > >> +T: git https://gitlab.com/jsnow/qemu.git python > >> + > >> Python scripts > >> M: Eduardo Habkost <ehabkost@redhat.com> > >> M: Cleber Rosa <crosa@redhat.com> > >> S: Odd fixes > >> -F: python/qemu/*py > >> F: scripts/*.py > >> F: tests/*.py > > > > Otherwise: > > > > Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > > > > I swear I talked to Cleber and Eduardo before sending this, we'll wait > for them to say hi :) You did! And I'm happy to see you are volunteering to replace me as maintainer on many of those files. Acked-by: Eduardo Habkost <ehabkost@redhat.com>
On 7/13/20 9:35 AM, Alex Bennée wrote: > > John Snow <jsnow@redhat.com> writes: > >> I'm proposing that I split the actual Python library off from the other >> miscellaneous python scripts we have and declare it maintained. Add >> myself as a maintainer of this folder, along with Cleber. >> >> Signed-off-by: John Snow <jsnow@redhat.com> >> --- >> MAINTAINERS | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 6aa54f7f8f..fe1dcd5a76 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -2280,11 +2280,18 @@ S: Maintained >> F: include/sysemu/cryptodev*.h >> F: backends/cryptodev*.c >> >> +Python library >> +M: John Snow <jsnow@redhat.com> >> +M: Cleber Rosa <crosa@redhat.com> >> +R: Eduardo Habkost <ehabkost@redhat.com> >> +S: Maintained >> +F: python/* > > I don't think that's equivalent to what you drop bellow: > > F: drivers/net/ all files in and below drivers/net > F: drivers/net/* all files in drivers/net, but not below > > So I think you should drop the * > >> +T: git https://gitlab.com/jsnow/qemu.git python >> + >> Python scripts >> M: Eduardo Habkost <ehabkost@redhat.com> >> M: Cleber Rosa <crosa@redhat.com> >> S: Odd fixes >> -F: python/qemu/*py >> F: scripts/*.py >> F: tests/*.py > > Otherwise: > > Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > ACK on the edit, I think otherwise I'm still technically waiting for Cleber to approve this before I would ask for someone to stage it. --js
On Fri, Jul 10, 2020 at 05:57:18PM -0400, John Snow wrote: > I'm proposing that I split the actual Python library off from the other > miscellaneous python scripts we have and declare it maintained. Add > myself as a maintainer of this folder, along with Cleber. > > Signed-off-by: John Snow <jsnow@redhat.com> > --- > MAINTAINERS | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 6aa54f7f8f..fe1dcd5a76 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2280,11 +2280,18 @@ S: Maintained > F: include/sysemu/cryptodev*.h > F: backends/cryptodev*.c > > +Python library > +M: John Snow <jsnow@redhat.com> > +M: Cleber Rosa <crosa@redhat.com> > +R: Eduardo Habkost <ehabkost@redhat.com> > +S: Maintained > +F: python/* > +T: git https://gitlab.com/jsnow/qemu.git python > + Thanks for this, and for that will come next! :) Ack-by: Cleber Rosa <crosa@redhat.com>
diff --git a/MAINTAINERS b/MAINTAINERS index 6aa54f7f8f..fe1dcd5a76 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2280,11 +2280,18 @@ S: Maintained F: include/sysemu/cryptodev*.h F: backends/cryptodev*.c +Python library +M: John Snow <jsnow@redhat.com> +M: Cleber Rosa <crosa@redhat.com> +R: Eduardo Habkost <ehabkost@redhat.com> +S: Maintained +F: python/* +T: git https://gitlab.com/jsnow/qemu.git python + Python scripts M: Eduardo Habkost <ehabkost@redhat.com> M: Cleber Rosa <crosa@redhat.com> S: Odd fixes -F: python/qemu/*py F: scripts/*.py F: tests/*.py
I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber. Signed-off-by: John Snow <jsnow@redhat.com> --- MAINTAINERS | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)