Message ID | 20200703165405.17672-1-peter.maydell@linaro.org |
---|---|
State | New |
Headers | show |
Patchew URL: https://patchew.org/QEMU/20200703165405.17672-1-peter.maydell@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/34] target-arm queue Type: series Message-id: 20200703165405.17672-1-peter.maydell@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20200703165405.17672-1-peter.maydell@linaro.org -> patchew/20200703165405.17672-1-peter.maydell@linaro.org Switched to a new branch 'test' d638580 Deprecate TileGX port 1e2e778 Replace uses of FROM_SSI_SLAVE() macro with QOM casts 92a5f92 hw/arm/spitz: Provide usual QOM macros for corgi-ssp and spitz-lcdtg d578f7a hw/arm/pxa2xx_pic: Use LOG_GUEST_ERROR for bad guest register accesses 8ca1ff9 hw/arm/spitz: Use LOG_GUEST_ERROR for bad guest register accesses bdc8b3f hw/gpio/zaurus.c: Use LOG_GUEST_ERROR for bad guest register accesses a7f0ce8 hw/arm/spitz: Encapsulate misc GPIO handling in a device 2d29801 hw/misc/max111x: Create header file for documentation, TYPE_ macros 1b20083 hw/misc/max111x: Use GPIO lines rather than max111x_set_input() 9ddef16 hw/arm/spitz: Use max111x properties to set initial values 208445b ssi: Add ssi_realize_and_unref() 7017444 hw/misc/max111x: Don't use vmstate_register() 57e564b hw/misc/max111x: provide QOM properties for setting initial values 4902bce hw/arm/spitz: Implement inbound GPIO lines for bit5 and power signals d769576 hw/arm/spitz: Keep pointers to scp0, scp1 in SpitzMachineState 9970786 hw/arm/spitz: Keep pointers to MPU and SSI devices in SpitzMachineState 8943225 hw/arm/spitz: Create SpitzMachineClass abstract base class 2d5eafe hw/arm/spitz: Detabify 1f8dfdb hw/display/bcm2835_fb.c: Initialize all fields of struct 20ee56a target/arm: Fix temp double-free in sve ldr/str 705ce73 tests/acpi: virt: update golden masters for DSDT c3b5af7 hw/arm/virt-acpi-build: Only expose flash on older machine types e26cb37 tests/acpi: virt: allow DSDT acpi table changes c824523 tests/acpi: remove stale allowed tables 4bcd8be target/arm: kvm: Handle misconfigured dabt injection 4dba079 target/arm: kvm: Handle DABT with no valid ISS 71f7055 hw/arm/virt: Let the virtio-iommu bypass MSIs b692f4b virtio-iommu-pci: Add array of Interval properties bf5c2b0 virtio-iommu: Handle reserved regions in the translation process da96f35 virtio-iommu: Implement RESV_MEM probe request b518252 qdev: Introduce DEFINE_PROP_RESERVED_REGION 88ac8a1 Select MDIO device 2 and 1 as PHY devices for i.MX6UL EVK board. ab25de9 Add the ability to select a different PHY for each i.MX6UL FEC interface 0e700cc Add a phy-num property to the i.MX FEC emulator === OUTPUT BEGIN === 1/34 Checking commit 0e700cc2f90d (Add a phy-num property to the i.MX FEC emulator) 2/34 Checking commit ab25de9b1194 (Add the ability to select a different PHY for each i.MX6UL FEC interface) 3/34 Checking commit 88ac8a1e6c55 (Select MDIO device 2 and 1 as PHY devices for i.MX6UL EVK board.) 4/34 Checking commit b518252f4b6a (qdev: Introduce DEFINE_PROP_RESERVED_REGION) 5/34 Checking commit da96f35271a3 (virtio-iommu: Implement RESV_MEM probe request) 6/34 Checking commit bf5c2b0b1ae2 (virtio-iommu: Handle reserved regions in the translation process) 7/34 Checking commit b692f4b0e005 (virtio-iommu-pci: Add array of Interval properties) 8/34 Checking commit 71f7055c32e1 (hw/arm/virt: Let the virtio-iommu bypass MSIs) 9/34 Checking commit 4dba079f1e38 (target/arm: kvm: Handle DABT with no valid ISS) 10/34 Checking commit 4bcd8bef2ef5 (target/arm: kvm: Handle misconfigured dabt injection) 11/34 Checking commit c824523e1b1f (tests/acpi: remove stale allowed tables) 12/34 Checking commit e26cb3737b8e (tests/acpi: virt: allow DSDT acpi table changes) 13/34 Checking commit c3b5af781c16 (hw/arm/virt-acpi-build: Only expose flash on older machine types) 14/34 Checking commit 705ce7328c86 (tests/acpi: virt: update golden masters for DSDT) 15/34 Checking commit 20ee56a97cef (target/arm: Fix temp double-free in sve ldr/str) 16/34 Checking commit 1f8dfdbe0e2f (hw/display/bcm2835_fb.c: Initialize all fields of struct) 17/34 Checking commit 2d5eafee3dfb (hw/arm/spitz: Detabify) ERROR: space prohibited before that '++' (ctx:WxB) #113: FILE: hw/arm/spitz.c:303: +#define QUEUE_KEY(c) s->fifo[(s->fifopos + s->fifolen ++) & 0xf] = c ^ ERROR: Macros with complex values should be enclosed in parenthesis #113: FILE: hw/arm/spitz.c:303: +#define QUEUE_KEY(c) s->fifo[(s->fifopos + s->fifolen ++) & 0xf] = c total: 2 errors, 0 warnings, 259 lines checked Patch 17/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/34 Checking commit 89432250560f (hw/arm/spitz: Create SpitzMachineClass abstract base class) 19/34 Checking commit 9970786d97e1 (hw/arm/spitz: Keep pointers to MPU and SSI devices in SpitzMachineState) 20/34 Checking commit d769576c9302 (hw/arm/spitz: Keep pointers to scp0, scp1 in SpitzMachineState) 21/34 Checking commit 4902bce57643 (hw/arm/spitz: Implement inbound GPIO lines for bit5 and power signals) WARNING: line over 80 characters #96: FILE: hw/arm/spitz.c:859: + qdev_get_gpio_in_named(sms->lcdtg, "bl_power", 0)); total: 0 errors, 1 warnings, 68 lines checked Patch 21/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/34 Checking commit 57e564bca41b (hw/misc/max111x: provide QOM properties for setting initial values) 23/34 Checking commit 701744470cb1 (hw/misc/max111x: Don't use vmstate_register()) 24/34 Checking commit 208445bd32c9 (ssi: Add ssi_realize_and_unref()) 25/34 Checking commit 9ddef165a4eb (hw/arm/spitz: Use max111x properties to set initial values) WARNING: Block comments use a leading /* on a separate line #31: FILE: hw/arm/spitz.c:736: + qdev_prop_set_uint8(sms->max1111, "input1" /* BATT_VOLT */, WARNING: Block comments use a leading /* on a separate line #33: FILE: hw/arm/spitz.c:738: + qdev_prop_set_uint8(sms->max1111, "input2" /* BATT_TEMP */, 0); WARNING: Block comments use a leading /* on a separate line #34: FILE: hw/arm/spitz.c:739: + qdev_prop_set_uint8(sms->max1111, "input3" /* ACIN_VOLT */, total: 0 errors, 3 warnings, 18 lines checked Patch 25/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 26/34 Checking commit 1b20083f7207 (hw/misc/max111x: Use GPIO lines rather than max111x_set_input()) 27/34 Checking commit 2d29801356e9 (hw/misc/max111x: Create header file for documentation, TYPE_ macros) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #96: new file mode 100644 total: 0 errors, 1 warnings, 113 lines checked Patch 27/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 28/34 Checking commit a7f0ce85ac48 (hw/arm/spitz: Encapsulate misc GPIO handling in a device) WARNING: line over 80 characters #186: FILE: hw/arm/spitz.c:893: + qdev_get_gpio_in(sms->max1111, MAX1111_BATT_TEMP)); total: 0 errors, 1 warnings, 185 lines checked Patch 28/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 29/34 Checking commit bdc8b3f67a7c (hw/gpio/zaurus.c: Use LOG_GUEST_ERROR for bad guest register accesses) 30/34 Checking commit 8ca1ff9ccf5b (hw/arm/spitz: Use LOG_GUEST_ERROR for bad guest register accesses) 31/34 Checking commit d578f7a7793b (hw/arm/pxa2xx_pic: Use LOG_GUEST_ERROR for bad guest register accesses) 32/34 Checking commit 92a5f929696f (hw/arm/spitz: Provide usual QOM macros for corgi-ssp and spitz-lcdtg) 33/34 Checking commit 1e2e778ea0bb (Replace uses of FROM_SSI_SLAVE() macro with QOM casts) 34/34 Checking commit d638580b6ac3 (Deprecate TileGX port) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200703165405.17672-1-peter.maydell@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Fri, 3 Jul 2020 at 17:54, Peter Maydell <peter.maydell@linaro.org> wrote: > > I might squeeze in another pullreq before softfreeze, but the > queue was already big enough that I wanted to send this lot out now. > > -- PMM > > The following changes since commit 4abf70a661a5df3886ac9d7c19c3617fa92b922a: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2020-06-24' into staging (2020-07-03 15:34:45 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20200703 > > for you to fetch changes up to 0f10bf84a9d489259a5b11c6aa1b05c1175b76ea: > > Deprecate TileGX port (2020-07-03 16:59:46 +0100) > > ---------------------------------------------------------------- > target-arm queue: > * i.MX6UL EVK board: put PHYs in the correct places > * hw/arm/virt: Let the virtio-iommu bypass MSIs > * target/arm: kvm: Handle DABT with no valid ISS > * hw/arm/virt-acpi-build: Only expose flash on older machine types > * target/arm: Fix temp double-free in sve ldr/str > * hw/display/bcm2835_fb.c: Initialize all fields of struct > * hw/arm/spitz: Code cleanup to fix Coverity-detected memory leak > * Deprecate TileGX port Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1 for any user-visible changes. -- PMM