| Message ID | 20200701093557.130096-1-dgilbert@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | migration: postcopy take proper error return | expand |
* Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote: > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > This function returns a boolean success and we're returning -1; > lets just use the 'out' error path. > > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > Fixes: 58b7c17e226 ("Disable mlock around incoming postcopy") > Buglink: https://bugs.launchpad.net/qemu/+bug/1885720 queued > --- > migration/postcopy-ram.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c > index a36402722b..bef2a3afed 100644 > --- a/migration/postcopy-ram.c > +++ b/migration/postcopy-ram.c > @@ -389,7 +389,7 @@ bool postcopy_ram_supported_by_host(MigrationIncomingState *mis) > */ > if (munlockall()) { > error_report("%s: munlockall: %s", __func__, strerror(errno)); > - return -1; > + goto out; > } > > /* > -- > 2.26.2 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index a36402722b..bef2a3afed 100644 --- a/migration/postcopy-ram.c +++ b/migration/postcopy-ram.c @@ -389,7 +389,7 @@ bool postcopy_ram_supported_by_host(MigrationIncomingState *mis) */ if (munlockall()) { error_report("%s: munlockall: %s", __func__, strerror(errno)); - return -1; + goto out; } /*