diff mbox series

[PULL,07/12] monitor/hmp-cmds: don't silently output when running 'migrate_set_downtime' fails

Message ID 20200617183733.186168-8-dgilbert@redhat.com
State New
Headers show
Series [PULL,01/12] virtiofsd: Whitelist fchmod | expand

Commit Message

Dr. David Alan Gilbert June 17, 2020, 6:37 p.m. UTC
From: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>

Although 'migrate_set_downtime' has been deprecated and replaced
with 'migrate_set_parameter downtime_limit', it has not been
completely eliminated, possibly due to compatibility with older
versions. I think as long as this old parameter is running, we
should report appropriate message when something goes wrong, not
be silent.

(qemu) migrate_set_downtime -1

(qemu) migrate_set_downtime -1
Error: Parameter 'downtime_limit' expects an integer in the range of 0 to 2000 seconds

Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20200603080904.997083-5-maozhongyi@cmss.chinamobile.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
 monitor/hmp-cmds.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff mbox series


diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 2c630ec88d..a704b3469a 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -1189,8 +1189,11 @@  void hmp_migrate_pause(Monitor *mon, const QDict *qdict)
 /* Kept for backwards compatibility */
 void hmp_migrate_set_downtime(Monitor *mon, const QDict *qdict)
+    Error *err = NULL;
     double value = qdict_get_double(qdict, "value");
-    qmp_migrate_set_downtime(value, NULL);
+    qmp_migrate_set_downtime(value, &err);
+    hmp_handle_error(mon, err);
 void hmp_migrate_set_cache_size(Monitor *mon, const QDict *qdict)