Message ID | 20200612141917.9446-1-mst@redhat.com |
---|---|
State | New |
Headers | show |
Patchew URL: https://patchew.org/QEMU/20200612141917.9446-1-mst@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200612141917.9446-1-mst@redhat.com Subject: [PULL v2 00/58] virtio,acpi,pci: features, fixes, cleanups, tests Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 46dd9b7 virtio-pci: fix queue_enable write d9d64b5 pci: Display PCI IRQ pin in "info pci" d784b45 acpi: ged: rename event memory region 31f9185 acpi: fadt: add hw-reduced sleep register support 7ea0b6d acpi: madt: skip pci override on pci-less systems. c105d68 acpi: create acpi-common.c and move madt code e5065df acpi: make build_madt() more generic. 984d983 virtio: add vhost-user-vsock-pci device 9da4528 virtio: add vhost-user-vsock base device 65280b9 vhost-vsock: add vhost-vsock-common abstraction 938682f hw/pci: Fix crash when running QEMU with "-nic model=rocker" dc89e8a libvhost-user: advertise vring features 91ccf2f Lift max ram slots limit in libvhost-user 2d95eb8 Support individual region unmap in libvhost-user 5965847 Support adding individual regions in libvhost-user 4cbf181 Support ram slot configuration in libvhost-user df71a7d Refactor out libvhost-user fault generation logic c26fd6d Lift max memory slots limit imposed by vhost-user 2c027ae Transmit vhost-user memory regions individually 31f458e Add VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS a498834 Add vhost-user helper to get MemoryRegion data 0b879bd Add helper to populate vhost-user message regions aeb2dd3 vhost-user-blk: delay vhost_user_blk_disconnect 2764cfd char-socket: return -1 in case of disconnect during tcp_chr_write 8094f71 hw/pci-host: Use the IEC binary prefix definitions 2182c70 hw/pci/pci_bridge: Use the IEC binary prefix definitions c2a6ce2 hw/pci/pci_bridge: Correct pci_bridge_io memory region size 55e9447 hw/pci-host/prep: Correct RAVEN bus bridge memory region size 9b4b0a1 pci: assert configuration access is within bounds f5161c8 hw/pci/pcie: Move hot plug capability check to pre_plug callback 61e916f MAINTAINERS: Fix the classification of bios-tables-test-allowed-diff.h 8c4d9bc virtio-balloon: Provide an interface for free page reporting 1f62891 virtio-balloon: Implement support for page poison reporting feature a186c69 virtio-balloon: unref the iothread when unrealizing f995a73 virtio-balloon: fix free page hinting check on unrealize 1ae2534 virtio-balloon: fix free page hinting without an iothread 23ca28d bios-tables-test: Generate reference tables for Q35/TPM-TIS 681761b bios-tables-test: Add Q35/TPM-TIS test 55dc15d tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS d156ed4 tests/acpi: Add void tables for Q35/TPM-TIS bios-tables-test 1f7f0ed test/tpm-emu: include sockets and channel headers in tpm-emu header 1d4ccd1 arm/acpi: TPM2 ACPI table support 05d06ef acpi: Move build_tpm2() in the generic part b3d7639 acpi: Convert build_tpm2() to build_append* API c83165b acpi: tpm: Do not build TCPA table for TPM 2 d5513c9 tests/acpi: update DSDT expected files fd8fce1 acpi: move aml builder code for parallel device ef1eb92 acpi: parallel: don't use _STA method 7dd4ccf acpi: move aml builder code for serial device bae880e acpi: serial: don't use _STA method 97466cf acpi: rtc: use a single crs range 74ad15b acpi: move aml builder code for rtc device 7168264 qtest: allow DSDT acpi table changes f0b0e85 tests/acpi: update expected SRAT files cc03da0 hw/acpi/nvdimm: add a helper to augment SRAT generation c864987 diffs-allowed: add the SRAT AML to diffs-allowed 2029ad3 msix: allow qword MSI-X table accesses === OUTPUT BEGIN === 1/57 Checking commit 2029ad30a9a4 (msix: allow qword MSI-X table accesses) 2/57 Checking commit c8649877f7aa (diffs-allowed: add the SRAT AML to diffs-allowed) 3/57 Checking commit cc03da0d8b45 (hw/acpi/nvdimm: add a helper to augment SRAT generation) 4/57 Checking commit f0b0e85de3ba (tests/acpi: update expected SRAT files) ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/data/acpi/virt/SRAT.memhp and tests/qtest/bios-tables-test-allowed-diff.h found ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/data/acpi/virt/SRAT.memhp and tests/qtest/bios-tables-test-allowed-diff.h found total: 2 errors, 0 warnings, 1 lines checked Patch 4/57 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/57 Checking commit 7168264e4915 (qtest: allow DSDT acpi table changes) 6/57 Checking commit 74ad15b54d99 (acpi: move aml builder code for rtc device) 7/57 Checking commit 97466cf0dc03 (acpi: rtc: use a single crs range) 8/57 Checking commit bae880e24d13 (acpi: serial: don't use _STA method) 9/57 Checking commit 7dd4ccf498f4 (acpi: move aml builder code for serial device) 10/57 Checking commit ef1eb9223800 (acpi: parallel: don't use _STA method) 11/57 Checking commit fd8fce18e6ca (acpi: move aml builder code for parallel device) 12/57 Checking commit d5513c9088c2 (tests/acpi: update DSDT expected files) ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.numamem and tests/qtest/bios-tables-test-allowed-diff.h found ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.numamem and tests/qtest/bios-tables-test-allowed-diff.h found total: 2 errors, 0 warnings, 1 lines checked Patch 12/57 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/57 Checking commit c83165bb10ad (acpi: tpm: Do not build TCPA table for TPM 2) 14/57 Checking commit b3d7639d2e86 (acpi: Convert build_tpm2() to build_append* API) 15/57 Checking commit 05d06ef19c95 (acpi: Move build_tpm2() in the generic part) 16/57 Checking commit 1d4ccd16d234 (arm/acpi: TPM2 ACPI table support) 17/57 Checking commit 1f7f0ed6d33b (test/tpm-emu: include sockets and channel headers in tpm-emu header) 18/57 Checking commit d156ed4cd944 (tests/acpi: Add void tables for Q35/TPM-TIS bios-tables-test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/TPM2.tis and tests/qtest/bios-tables-test-allowed-diff.h found ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/TPM2.tis and tests/qtest/bios-tables-test-allowed-diff.h found total: 2 errors, 1 warnings, 3 lines checked Patch 18/57 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/57 Checking commit 55dc15dcfb1d (tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS) 20/57 Checking commit 681761b85456 (bios-tables-test: Add Q35/TPM-TIS test) 21/57 Checking commit 23ca28d8e3b3 (bios-tables-test: Generate reference tables for Q35/TPM-TIS) ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/TPM2.tis and tests/qtest/bios-tables-test-allowed-diff.h found ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/TPM2.tis and tests/qtest/bios-tables-test-allowed-diff.h found total: 2 errors, 0 warnings, 1 lines checked Patch 21/57 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/57 Checking commit 1ae2534a36d5 (virtio-balloon: fix free page hinting without an iothread) 23/57 Checking commit f995a7363337 (virtio-balloon: fix free page hinting check on unrealize) 24/57 Checking commit a186c699a497 (virtio-balloon: unref the iothread when unrealizing) 25/57 Checking commit 1f62891b7c6a (virtio-balloon: Implement support for page poison reporting feature) 26/57 Checking commit 8c4d9bc55dad (virtio-balloon: Provide an interface for free page reporting) 27/57 Checking commit 61e916f89204 (MAINTAINERS: Fix the classification of bios-tables-test-allowed-diff.h) 28/57 Checking commit f5161c839d6c (hw/pci/pcie: Move hot plug capability check to pre_plug callback) 29/57 Checking commit 9b4b0a139048 (pci: assert configuration access is within bounds) 30/57 Checking commit 55e9447df910 (hw/pci-host/prep: Correct RAVEN bus bridge memory region size) 31/57 Checking commit c2a6ce20e2dd (hw/pci/pci_bridge: Correct pci_bridge_io memory region size) 32/57 Checking commit 2182c70bf082 (hw/pci/pci_bridge: Use the IEC binary prefix definitions) 33/57 Checking commit 8094f71e1265 (hw/pci-host: Use the IEC binary prefix definitions) 34/57 Checking commit 2764cfd4e62a (char-socket: return -1 in case of disconnect during tcp_chr_write) 35/57 Checking commit aeb2dd36befe (vhost-user-blk: delay vhost_user_blk_disconnect) 36/57 Checking commit 0b879bda8a53 (Add helper to populate vhost-user message regions) 37/57 Checking commit a498834b4835 (Add vhost-user helper to get MemoryRegion data) 38/57 Checking commit 31f458ed0813 (Add VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS) WARNING: line over 80 characters #132: FILE: hw/virtio/vhost-user.c:1491: + "of %" PRIu64", when the prior validated limit was %d. " total: 0 errors, 1 warnings, 126 lines checked Patch 38/57 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 39/57 Checking commit 2c027ae6b7ae (Transmit vhost-user memory regions individually) WARNING: line over 80 characters #364: FILE: hw/virtio/vhost-user.c:740: + "Got guest physical address %" PRIX64 ", expected " total: 0 errors, 1 warnings, 612 lines checked Patch 39/57 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 40/57 Checking commit c26fd6d84e2c (Lift max memory slots limit imposed by vhost-user) 41/57 Checking commit df71a7db6bfa (Refactor out libvhost-user fault generation logic) 42/57 Checking commit 4cbf1817c52d (Support ram slot configuration in libvhost-user) 43/57 Checking commit 59658470605f (Support adding individual regions in libvhost-user) 44/57 Checking commit 2d95eb8144fd (Support individual region unmap in libvhost-user) 45/57 Checking commit 91ccf2f2a221 (Lift max ram slots limit in libvhost-user) 46/57 Checking commit dc89e8a63a67 (libvhost-user: advertise vring features) 47/57 Checking commit 938682f0d2b0 (hw/pci: Fix crash when running QEMU with "-nic model=rocker") 48/57 Checking commit 65280b94fe71 (vhost-vsock: add vhost-vsock-common abstraction) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #33: new file mode 100644 total: 0 errors, 1 warnings, 746 lines checked Patch 48/57 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 49/57 Checking commit 9da4528c8b05 (virtio: add vhost-user-vsock base device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #46: new file mode 100644 total: 0 errors, 1 warnings, 233 lines checked Patch 49/57 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 50/57 Checking commit 984d98395f14 (virtio: add vhost-user-vsock-pci device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #33: new file mode 100644 total: 0 errors, 1 warnings, 91 lines checked Patch 50/57 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 51/57 Checking commit e5065df5ab2f (acpi: make build_madt() more generic.) 52/57 Checking commit c105d68ebd4d (acpi: create acpi-common.c and move madt code) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #186: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #191: FILE: hw/i386/acpi-common.c:1: +/* Support for generating ACPI tables and passing them to Guests WARNING: Block comments use a leading /* on a separate line #231: FILE: hw/i386/acpi-common.c:41: + /* ACPI spec says that LAPIC entry for non present ERROR: spaces required around that '<<' (ctx:VxV) #305: FILE: hw/i386/acpi-common.c:115: +#define ACPI_BUILD_PCI_IRQS ((1<<5) | (1<<9) | (1<<10) | (1<<11)) ^ ERROR: spaces required around that '<<' (ctx:VxV) #305: FILE: hw/i386/acpi-common.c:115: +#define ACPI_BUILD_PCI_IRQS ((1<<5) | (1<<9) | (1<<10) | (1<<11)) ^ ERROR: spaces required around that '<<' (ctx:VxV) #305: FILE: hw/i386/acpi-common.c:115: +#define ACPI_BUILD_PCI_IRQS ((1<<5) | (1<<9) | (1<<10) | (1<<11)) ^ ERROR: spaces required around that '<<' (ctx:VxV) #305: FILE: hw/i386/acpi-common.c:115: +#define ACPI_BUILD_PCI_IRQS ((1<<5) | (1<<9) | (1<<10) | (1<<11)) ^ total: 4 errors, 3 warnings, 321 lines checked Patch 52/57 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 53/57 Checking commit 7ea0b6d8971c (acpi: madt: skip pci override on pci-less systems.) WARNING: line over 80 characters #65: FILE: hw/i386/acpi-common.c:128: + intsrcovr->flags = cpu_to_le16(0xd); /* active high, level triggered */ total: 0 errors, 1 warnings, 56 lines checked Patch 53/57 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 54/57 Checking commit 31f91858d42e (acpi: fadt: add hw-reduced sleep register support) 55/57 Checking commit d784b4543385 (acpi: ged: rename event memory region) 56/57 Checking commit d9d64b55b779 (pci: Display PCI IRQ pin in "info pci") 57/57 Checking commit 46dd9b7e7605 (virtio-pci: fix queue_enable write) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200612141917.9446-1-mst@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Fri, Jun 12, 2020 at 08:51:46AM -0700, no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20200612141917.9446-1-mst@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Message-id: 20200612141917.9446-1-mst@redhat.com > Subject: [PULL v2 00/58] virtio,acpi,pci: features, fixes, cleanups, tests > Type: series > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > 46dd9b7 virtio-pci: fix queue_enable write > d9d64b5 pci: Display PCI IRQ pin in "info pci" > d784b45 acpi: ged: rename event memory region > 31f9185 acpi: fadt: add hw-reduced sleep register support > 7ea0b6d acpi: madt: skip pci override on pci-less systems. > c105d68 acpi: create acpi-common.c and move madt code > e5065df acpi: make build_madt() more generic. > 984d983 virtio: add vhost-user-vsock-pci device > 9da4528 virtio: add vhost-user-vsock base device > 65280b9 vhost-vsock: add vhost-vsock-common abstraction > 938682f hw/pci: Fix crash when running QEMU with "-nic model=rocker" > dc89e8a libvhost-user: advertise vring features > 91ccf2f Lift max ram slots limit in libvhost-user > 2d95eb8 Support individual region unmap in libvhost-user > 5965847 Support adding individual regions in libvhost-user > 4cbf181 Support ram slot configuration in libvhost-user > df71a7d Refactor out libvhost-user fault generation logic > c26fd6d Lift max memory slots limit imposed by vhost-user > 2c027ae Transmit vhost-user memory regions individually > 31f458e Add VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS > a498834 Add vhost-user helper to get MemoryRegion data > 0b879bd Add helper to populate vhost-user message regions > aeb2dd3 vhost-user-blk: delay vhost_user_blk_disconnect > 2764cfd char-socket: return -1 in case of disconnect during tcp_chr_write > 8094f71 hw/pci-host: Use the IEC binary prefix definitions > 2182c70 hw/pci/pci_bridge: Use the IEC binary prefix definitions > c2a6ce2 hw/pci/pci_bridge: Correct pci_bridge_io memory region size > 55e9447 hw/pci-host/prep: Correct RAVEN bus bridge memory region size > 9b4b0a1 pci: assert configuration access is within bounds > f5161c8 hw/pci/pcie: Move hot plug capability check to pre_plug callback > 61e916f MAINTAINERS: Fix the classification of bios-tables-test-allowed-diff.h > 8c4d9bc virtio-balloon: Provide an interface for free page reporting > 1f62891 virtio-balloon: Implement support for page poison reporting feature > a186c69 virtio-balloon: unref the iothread when unrealizing > f995a73 virtio-balloon: fix free page hinting check on unrealize > 1ae2534 virtio-balloon: fix free page hinting without an iothread > 23ca28d bios-tables-test: Generate reference tables for Q35/TPM-TIS > 681761b bios-tables-test: Add Q35/TPM-TIS test > 55dc15d tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS > d156ed4 tests/acpi: Add void tables for Q35/TPM-TIS bios-tables-test > 1f7f0ed test/tpm-emu: include sockets and channel headers in tpm-emu header > 1d4ccd1 arm/acpi: TPM2 ACPI table support > 05d06ef acpi: Move build_tpm2() in the generic part > b3d7639 acpi: Convert build_tpm2() to build_append* API > c83165b acpi: tpm: Do not build TCPA table for TPM 2 > d5513c9 tests/acpi: update DSDT expected files > fd8fce1 acpi: move aml builder code for parallel device > ef1eb92 acpi: parallel: don't use _STA method > 7dd4ccf acpi: move aml builder code for serial device > bae880e acpi: serial: don't use _STA method > 97466cf acpi: rtc: use a single crs range > 74ad15b acpi: move aml builder code for rtc device > 7168264 qtest: allow DSDT acpi table changes > f0b0e85 tests/acpi: update expected SRAT files > cc03da0 hw/acpi/nvdimm: add a helper to augment SRAT generation > c864987 diffs-allowed: add the SRAT AML to diffs-allowed > 2029ad3 msix: allow qword MSI-X table accesses > > === OUTPUT BEGIN === > 1/57 Checking commit 2029ad30a9a4 (msix: allow qword MSI-X table accesses) > 2/57 Checking commit c8649877f7aa (diffs-allowed: add the SRAT AML to diffs-allowed) > 3/57 Checking commit cc03da0d8b45 (hw/acpi/nvdimm: add a helper to augment SRAT generation) > 4/57 Checking commit f0b0e85de3ba (tests/acpi: update expected SRAT files) > ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/data/acpi/virt/SRAT.memhp and tests/qtest/bios-tables-test-allowed-diff.h found > > ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/data/acpi/virt/SRAT.memhp and tests/qtest/bios-tables-test-allowed-diff.h found The checkpatch fix isn't merged yet...
On Fri, 12 Jun 2020 at 15:51, Michael S. Tsirkin <mst@redhat.com> wrote: > > changes from v1: > - printf format fixed for 32 bit hosts > - a couple of bugfixes added > > The following changes since commit 49ee11555262a256afec592dfed7c5902d5eefd2: > > Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.1-pull-request' into staging (2020-06-08 11:04:57 +0100) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > for you to fetch changes up to 10d35e581901c09ee3817ac7cddd296d05291a9d: > > virtio-pci: fix queue_enable write (2020-06-12 10:17:06 -0400) > > ---------------------------------------------------------------- > virtio,acpi,pci: features, fixes, cleanups, tests > > Max slots negotiation for vhost-user. > Free page reporting for balloon. > Partial TPM2 ACPI support for ARM. > Support for NVDIMMs having their own proximity domains. > New vhost-user-vsock device. > > Fixes, cleanups in ACPI, PCI, virtio. > New tests for TPM ACPI. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1 for any user-visible changes. -- PMM
Hi Michael, + Stefan On 6/12/20 4:51 PM, Michael S. Tsirkin wrote: > changes from v1: > - printf format fixed for 32 bit hosts > - a couple of bugfixes added > > The following changes since commit 49ee11555262a256afec592dfed7c5902d5eefd2: > > Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.1-pull-request' into staging (2020-06-08 11:04:57 +0100) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > for you to fetch changes up to 10d35e581901c09ee3817ac7cddd296d05291a9d: > > virtio-pci: fix queue_enable write (2020-06-12 10:17:06 -0400) > > ---------------------------------------------------------------- > virtio,acpi,pci: features, fixes, cleanups, tests > > Max slots negotiation for vhost-user. > Free page reporting for balloon. > Partial TPM2 ACPI support for ARM. > Support for NVDIMMs having their own proximity domains. > New vhost-user-vsock device. > > Fixes, cleanups in ACPI, PCI, virtio. > New tests for TPM ACPI. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > ---------------------------------------------------------------- > Alexander Duyck (2): > virtio-balloon: Implement support for page poison reporting feature > virtio-balloon: Provide an interface for free page reporting > > David Hildenbrand (3): > virtio-balloon: fix free page hinting without an iothread > virtio-balloon: fix free page hinting check on unrealize > virtio-balloon: unref the iothread when unrealizing > > Dima Stepanov (2): > char-socket: return -1 in case of disconnect during tcp_chr_write > vhost-user-blk: delay vhost_user_blk_disconnect > > Eric Auger (8): > acpi: Convert build_tpm2() to build_append* API > acpi: Move build_tpm2() in the generic part > arm/acpi: TPM2 ACPI table support I just noticed you did not take [PATCH v4 4/5] arm/acpi: Add the TPM2.0 device under the DSDT [PATCH v4 5/5] docs/specs/tpm: ACPI boot now supported for TPM/ARM from [PATCH v4 0/5] vTPM/aarch64 ACPI support. Without 4/5 the TPM does not work with ACPI. With LUKS auto decryption you get: [ 34.098051] dracut-initqueue[1084]: A TPM2 device with the in-kernel resource manager is needed Do you wait for other reviews? Shall I resend those 2 patches? Thanks Eric > test/tpm-emu: include sockets and channel headers in tpm-emu header > tests/acpi: Add void tables for Q35/TPM-TIS bios-tables-test > tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS > bios-tables-test: Add Q35/TPM-TIS test > bios-tables-test: Generate reference tables for Q35/TPM-TIS > > Gerd Hoffmann (12): > qtest: allow DSDT acpi table changes > acpi: move aml builder code for rtc device > acpi: rtc: use a single crs range > acpi: serial: don't use _STA method > acpi: move aml builder code for serial device > acpi: parallel: don't use _STA method > acpi: move aml builder code for parallel device > acpi: make build_madt() more generic. > acpi: create acpi-common.c and move madt code > acpi: madt: skip pci override on pci-less systems. > acpi: fadt: add hw-reduced sleep register support > acpi: ged: rename event memory region > > Jason Wang (1): > virtio-pci: fix queue_enable write > > Julia Suvorova (1): > hw/pci/pcie: Move hot plug capability check to pre_plug callback > > Michael S. Tsirkin (2): > msix: allow qword MSI-X table accesses > tests/acpi: update DSDT expected files > > Peter Xu (1): > pci: Display PCI IRQ pin in "info pci" > > Philippe Mathieu-Daudé (4): > hw/pci-host/prep: Correct RAVEN bus bridge memory region size > hw/pci/pci_bridge: Correct pci_bridge_io memory region size > hw/pci/pci_bridge: Use the IEC binary prefix definitions > hw/pci-host: Use the IEC binary prefix definitions > > Prasad J Pandit (1): > pci: assert configuration access is within bounds > > Raphael Norwitz (11): > Add helper to populate vhost-user message regions > Add vhost-user helper to get MemoryRegion data > Add VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS > Transmit vhost-user memory regions individually > Lift max memory slots limit imposed by vhost-user > Refactor out libvhost-user fault generation logic > Support ram slot configuration in libvhost-user > Support adding individual regions in libvhost-user > Support individual region unmap in libvhost-user > Lift max ram slots limit in libvhost-user > Fix parameter type in vhost migration log path > > Stefan Berger (1): > acpi: tpm: Do not build TCPA table for TPM 2 > > Stefan Hajnoczi (1): > libvhost-user: advertise vring features > > Stefano Garzarella (3): > vhost-vsock: add vhost-vsock-common abstraction > virtio: add vhost-user-vsock base device > virtio: add vhost-user-vsock-pci device > > Thomas Huth (2): > MAINTAINERS: Fix the classification of bios-tables-test-allowed-diff.h > hw/pci: Fix crash when running QEMU with "-nic model=rocker" > > Vishal Verma (3): > diffs-allowed: add the SRAT AML to diffs-allowed > hw/acpi/nvdimm: add a helper to augment SRAT generation > tests/acpi: update expected SRAT files > > configure | 3 + > qapi/misc.json | 6 +- > contrib/libvhost-user/libvhost-user.h | 24 +- > hw/i386/acpi-common.h | 15 + > include/hw/acpi/acpi-defs.h | 2 + > include/hw/acpi/aml-build.h | 2 + > include/hw/acpi/generic_event_device.h | 2 +- > include/hw/mem/nvdimm.h | 1 + > include/hw/virtio/vhost-user-vsock.h | 36 ++ > include/hw/virtio/vhost-user.h | 1 + > include/hw/virtio/vhost-vsock-common.h | 47 +++ > include/hw/virtio/vhost-vsock.h | 11 +- > include/hw/virtio/virtio-balloon.h | 3 +- > include/sysemu/tpm.h | 2 + > tests/qtest/tpm-emu.h | 3 + > chardev/char-socket.c | 7 +- > contrib/libvhost-user/libvhost-user.c | 351 +++++++++++++---- > contrib/vhost-user-blk/vhost-user-blk.c | 4 +- > hw/acpi/aml-build.c | 49 ++- > hw/acpi/generic_event_device.c | 16 +- > hw/acpi/nvdimm.c | 23 ++ > hw/arm/virt-acpi-build.c | 11 + > hw/block/vhost-user-blk.c | 38 +- > hw/char/parallel.c | 22 ++ > hw/char/serial-isa.c | 22 ++ > hw/core/machine.c | 4 +- > hw/i386/acpi-build.c | 270 +------------ > hw/i386/acpi-common.c | 156 ++++++++ > hw/pci-host/i440fx.c | 3 +- > hw/pci-host/prep.c | 2 +- > hw/pci-host/q35.c | 2 +- > hw/pci-host/versatile.c | 5 +- > hw/pci/msix.c | 6 + > hw/pci/pci.c | 18 +- > hw/pci/pci_bridge.c | 7 +- > hw/pci/pcie.c | 19 +- > hw/rtc/mc146818rtc.c | 24 ++ > hw/virtio/vhost-user-vsock-pci.c | 84 +++++ > hw/virtio/vhost-user-vsock.c | 181 +++++++++ > hw/virtio/vhost-user.c | 646 +++++++++++++++++++++++++++----- > hw/virtio/vhost-vsock-common.c | 258 +++++++++++++ > hw/virtio/vhost-vsock.c | 283 +++----------- > hw/virtio/vhost.c | 4 +- > hw/virtio/virtio-balloon.c | 137 ++++++- > hw/virtio/virtio-pci.c | 12 +- > monitor/hmp-cmds.c | 3 +- > tests/qtest/bios-tables-test.c | 58 +++ > tests/qtest/tpm-emu.c | 1 - > MAINTAINERS | 3 +- > docs/interop/vhost-user.rst | 44 +++ > hw/i386/Makefile.objs | 1 + > hw/virtio/Makefile.objs | 4 +- > tests/data/acpi/pc/DSDT | Bin 5125 -> 5014 bytes > tests/data/acpi/pc/DSDT.acpihmat | Bin 6449 -> 6338 bytes > tests/data/acpi/pc/DSDT.bridge | Bin 6984 -> 6873 bytes > tests/data/acpi/pc/DSDT.cphp | Bin 5588 -> 5477 bytes > tests/data/acpi/pc/DSDT.dimmpxm | Bin 6778 -> 6667 bytes > tests/data/acpi/pc/DSDT.ipmikcs | Bin 5197 -> 5086 bytes > tests/data/acpi/pc/DSDT.memhp | Bin 6484 -> 6373 bytes > tests/data/acpi/pc/DSDT.numamem | Bin 5131 -> 5020 bytes > tests/data/acpi/pc/SRAT.dimmpxm | Bin 392 -> 392 bytes > tests/data/acpi/q35/DSDT | Bin 7863 -> 7752 bytes > tests/data/acpi/q35/DSDT.acpihmat | Bin 9187 -> 9076 bytes > tests/data/acpi/q35/DSDT.bridge | Bin 7880 -> 7769 bytes > tests/data/acpi/q35/DSDT.cphp | Bin 8326 -> 8215 bytes > tests/data/acpi/q35/DSDT.dimmpxm | Bin 9516 -> 9405 bytes > tests/data/acpi/q35/DSDT.ipmibt | Bin 7938 -> 7827 bytes > tests/data/acpi/q35/DSDT.memhp | Bin 9222 -> 9111 bytes > tests/data/acpi/q35/DSDT.mmio64 | Bin 8993 -> 8882 bytes > tests/data/acpi/q35/DSDT.numamem | Bin 7869 -> 7758 bytes > tests/data/acpi/q35/DSDT.tis | Bin 0 -> 8357 bytes > tests/data/acpi/q35/SRAT.dimmpxm | Bin 392 -> 392 bytes > tests/data/acpi/q35/TPM2.tis | Bin 0 -> 76 bytes > tests/data/acpi/virt/SRAT.memhp | Bin 186 -> 226 bytes > tests/qtest/Makefile.include | 1 + > 75 files changed, 2183 insertions(+), 754 deletions(-) > create mode 100644 hw/i386/acpi-common.h > create mode 100644 include/hw/virtio/vhost-user-vsock.h > create mode 100644 include/hw/virtio/vhost-vsock-common.h > create mode 100644 hw/i386/acpi-common.c > create mode 100644 hw/virtio/vhost-user-vsock-pci.c > create mode 100644 hw/virtio/vhost-user-vsock.c > create mode 100644 hw/virtio/vhost-vsock-common.c > create mode 100644 tests/data/acpi/q35/DSDT.tis > create mode 100644 tests/data/acpi/q35/TPM2.tis > >
Hi, On 6/16/20 9:26 AM, Auger Eric wrote: > Hi Michael, > > + Stefan > > On 6/12/20 4:51 PM, Michael S. Tsirkin wrote: >> changes from v1: >> - printf format fixed for 32 bit hosts >> - a couple of bugfixes added >> >> The following changes since commit 49ee11555262a256afec592dfed7c5902d5eefd2: >> >> Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.1-pull-request' into staging (2020-06-08 11:04:57 +0100) >> >> are available in the Git repository at: >> >> git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream >> >> for you to fetch changes up to 10d35e581901c09ee3817ac7cddd296d05291a9d: >> >> virtio-pci: fix queue_enable write (2020-06-12 10:17:06 -0400) >> >> ---------------------------------------------------------------- >> virtio,acpi,pci: features, fixes, cleanups, tests >> >> Max slots negotiation for vhost-user. >> Free page reporting for balloon. >> Partial TPM2 ACPI support for ARM. >> Support for NVDIMMs having their own proximity domains. >> New vhost-user-vsock device. >> >> Fixes, cleanups in ACPI, PCI, virtio. >> New tests for TPM ACPI. >> >> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> >> >> ---------------------------------------------------------------- >> Alexander Duyck (2): >> virtio-balloon: Implement support for page poison reporting feature >> virtio-balloon: Provide an interface for free page reporting >> >> David Hildenbrand (3): >> virtio-balloon: fix free page hinting without an iothread >> virtio-balloon: fix free page hinting check on unrealize >> virtio-balloon: unref the iothread when unrealizing >> >> Dima Stepanov (2): >> char-socket: return -1 in case of disconnect during tcp_chr_write >> vhost-user-blk: delay vhost_user_blk_disconnect >> >> Eric Auger (8): >> acpi: Convert build_tpm2() to build_append* API >> acpi: Move build_tpm2() in the generic part >> arm/acpi: TPM2 ACPI table support > I just noticed you did not take > > [PATCH v4 4/5] arm/acpi: Add the TPM2.0 device under the DSDT > [PATCH v4 5/5] docs/specs/tpm: ACPI boot now supported for TPM/ARM > > from [PATCH v4 0/5] vTPM/aarch64 ACPI support. > > Without 4/5 the TPM does not work with ACPI. With LUKS auto decryption > you get: > > [ 34.098051] dracut-initqueue[1084]: A TPM2 device with the in-kernel > resource manager is needed > > Do you wait for other reviews? Shall I resend those 2 patches? Actually the patches pulled does not correspond to v4. I will submit a series with latest modifications in build_tpm2() + missing patches. Thanks Eric > > Thanks > > Eric > > >> test/tpm-emu: include sockets and channel headers in tpm-emu header >> tests/acpi: Add void tables for Q35/TPM-TIS bios-tables-test >> tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS >> bios-tables-test: Add Q35/TPM-TIS test >> bios-tables-test: Generate reference tables for Q35/TPM-TIS >> >> Gerd Hoffmann (12): >> qtest: allow DSDT acpi table changes >> acpi: move aml builder code for rtc device >> acpi: rtc: use a single crs range >> acpi: serial: don't use _STA method >> acpi: move aml builder code for serial device >> acpi: parallel: don't use _STA method >> acpi: move aml builder code for parallel device >> acpi: make build_madt() more generic. >> acpi: create acpi-common.c and move madt code >> acpi: madt: skip pci override on pci-less systems. >> acpi: fadt: add hw-reduced sleep register support >> acpi: ged: rename event memory region >> >> Jason Wang (1): >> virtio-pci: fix queue_enable write >> >> Julia Suvorova (1): >> hw/pci/pcie: Move hot plug capability check to pre_plug callback >> >> Michael S. Tsirkin (2): >> msix: allow qword MSI-X table accesses >> tests/acpi: update DSDT expected files >> >> Peter Xu (1): >> pci: Display PCI IRQ pin in "info pci" >> >> Philippe Mathieu-Daudé (4): >> hw/pci-host/prep: Correct RAVEN bus bridge memory region size >> hw/pci/pci_bridge: Correct pci_bridge_io memory region size >> hw/pci/pci_bridge: Use the IEC binary prefix definitions >> hw/pci-host: Use the IEC binary prefix definitions >> >> Prasad J Pandit (1): >> pci: assert configuration access is within bounds >> >> Raphael Norwitz (11): >> Add helper to populate vhost-user message regions >> Add vhost-user helper to get MemoryRegion data >> Add VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS >> Transmit vhost-user memory regions individually >> Lift max memory slots limit imposed by vhost-user >> Refactor out libvhost-user fault generation logic >> Support ram slot configuration in libvhost-user >> Support adding individual regions in libvhost-user >> Support individual region unmap in libvhost-user >> Lift max ram slots limit in libvhost-user >> Fix parameter type in vhost migration log path >> >> Stefan Berger (1): >> acpi: tpm: Do not build TCPA table for TPM 2 >> >> Stefan Hajnoczi (1): >> libvhost-user: advertise vring features >> >> Stefano Garzarella (3): >> vhost-vsock: add vhost-vsock-common abstraction >> virtio: add vhost-user-vsock base device >> virtio: add vhost-user-vsock-pci device >> >> Thomas Huth (2): >> MAINTAINERS: Fix the classification of bios-tables-test-allowed-diff.h >> hw/pci: Fix crash when running QEMU with "-nic model=rocker" >> >> Vishal Verma (3): >> diffs-allowed: add the SRAT AML to diffs-allowed >> hw/acpi/nvdimm: add a helper to augment SRAT generation >> tests/acpi: update expected SRAT files >> >> configure | 3 + >> qapi/misc.json | 6 +- >> contrib/libvhost-user/libvhost-user.h | 24 +- >> hw/i386/acpi-common.h | 15 + >> include/hw/acpi/acpi-defs.h | 2 + >> include/hw/acpi/aml-build.h | 2 + >> include/hw/acpi/generic_event_device.h | 2 +- >> include/hw/mem/nvdimm.h | 1 + >> include/hw/virtio/vhost-user-vsock.h | 36 ++ >> include/hw/virtio/vhost-user.h | 1 + >> include/hw/virtio/vhost-vsock-common.h | 47 +++ >> include/hw/virtio/vhost-vsock.h | 11 +- >> include/hw/virtio/virtio-balloon.h | 3 +- >> include/sysemu/tpm.h | 2 + >> tests/qtest/tpm-emu.h | 3 + >> chardev/char-socket.c | 7 +- >> contrib/libvhost-user/libvhost-user.c | 351 +++++++++++++---- >> contrib/vhost-user-blk/vhost-user-blk.c | 4 +- >> hw/acpi/aml-build.c | 49 ++- >> hw/acpi/generic_event_device.c | 16 +- >> hw/acpi/nvdimm.c | 23 ++ >> hw/arm/virt-acpi-build.c | 11 + >> hw/block/vhost-user-blk.c | 38 +- >> hw/char/parallel.c | 22 ++ >> hw/char/serial-isa.c | 22 ++ >> hw/core/machine.c | 4 +- >> hw/i386/acpi-build.c | 270 +------------ >> hw/i386/acpi-common.c | 156 ++++++++ >> hw/pci-host/i440fx.c | 3 +- >> hw/pci-host/prep.c | 2 +- >> hw/pci-host/q35.c | 2 +- >> hw/pci-host/versatile.c | 5 +- >> hw/pci/msix.c | 6 + >> hw/pci/pci.c | 18 +- >> hw/pci/pci_bridge.c | 7 +- >> hw/pci/pcie.c | 19 +- >> hw/rtc/mc146818rtc.c | 24 ++ >> hw/virtio/vhost-user-vsock-pci.c | 84 +++++ >> hw/virtio/vhost-user-vsock.c | 181 +++++++++ >> hw/virtio/vhost-user.c | 646 +++++++++++++++++++++++++++----- >> hw/virtio/vhost-vsock-common.c | 258 +++++++++++++ >> hw/virtio/vhost-vsock.c | 283 +++----------- >> hw/virtio/vhost.c | 4 +- >> hw/virtio/virtio-balloon.c | 137 ++++++- >> hw/virtio/virtio-pci.c | 12 +- >> monitor/hmp-cmds.c | 3 +- >> tests/qtest/bios-tables-test.c | 58 +++ >> tests/qtest/tpm-emu.c | 1 - >> MAINTAINERS | 3 +- >> docs/interop/vhost-user.rst | 44 +++ >> hw/i386/Makefile.objs | 1 + >> hw/virtio/Makefile.objs | 4 +- >> tests/data/acpi/pc/DSDT | Bin 5125 -> 5014 bytes >> tests/data/acpi/pc/DSDT.acpihmat | Bin 6449 -> 6338 bytes >> tests/data/acpi/pc/DSDT.bridge | Bin 6984 -> 6873 bytes >> tests/data/acpi/pc/DSDT.cphp | Bin 5588 -> 5477 bytes >> tests/data/acpi/pc/DSDT.dimmpxm | Bin 6778 -> 6667 bytes >> tests/data/acpi/pc/DSDT.ipmikcs | Bin 5197 -> 5086 bytes >> tests/data/acpi/pc/DSDT.memhp | Bin 6484 -> 6373 bytes >> tests/data/acpi/pc/DSDT.numamem | Bin 5131 -> 5020 bytes >> tests/data/acpi/pc/SRAT.dimmpxm | Bin 392 -> 392 bytes >> tests/data/acpi/q35/DSDT | Bin 7863 -> 7752 bytes >> tests/data/acpi/q35/DSDT.acpihmat | Bin 9187 -> 9076 bytes >> tests/data/acpi/q35/DSDT.bridge | Bin 7880 -> 7769 bytes >> tests/data/acpi/q35/DSDT.cphp | Bin 8326 -> 8215 bytes >> tests/data/acpi/q35/DSDT.dimmpxm | Bin 9516 -> 9405 bytes >> tests/data/acpi/q35/DSDT.ipmibt | Bin 7938 -> 7827 bytes >> tests/data/acpi/q35/DSDT.memhp | Bin 9222 -> 9111 bytes >> tests/data/acpi/q35/DSDT.mmio64 | Bin 8993 -> 8882 bytes >> tests/data/acpi/q35/DSDT.numamem | Bin 7869 -> 7758 bytes >> tests/data/acpi/q35/DSDT.tis | Bin 0 -> 8357 bytes >> tests/data/acpi/q35/SRAT.dimmpxm | Bin 392 -> 392 bytes >> tests/data/acpi/q35/TPM2.tis | Bin 0 -> 76 bytes >> tests/data/acpi/virt/SRAT.memhp | Bin 186 -> 226 bytes >> tests/qtest/Makefile.include | 1 + >> 75 files changed, 2183 insertions(+), 754 deletions(-) >> create mode 100644 hw/i386/acpi-common.h >> create mode 100644 include/hw/virtio/vhost-user-vsock.h >> create mode 100644 include/hw/virtio/vhost-vsock-common.h >> create mode 100644 hw/i386/acpi-common.c >> create mode 100644 hw/virtio/vhost-user-vsock-pci.c >> create mode 100644 hw/virtio/vhost-user-vsock.c >> create mode 100644 hw/virtio/vhost-vsock-common.c >> create mode 100644 tests/data/acpi/q35/DSDT.tis >> create mode 100644 tests/data/acpi/q35/TPM2.tis >> >>
changes from v1: - printf format fixed for 32 bit hosts - a couple of bugfixes added The following changes since commit 49ee11555262a256afec592dfed7c5902d5eefd2: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.1-pull-request' into staging (2020-06-08 11:04:57 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to 10d35e581901c09ee3817ac7cddd296d05291a9d: virtio-pci: fix queue_enable write (2020-06-12 10:17:06 -0400) ---------------------------------------------------------------- virtio,acpi,pci: features, fixes, cleanups, tests Max slots negotiation for vhost-user. Free page reporting for balloon. Partial TPM2 ACPI support for ARM. Support for NVDIMMs having their own proximity domains. New vhost-user-vsock device. Fixes, cleanups in ACPI, PCI, virtio. New tests for TPM ACPI. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> ---------------------------------------------------------------- Alexander Duyck (2): virtio-balloon: Implement support for page poison reporting feature virtio-balloon: Provide an interface for free page reporting David Hildenbrand (3): virtio-balloon: fix free page hinting without an iothread virtio-balloon: fix free page hinting check on unrealize virtio-balloon: unref the iothread when unrealizing Dima Stepanov (2): char-socket: return -1 in case of disconnect during tcp_chr_write vhost-user-blk: delay vhost_user_blk_disconnect Eric Auger (8): acpi: Convert build_tpm2() to build_append* API acpi: Move build_tpm2() in the generic part arm/acpi: TPM2 ACPI table support test/tpm-emu: include sockets and channel headers in tpm-emu header tests/acpi: Add void tables for Q35/TPM-TIS bios-tables-test tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS bios-tables-test: Add Q35/TPM-TIS test bios-tables-test: Generate reference tables for Q35/TPM-TIS Gerd Hoffmann (12): qtest: allow DSDT acpi table changes acpi: move aml builder code for rtc device acpi: rtc: use a single crs range acpi: serial: don't use _STA method acpi: move aml builder code for serial device acpi: parallel: don't use _STA method acpi: move aml builder code for parallel device acpi: make build_madt() more generic. acpi: create acpi-common.c and move madt code acpi: madt: skip pci override on pci-less systems. acpi: fadt: add hw-reduced sleep register support acpi: ged: rename event memory region Jason Wang (1): virtio-pci: fix queue_enable write Julia Suvorova (1): hw/pci/pcie: Move hot plug capability check to pre_plug callback Michael S. Tsirkin (2): msix: allow qword MSI-X table accesses tests/acpi: update DSDT expected files Peter Xu (1): pci: Display PCI IRQ pin in "info pci" Philippe Mathieu-Daudé (4): hw/pci-host/prep: Correct RAVEN bus bridge memory region size hw/pci/pci_bridge: Correct pci_bridge_io memory region size hw/pci/pci_bridge: Use the IEC binary prefix definitions hw/pci-host: Use the IEC binary prefix definitions Prasad J Pandit (1): pci: assert configuration access is within bounds Raphael Norwitz (11): Add helper to populate vhost-user message regions Add vhost-user helper to get MemoryRegion data Add VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS Transmit vhost-user memory regions individually Lift max memory slots limit imposed by vhost-user Refactor out libvhost-user fault generation logic Support ram slot configuration in libvhost-user Support adding individual regions in libvhost-user Support individual region unmap in libvhost-user Lift max ram slots limit in libvhost-user Fix parameter type in vhost migration log path Stefan Berger (1): acpi: tpm: Do not build TCPA table for TPM 2 Stefan Hajnoczi (1): libvhost-user: advertise vring features Stefano Garzarella (3): vhost-vsock: add vhost-vsock-common abstraction virtio: add vhost-user-vsock base device virtio: add vhost-user-vsock-pci device Thomas Huth (2): MAINTAINERS: Fix the classification of bios-tables-test-allowed-diff.h hw/pci: Fix crash when running QEMU with "-nic model=rocker" Vishal Verma (3): diffs-allowed: add the SRAT AML to diffs-allowed hw/acpi/nvdimm: add a helper to augment SRAT generation tests/acpi: update expected SRAT files configure | 3 + qapi/misc.json | 6 +- contrib/libvhost-user/libvhost-user.h | 24 +- hw/i386/acpi-common.h | 15 + include/hw/acpi/acpi-defs.h | 2 + include/hw/acpi/aml-build.h | 2 + include/hw/acpi/generic_event_device.h | 2 +- include/hw/mem/nvdimm.h | 1 + include/hw/virtio/vhost-user-vsock.h | 36 ++ include/hw/virtio/vhost-user.h | 1 + include/hw/virtio/vhost-vsock-common.h | 47 +++ include/hw/virtio/vhost-vsock.h | 11 +- include/hw/virtio/virtio-balloon.h | 3 +- include/sysemu/tpm.h | 2 + tests/qtest/tpm-emu.h | 3 + chardev/char-socket.c | 7 +- contrib/libvhost-user/libvhost-user.c | 351 +++++++++++++---- contrib/vhost-user-blk/vhost-user-blk.c | 4 +- hw/acpi/aml-build.c | 49 ++- hw/acpi/generic_event_device.c | 16 +- hw/acpi/nvdimm.c | 23 ++ hw/arm/virt-acpi-build.c | 11 + hw/block/vhost-user-blk.c | 38 +- hw/char/parallel.c | 22 ++ hw/char/serial-isa.c | 22 ++ hw/core/machine.c | 4 +- hw/i386/acpi-build.c | 270 +------------ hw/i386/acpi-common.c | 156 ++++++++ hw/pci-host/i440fx.c | 3 +- hw/pci-host/prep.c | 2 +- hw/pci-host/q35.c | 2 +- hw/pci-host/versatile.c | 5 +- hw/pci/msix.c | 6 + hw/pci/pci.c | 18 +- hw/pci/pci_bridge.c | 7 +- hw/pci/pcie.c | 19 +- hw/rtc/mc146818rtc.c | 24 ++ hw/virtio/vhost-user-vsock-pci.c | 84 +++++ hw/virtio/vhost-user-vsock.c | 181 +++++++++ hw/virtio/vhost-user.c | 646 +++++++++++++++++++++++++++----- hw/virtio/vhost-vsock-common.c | 258 +++++++++++++ hw/virtio/vhost-vsock.c | 283 +++----------- hw/virtio/vhost.c | 4 +- hw/virtio/virtio-balloon.c | 137 ++++++- hw/virtio/virtio-pci.c | 12 +- monitor/hmp-cmds.c | 3 +- tests/qtest/bios-tables-test.c | 58 +++ tests/qtest/tpm-emu.c | 1 - MAINTAINERS | 3 +- docs/interop/vhost-user.rst | 44 +++ hw/i386/Makefile.objs | 1 + hw/virtio/Makefile.objs | 4 +- tests/data/acpi/pc/DSDT | Bin 5125 -> 5014 bytes tests/data/acpi/pc/DSDT.acpihmat | Bin 6449 -> 6338 bytes tests/data/acpi/pc/DSDT.bridge | Bin 6984 -> 6873 bytes tests/data/acpi/pc/DSDT.cphp | Bin 5588 -> 5477 bytes tests/data/acpi/pc/DSDT.dimmpxm | Bin 6778 -> 6667 bytes tests/data/acpi/pc/DSDT.ipmikcs | Bin 5197 -> 5086 bytes tests/data/acpi/pc/DSDT.memhp | Bin 6484 -> 6373 bytes tests/data/acpi/pc/DSDT.numamem | Bin 5131 -> 5020 bytes tests/data/acpi/pc/SRAT.dimmpxm | Bin 392 -> 392 bytes tests/data/acpi/q35/DSDT | Bin 7863 -> 7752 bytes tests/data/acpi/q35/DSDT.acpihmat | Bin 9187 -> 9076 bytes tests/data/acpi/q35/DSDT.bridge | Bin 7880 -> 7769 bytes tests/data/acpi/q35/DSDT.cphp | Bin 8326 -> 8215 bytes tests/data/acpi/q35/DSDT.dimmpxm | Bin 9516 -> 9405 bytes tests/data/acpi/q35/DSDT.ipmibt | Bin 7938 -> 7827 bytes tests/data/acpi/q35/DSDT.memhp | Bin 9222 -> 9111 bytes tests/data/acpi/q35/DSDT.mmio64 | Bin 8993 -> 8882 bytes tests/data/acpi/q35/DSDT.numamem | Bin 7869 -> 7758 bytes tests/data/acpi/q35/DSDT.tis | Bin 0 -> 8357 bytes tests/data/acpi/q35/SRAT.dimmpxm | Bin 392 -> 392 bytes tests/data/acpi/q35/TPM2.tis | Bin 0 -> 76 bytes tests/data/acpi/virt/SRAT.memhp | Bin 186 -> 226 bytes tests/qtest/Makefile.include | 1 + 75 files changed, 2183 insertions(+), 754 deletions(-) create mode 100644 hw/i386/acpi-common.h create mode 100644 include/hw/virtio/vhost-user-vsock.h create mode 100644 include/hw/virtio/vhost-vsock-common.h create mode 100644 hw/i386/acpi-common.c create mode 100644 hw/virtio/vhost-user-vsock-pci.c create mode 100644 hw/virtio/vhost-user-vsock.c create mode 100644 hw/virtio/vhost-vsock-common.c create mode 100644 tests/data/acpi/q35/DSDT.tis create mode 100644 tests/data/acpi/q35/TPM2.tis