Message ID | 20200608163823.8890-6-philmd@redhat.com |
---|---|
State | New |
Headers | show |
Series | accel: Allow targets to use Kconfig | expand |
On 6/8/20 6:38 PM, Philippe Mathieu-Daudé wrote: > One might get caught trying to understand unexpected Makefile > behavior. Trailing backslash can help to split very long lines, > but are rather dangerous when nothing follow. Preserve other > developers debugging time by removing this one. > > Reviewed-by: Thomas Huth <thuth@redhat.com> > Reviewed-by: Alistair Francis <alistair.francis@wdc.com> I forgot here: Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index d1af126ea1..52956b16fd 100644 > --- a/Makefile > +++ b/Makefile > @@ -420,7 +420,7 @@ MINIKCONF_ARGS = \ > > MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host $(SRC_PATH)/hw/Kconfig > MINIKCONF_DEPS = $(MINIKCONF_INPUTS) $(wildcard $(SRC_PATH)/hw/*/Kconfig) > -MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py \ > +MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py > > $(SUBDIR_DEVICES_MAK): %/config-devices.mak: default-configs/%.mak $(MINIKCONF_DEPS) $(BUILD_DIR)/config-host.mak > $(call quiet-command, $(MINIKCONF) $(MINIKCONF_ARGS) > $@.tmp, "GEN", "$@.tmp") >
diff --git a/Makefile b/Makefile index d1af126ea1..52956b16fd 100644 --- a/Makefile +++ b/Makefile @@ -420,7 +420,7 @@ MINIKCONF_ARGS = \ MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host $(SRC_PATH)/hw/Kconfig MINIKCONF_DEPS = $(MINIKCONF_INPUTS) $(wildcard $(SRC_PATH)/hw/*/Kconfig) -MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py \ +MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py $(SUBDIR_DEVICES_MAK): %/config-devices.mak: default-configs/%.mak $(MINIKCONF_DEPS) $(BUILD_DIR)/config-host.mak $(call quiet-command, $(MINIKCONF) $(MINIKCONF_ARGS) > $@.tmp, "GEN", "$@.tmp")