| Message ID | 20200608090142.6793-3-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | sh4: Mark it orphan in MAINTAINERS & trivial fixes | expand |
On 08/06/2020 11.01, Philippe Mathieu-Daudé wrote: > Last commit from Magnus Damm is fc8e320ef583, which date is > Fri Nov 13 2009. As nobody else seems to care about the patches > posted [*] related to the R2D and Shix machines, mark them orphan. > > Many thanks to Magnus for his substantial contributions to QEMU, > and for introducing these SH4 based machine! > > [*] https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08519.html > > Cc: Magnus Damm <magnus.damm@gmail.com> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > MAINTAINERS | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 49d90c70de..a012d9b74e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1250,14 +1250,15 @@ SH4 Machines > ------------ > R2D > M: Magnus Damm <magnus.damm@gmail.com> > -S: Maintained > +S: Orphan > F: hw/sh4/r2d.c > F: hw/intc/sh_intc.c > F: hw/timer/sh_timer.c > +F: include/hw/sh4/sh_intc.h > > Shix > M: Magnus Damm <magnus.damm@gmail.com> > -S: Odd Fixes > +S: Orphan > F: hw/sh4/shix.c Having both, an "M:" entry and "S: Orphan" in a section sounds weird. Magnus, are you still interested in these sections? If not, I think the "M:" line should be removed...? Thomas
Thomas Huth <thuth@redhat.com> writes: > On 08/06/2020 11.01, Philippe Mathieu-Daudé wrote: >> Last commit from Magnus Damm is fc8e320ef583, which date is >> Fri Nov 13 2009. As nobody else seems to care about the patches >> posted [*] related to the R2D and Shix machines, mark them orphan. >> >> Many thanks to Magnus for his substantial contributions to QEMU, >> and for introducing these SH4 based machine! s/machine/machines/ >> >> [*] https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08519.html >> >> Cc: Magnus Damm <magnus.damm@gmail.com> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- >> MAINTAINERS | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 49d90c70de..a012d9b74e 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -1250,14 +1250,15 @@ SH4 Machines >> ------------ >> R2D >> M: Magnus Damm <magnus.damm@gmail.com> >> -S: Maintained >> +S: Orphan >> F: hw/sh4/r2d.c >> F: hw/intc/sh_intc.c >> F: hw/timer/sh_timer.c >> +F: include/hw/sh4/sh_intc.h >> >> Shix >> M: Magnus Damm <magnus.damm@gmail.com> >> -S: Odd Fixes >> +S: Orphan >> F: hw/sh4/shix.c > > Having both, an "M:" entry and "S: Orphan" in a section sounds weird. > Magnus, are you still interested in these sections? If not, I think the > "M:" line should be removed...? Concur. Of course, let's give Magnus a chance to chime in.
Hi Markus and Thomas, On Tue, Jun 9, 2020 at 5:41 PM Markus Armbruster <armbru@redhat.com> wrote: > > Thomas Huth <thuth@redhat.com> writes: > > > On 08/06/2020 11.01, Philippe Mathieu-Daudé wrote: > >> Last commit from Magnus Damm is fc8e320ef583, which date is > >> Fri Nov 13 2009. As nobody else seems to care about the patches > >> posted [*] related to the R2D and Shix machines, mark them orphan. > >> > >> Many thanks to Magnus for his substantial contributions to QEMU, > >> and for introducing these SH4 based machine! > > s/machine/machines/ > > >> > >> [*] https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08519.html > >> > >> Cc: Magnus Damm <magnus.damm@gmail.com> > >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > >> --- > >> MAINTAINERS | 5 +++-- > >> 1 file changed, 3 insertions(+), 2 deletions(-) > >> > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index 49d90c70de..a012d9b74e 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -1250,14 +1250,15 @@ SH4 Machines > >> ------------ > >> R2D > >> M: Magnus Damm <magnus.damm@gmail.com> > >> -S: Maintained > >> +S: Orphan > >> F: hw/sh4/r2d.c > >> F: hw/intc/sh_intc.c > >> F: hw/timer/sh_timer.c > >> +F: include/hw/sh4/sh_intc.h > >> > >> Shix > >> M: Magnus Damm <magnus.damm@gmail.com> > >> -S: Odd Fixes > >> +S: Orphan > >> F: hw/sh4/shix.c > > > > Having both, an "M:" entry and "S: Orphan" in a section sounds weird. > > Magnus, are you still interested in these sections? If not, I think the > > "M:" line should be removed...? > > Concur. Of course, let's give Magnus a chance to chime in. Thanks guys! I'm interested but don't have so much time available to commit to this I'm afraid. In particular I'm keen on trying to keep R2D around since I happen to have a physical machine setup in my remote access rack. SH4 with FPU used to have alright gcc + binutils toolchain and glibc support once while other SuperH SoCs lacked some portions. So keeping SH4 (sh775x) around would be nice IMO. Cheers, / magnus
Hi Magnus, On 6/9/20 10:59 AM, Magnus Damm wrote: > Hi Markus and Thomas, > > On Tue, Jun 9, 2020 at 5:41 PM Markus Armbruster <armbru@redhat.com> wrote: >> >> Thomas Huth <thuth@redhat.com> writes: >> >>> On 08/06/2020 11.01, Philippe Mathieu-Daudé wrote: >>>> Last commit from Magnus Damm is fc8e320ef583, which date is >>>> Fri Nov 13 2009. As nobody else seems to care about the patches >>>> posted [*] related to the R2D and Shix machines, mark them orphan. >>>> >>>> Many thanks to Magnus for his substantial contributions to QEMU, >>>> and for introducing these SH4 based machine! >> >> s/machine/machines/ >> >>>> >>>> [*] https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08519.html >>>> >>>> Cc: Magnus Damm <magnus.damm@gmail.com> >>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>>> --- >>>> MAINTAINERS | 5 +++-- >>>> 1 file changed, 3 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index 49d90c70de..a012d9b74e 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -1250,14 +1250,15 @@ SH4 Machines >>>> ------------ >>>> R2D >>>> M: Magnus Damm <magnus.damm@gmail.com> >>>> -S: Maintained >>>> +S: Orphan >>>> F: hw/sh4/r2d.c >>>> F: hw/intc/sh_intc.c >>>> F: hw/timer/sh_timer.c >>>> +F: include/hw/sh4/sh_intc.h >>>> >>>> Shix >>>> M: Magnus Damm <magnus.damm@gmail.com> >>>> -S: Odd Fixes >>>> +S: Orphan >>>> F: hw/sh4/shix.c >>> >>> Having both, an "M:" entry and "S: Orphan" in a section sounds weird. >>> Magnus, are you still interested in these sections? If not, I think the >>> "M:" line should be removed...? >> >> Concur. Of course, let's give Magnus a chance to chime in. > > Thanks guys! I'm interested but don't have so much time available to > commit to this I'm afraid. In particular I'm keen on trying to keep > R2D around since I happen to have a physical machine setup in my > remote access rack. SH4 with FPU used to have alright gcc + binutils > toolchain and glibc support once while other SuperH SoCs lacked some > portions. So keeping SH4 (sh775x) around would be nice IMO. Great news! FYI Yoshinori Sato did a great job on updating the Renesas hardware, see: https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08584.html He might be able to help with the UART/TIMER peripherals used by the R2D, see a suggestion to add a 'Renesas hardware' entry: https://www.mail-archive.com/qemu-devel@nongnu.org/msg708478.html If Yoshinori accept the suggestion to add a Renesas hardware entry, do you agree to be listed as there too? Maybe with a 'R:' tag for designated reviewer instead of maintainer. So I'll respin this series with these changes: R2D: S: 'Maintained' -> 'Odd Fixes' So contributors don't wait for you to take the patches, and they can go via qemu-trivial. And Shix -> No maintainer, S: 'Obsolete'. The TCG backend stay orphan. Regards, Phil. > > Cheers, > > / magnus >
On Tue, 09 Jun 2020 18:12:42 +0900, Philippe Mathieu-Daudé wrote: > > Hi Magnus, > > On 6/9/20 10:59 AM, Magnus Damm wrote: > > Hi Markus and Thomas, > > > > On Tue, Jun 9, 2020 at 5:41 PM Markus Armbruster <armbru@redhat.com> wrote: > >> > >> Thomas Huth <thuth@redhat.com> writes: > >> > >>> On 08/06/2020 11.01, Philippe Mathieu-Daudé wrote: > >>>> Last commit from Magnus Damm is fc8e320ef583, which date is > >>>> Fri Nov 13 2009. As nobody else seems to care about the patches > >>>> posted [*] related to the R2D and Shix machines, mark them orphan. > >>>> > >>>> Many thanks to Magnus for his substantial contributions to QEMU, > >>>> and for introducing these SH4 based machine! > >> > >> s/machine/machines/ > >> > >>>> > >>>> [*] https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08519.html > >>>> > >>>> Cc: Magnus Damm <magnus.damm@gmail.com> > >>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > >>>> --- > >>>> MAINTAINERS | 5 +++-- > >>>> 1 file changed, 3 insertions(+), 2 deletions(-) > >>>> > >>>> diff --git a/MAINTAINERS b/MAINTAINERS > >>>> index 49d90c70de..a012d9b74e 100644 > >>>> --- a/MAINTAINERS > >>>> +++ b/MAINTAINERS > >>>> @@ -1250,14 +1250,15 @@ SH4 Machines > >>>> ------------ > >>>> R2D > >>>> M: Magnus Damm <magnus.damm@gmail.com> > >>>> -S: Maintained > >>>> +S: Orphan > >>>> F: hw/sh4/r2d.c > >>>> F: hw/intc/sh_intc.c > >>>> F: hw/timer/sh_timer.c > >>>> +F: include/hw/sh4/sh_intc.h > >>>> > >>>> Shix > >>>> M: Magnus Damm <magnus.damm@gmail.com> > >>>> -S: Odd Fixes > >>>> +S: Orphan > >>>> F: hw/sh4/shix.c > >>> > >>> Having both, an "M:" entry and "S: Orphan" in a section sounds weird. > >>> Magnus, are you still interested in these sections? If not, I think the > >>> "M:" line should be removed...? > >> > >> Concur. Of course, let's give Magnus a chance to chime in. > > > > Thanks guys! I'm interested but don't have so much time available to > > commit to this I'm afraid. In particular I'm keen on trying to keep > > R2D around since I happen to have a physical machine setup in my > > remote access rack. SH4 with FPU used to have alright gcc + binutils > > toolchain and glibc support once while other SuperH SoCs lacked some > > portions. So keeping SH4 (sh775x) around would be nice IMO. > > Great news! > > FYI Yoshinori Sato did a great job on updating the Renesas > hardware, see: > https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08584.html > > He might be able to help with the UART/TIMER peripherals used by the > R2D, see a suggestion to add a 'Renesas hardware' entry: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg708478.html > > If Yoshinori accept the suggestion to add a Renesas hardware entry, do > you agree to be listed as there too? Maybe with a 'R:' tag for > designated reviewer instead of maintainer. > > So I'll respin this series with these changes: > > R2D: S: 'Maintained' -> 'Odd Fixes' > > So contributors don't wait for you to take the patches, and they can go > via qemu-trivial. > > And Shix -> No maintainer, S: 'Obsolete'. > > The TCG backend stay orphan. > > Regards, > > Phil. > > > > > Cheers, > > > > / magnus > > > OK. I also need sh4, so I will perform maintenance.
пон, 8. јун 2020. у 11:03 Philippe Mathieu-Daudé <f4bug@amsat.org> је написао/ла: > > Last commit from Magnus Damm is fc8e320ef583, which date is > Fri Nov 13 2009. As nobody else seems to care about the patches > posted [*] related to the R2D and Shix machines, mark them orphan. > > Many thanks to Magnus for his substantial contributions to QEMU, > and for introducing these SH4 based machine! > > [*] https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08519.html > > Cc: Magnus Damm <magnus.damm@gmail.com> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- I think, regarding both patches 1 and 2 of this series, we just got overly complicated. I suggest simple replacement of Aurelien's and Magnus' name with Yoshimori's, with possible exception of addition of the line: +F: include/hw/sh4/sh_intc.h And that's it! And let's finish this unpleasant episode! Regards, Aleksandar P.S. I now expect that Thomas will complain about my usage of the words "unpleasant" and "overly". > MAINTAINERS | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 49d90c70de..a012d9b74e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1250,14 +1250,15 @@ SH4 Machines > ------------ > R2D > M: Magnus Damm <magnus.damm@gmail.com> > -S: Maintained > +S: Orphan > F: hw/sh4/r2d.c > F: hw/intc/sh_intc.c > F: hw/timer/sh_timer.c > +F: include/hw/sh4/sh_intc.h > > Shix > M: Magnus Damm <magnus.damm@gmail.com> > -S: Odd Fixes > +S: Orphan > F: hw/sh4/shix.c > > SPARC Machines > -- > 2.21.3 > >
diff --git a/MAINTAINERS b/MAINTAINERS index 49d90c70de..a012d9b74e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1250,14 +1250,15 @@ SH4 Machines ------------ R2D M: Magnus Damm <magnus.damm@gmail.com> -S: Maintained +S: Orphan F: hw/sh4/r2d.c F: hw/intc/sh_intc.c F: hw/timer/sh_timer.c +F: include/hw/sh4/sh_intc.h Shix M: Magnus Damm <magnus.damm@gmail.com> -S: Odd Fixes +S: Orphan F: hw/sh4/shix.c SPARC Machines
Last commit from Magnus Damm is fc8e320ef583, which date is Fri Nov 13 2009. As nobody else seems to care about the patches posted [*] related to the R2D and Shix machines, mark them orphan. Many thanks to Magnus for his substantial contributions to QEMU, and for introducing these SH4 based machine! [*] https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08519.html Cc: Magnus Damm <magnus.damm@gmail.com> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- MAINTAINERS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)