diff mbox series

[v2,1/5] target/tricore: Don't save pc in generate_qemu_excp

Message ID 20200529072148.284037-2-kbastian@mail.uni-paderborn.de
State New
Headers show
Series TriCore fixes and gdbstub | expand

Commit Message

Bastian Koppelmann May 29, 2020, 7:21 a.m. UTC 
EXCP_DEBUG is the only user. If we encounter a jump in tricore-gdb it's
target was overwritten by generate_qemu_excp() and we would never leave.

Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
 target/tricore/translate.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Richard Henderson June 1, 2020, 7:48 p.m. UTC | #1 
On 5/29/20 12:21 AM, Bastian Koppelmann wrote:
> EXCP_DEBUG is the only user. If we encounter a jump in tricore-gdb it's
> target was overwritten by generate_qemu_excp() and we would never leave.
> 
> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> ---
>  target/tricore/translate.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~
diff mbox series

Patch

diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index 609d75ae8a..65a33e5ad8 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -3264,7 +3264,6 @@  static void generate_trap(DisasContext *ctx, int class, int tin)
 static void generate_qemu_excp(DisasContext *ctx, int excp)
 {
     TCGv_i32 tmp = tcg_const_i32(excp);
-    gen_save_pc(ctx->base.pc_next);
     gen_helper_qemu_excp(cpu_env, tmp);
     ctx->base.is_jmp = DISAS_NORETURN;
     tcg_temp_free(tmp);