| Message ID | 20200527053809.356168-1-david@gibson.dropbear.id.au |
|---|---|
| State | New |
| Headers | show |
Patchew URL: https://patchew.org/QEMU/20200527053809.356168-1-david@gibson.dropbear.id.au/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20200527053809.356168-1-david@gibson.dropbear.id.au
Subject: [PULL 00/15] ppc-for-5.1 queue 20200527
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
d397549 vfio/nvlink: Remove exec permission to avoid SELinux AVCs
d4bfe48 target/ppc: Fix argument to ppc_radix64_partition_scoped_xlate() again
0d637cc hw/nvram/mac_nvram: Convert debug printf()s to trace events
026de79 hw/pci-bridge/dec: Remove dead debug code
8ce2429 target/ppc: Don't update radix PTE R/C bits with gdbstub
480bb39 target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate()
0743dd0 target/ppc: Add missing braces in ppc_radix64_partition_scoped_xlate()
3f0ffb4 target/ppc: Don't initialize some local variables in ppc_radix64_xlate()
a043ed5 target/ppc: Pass const pointer to ppc_radix64_get_fully_qualified_addr()
1496e1d target/ppc: Pass const pointer to ppc_radix64_get_prot_amr()
5af285b ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2
5ae07f3 target/ppc: Add support for scv and rfscv instructions
cbc4578 target/ppc: Untabify excp_helper.c
43ec675 ppc/spapr: add a POWER10 CPU model
5824cd4 ppc/pnv: Fix NMI system reset SRR1 value
=== OUTPUT BEGIN ===
1/15 Checking commit 5824cd4e989b (ppc/pnv: Fix NMI system reset SRR1 value)
ERROR: line over 90 characters
#43: FILE: hw/ppc/pnv.c:1994:
+ warn_report("ppc_cpu_do_system_reset does not set system reset wakeup reason");
total: 1 errors, 0 warnings, 32 lines checked
Patch 1/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/15 Checking commit 43ec6753d2c0 (ppc/spapr: add a POWER10 CPU model)
3/15 Checking commit cbc4578bc1b3 (target/ppc: Untabify excp_helper.c)
4/15 Checking commit 5ae07f3461d4 (target/ppc: Add support for scv and rfscv instructions)
5/15 Checking commit 5af285b558e5 (ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2)
6/15 Checking commit 1496e1d11c1f (target/ppc: Pass const pointer to ppc_radix64_get_prot_amr())
7/15 Checking commit a043ed5475f8 (target/ppc: Pass const pointer to ppc_radix64_get_fully_qualified_addr())
8/15 Checking commit 3f0ffb47931f (target/ppc: Don't initialize some local variables in ppc_radix64_xlate())
9/15 Checking commit 0743dd041579 (target/ppc: Add missing braces in ppc_radix64_partition_scoped_xlate())
10/15 Checking commit 480bb3969730 (target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate())
11/15 Checking commit 8ce24299a6e4 (target/ppc: Don't update radix PTE R/C bits with gdbstub)
12/15 Checking commit 026de790313f (hw/pci-bridge/dec: Remove dead debug code)
13/15 Checking commit 0d637cc2e445 (hw/nvram/mac_nvram: Convert debug printf()s to trace events)
14/15 Checking commit d4bfe48202fb (target/ppc: Fix argument to ppc_radix64_partition_scoped_xlate() again)
15/15 Checking commit d397549a63a8 (vfio/nvlink: Remove exec permission to avoid SELinux AVCs)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200527053809.356168-1-david@gibson.dropbear.id.au/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Wed, 27 May 2020 at 06:38, David Gibson <david@gibson.dropbear.id.au> wrote: > > The following changes since commit ddc760832fa8cf5e93b9d9e6e854a5114ac63510: > > Merge remote-tracking branch 'remotes/gkurz/tags/9p-next-2020-05-26' into staging (2020-05-26 14:05:53 +0100) > > are available in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-5.1-20200527 > > for you to fetch changes up to 9c7c0407028355ca83349b8a60fddfad46f2ebd8: > > vfio/nvlink: Remove exec permission to avoid SELinux AVCs (2020-05-27 15:29:36 +1000) > > ---------------------------------------------------------------- > ppc patch queue 2020-05-27 > > Here's the next pull request for qemu-5.1. It includes: > * Support for the scv and rfscv POWER9 instructions in TCG > * Support for the new SPAPR_LMB_FLAGS_HOTREMOVABLE flag, which > provides a way for guests to know memory which should be removable > (so the guest can avoid putting immovable allocations there). > * Some fixes for the recently added partition scope radix translation > in softmmu > * Assorted minor fixes and cleanups > > It includes one patch to avoid a clash with SELinux when using NVLink > VFIO devices. That's not technically within the files under my > maintainership, but it is in a section of the VFIO quirks code that's > specific to the POWER-only NVLink devices, and has an ack from Alex > Williamson. Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1 for any user-visible changes. -- PMM
The following changes since commit ddc760832fa8cf5e93b9d9e6e854a5114ac63510: Merge remote-tracking branch 'remotes/gkurz/tags/9p-next-2020-05-26' into staging (2020-05-26 14:05:53 +0100) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-5.1-20200527 for you to fetch changes up to 9c7c0407028355ca83349b8a60fddfad46f2ebd8: vfio/nvlink: Remove exec permission to avoid SELinux AVCs (2020-05-27 15:29:36 +1000) ---------------------------------------------------------------- ppc patch queue 2020-05-27 Here's the next pull request for qemu-5.1. It includes: * Support for the scv and rfscv POWER9 instructions in TCG * Support for the new SPAPR_LMB_FLAGS_HOTREMOVABLE flag, which provides a way for guests to know memory which should be removable (so the guest can avoid putting immovable allocations there). * Some fixes for the recently added partition scope radix translation in softmmu * Assorted minor fixes and cleanups It includes one patch to avoid a clash with SELinux when using NVLink VFIO devices. That's not technically within the files under my maintainership, but it is in a section of the VFIO quirks code that's specific to the POWER-only NVLink devices, and has an ack from Alex Williamson. ---------------------------------------------------------------- Cédric Le Goater (1): ppc/spapr: add a POWER10 CPU model Greg Kurz (8): target/ppc: Untabify excp_helper.c target/ppc: Pass const pointer to ppc_radix64_get_prot_amr() target/ppc: Pass const pointer to ppc_radix64_get_fully_qualified_addr() target/ppc: Don't initialize some local variables in ppc_radix64_xlate() target/ppc: Add missing braces in ppc_radix64_partition_scoped_xlate() target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate() target/ppc: Don't update radix PTE R/C bits with gdbstub target/ppc: Fix argument to ppc_radix64_partition_scoped_xlate() again Leonardo Bras (2): ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2 vfio/nvlink: Remove exec permission to avoid SELinux AVCs Nicholas Piggin (2): ppc/pnv: Fix NMI system reset SRR1 value target/ppc: Add support for scv and rfscv instructions Philippe Mathieu-Daudé (2): hw/pci-bridge/dec: Remove dead debug code hw/nvram/mac_nvram: Convert debug printf()s to trace events hw/nvram/mac_nvram.c | 17 +----- hw/nvram/trace-events | 4 ++ hw/pci-bridge/dec.c | 10 ---- hw/ppc/pnv.c | 26 ++++++-- hw/ppc/spapr.c | 3 +- hw/ppc/spapr_cpu_core.c | 1 + hw/vfio/pci-quirks.c | 4 +- include/hw/ppc/spapr.h | 1 + linux-user/ppc/cpu_loop.c | 1 + target/ppc/cpu.h | 28 ++++++++- target/ppc/excp_helper.c | 130 +++++++++++++++++++++++++++------------- target/ppc/helper.h | 1 + target/ppc/mmu-radix64.c | 53 +++++++++------- target/ppc/mmu-radix64.h | 4 +- target/ppc/translate.c | 53 +++++++++++++++- target/ppc/translate_init.inc.c | 3 +- 16 files changed, 237 insertions(+), 102 deletions(-)