From patchwork Mon May 25 11:23:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1297289 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=fWtk1o+s; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49VvrG2nmKz9sRW for ; Mon, 25 May 2020 21:24:30 +1000 (AEST) Received: from localhost ([::1]:51292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdBDX-0000ug-WA for incoming@patchwork.ozlabs.org; Mon, 25 May 2020 07:24:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdBD9-0000qe-KV; Mon, 25 May 2020 07:24:03 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:42219) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdBD8-0000pw-Tr; Mon, 25 May 2020 07:24:03 -0400 Received: by mail-wr1-x441.google.com with SMTP id s8so16722138wrt.9; Mon, 25 May 2020 04:24:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T2fFw/3ecGdUBJpHTI/rjWpVW7MRtnqzt7F58rWYdgA=; b=fWtk1o+sZqyNBzm6LFIIfkZOaAz9pm2D5LIGFDda7OJzZ/A5GzFnFTCjpXkLw72yPP WXmclKnXy4DUzT0/R5aFbmLIqyNs22Lf1/DFFFN+06I1jLO7ySU08fZ2+ijqkplGQ3Wk ZgVy7Q7a5iKwXdZsml1ftEBja6JaMvnabnIA5NISQLd5pDKEuVpvijS7ei009ayeJLeE z32iYXj/UlcDJn9YZHMqljoysiCU0Dt/yxwtVYGMXDa3P6MTcIVn7s1zSEyqexs0Uza/ DpWCqBgUwrDVqqQECk1iHOjHcDqzw4z+u3G00Y0fjbwvfYljYpK6JpqAKfsEF41Kb9de I7Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=T2fFw/3ecGdUBJpHTI/rjWpVW7MRtnqzt7F58rWYdgA=; b=g2RIcDaCAnQcu/BiWHnZJNJltiwHaRC0HmpVHm9Bikm9BLZ53TCr+6pywwQZllZipY gE7Thh4VRF2EU5iPfEXx4uWtiCeYZJBWvdhnwQxZWe6/ufnp8ky0kfUgCUwdIC0MX8mA fCyCsW99EqlXWg8YyZLexhqfYeskO1Hb5URtZ7hMeBoV0cYI/Vj0Qh+Ol3ovzPrY0QrW AcnlYvn6WTADj+8wd9lN32AKsbFQRtc1aJbGpkKYPVvBPD5p90DYIJ3cKn/AkYQXv1jc mG6PIxE42NPLvEEtoxduI9NbrnxeAttjzFVbl0A0RAlnI6t5vOo51EH4VUbKzk3/568U dDsg== X-Gm-Message-State: AOAM533Fd92hJ/V0jpAVKj2Ebbo9zbbO1j6v5ZlVb2x/1jJ2+HYyS+Zt 4cmoBVqPnTrAdDa1rW+F1WLwZzPekOQ= X-Google-Smtp-Source: ABdhPJwHFbDJddx3JhGgAkJIbabXkEDdSaTnrDZ4W+ZIzlMGKsSS/yXYPBxx08QA0Q8/fqvRvJjs6w== X-Received: by 2002:a5d:6444:: with SMTP id d4mr13369464wrw.239.1590405841073; Mon, 25 May 2020 04:24:01 -0700 (PDT) Received: from localhost.localdomain (71.red-88-21-204.staticip.rima-tde.net. [88.21.204.71]) by smtp.gmail.com with ESMTPSA id h196sm10715635wme.22.2020.05.25.04.24.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2020 04:24:00 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 3/3] hw/display/vmware_vga: Let the PCI device own its I/O MemoryRegion Date: Mon, 25 May 2020 13:23:54 +0200 Message-Id: <20200525112354.10445-4-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200525112354.10445-1-f4bug@amsat.org> References: <20200525112354.10445-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::441; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x441.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dmitry Fleytman , qemu-trivial@nongnu.org, Michael Tokarev , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Laurent Vivier , Gerd Hoffmann Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" To avoid the orphan I/O memory region being added in the /unattached QOM container, register the PCI device as its owner. Signed-off-by: Philippe Mathieu-Daudé --- RFC: This might break migration --- hw/display/vmware_vga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c index 5c0fc49d9d..2579f6b218 100644 --- a/hw/display/vmware_vga.c +++ b/hw/display/vmware_vga.c @@ -1306,7 +1306,7 @@ static void pci_vmsvga_realize(PCIDevice *dev, Error **errp) dev->config[PCI_LATENCY_TIMER] = 0x40; dev->config[PCI_INTERRUPT_LINE] = 0xff; /* End */ - memory_region_init_io(&s->io_bar, NULL, &vmsvga_io_ops, &s->chip, + memory_region_init_io(&s->io_bar, OBJECT(dev), &vmsvga_io_ops, &s->chip, "vmsvga-io", 0x10); memory_region_set_flush_coalesced(&s->io_bar); pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_IO, &s->io_bar);