From patchwork Fri May 22 16:37:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1296383 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TodHyOan; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49TC0k0G5Dz9sSw for ; Sat, 23 May 2020 02:40:54 +1000 (AEST) Received: from localhost ([::1]:56302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcAj5-0001x0-MY for incoming@patchwork.ozlabs.org; Fri, 22 May 2020 12:40:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcAgw-0006zi-JO for qemu-devel@nongnu.org; Fri, 22 May 2020 12:38:38 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:44835 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jcAgu-0002WF-RR for qemu-devel@nongnu.org; Fri, 22 May 2020 12:38:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590165515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GPfSgBN6V2tVMS8P3LJc7AXq2ATI7aQPyqGZHft5RHs=; b=TodHyOanITJdSSb2HHhyrv8ia4NCf12pWFxvGaYFRCWAhLWhkaxSL8uPmNzHABTLbFyilh ArpHtbV/QB7EIrgGVaYXkpzG+vwk6P7fPvs7xRP88eJ9gevCHjzqDMTCO5/Vi1YleqwYwH pU2cEgzZsvRQ/jbON2E6ugWe2tSyqBU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-47-TBoPoNhbO2KyAySLTkyN1A-1; Fri, 22 May 2020 12:38:34 -0400 X-MC-Unique: TBoPoNhbO2KyAySLTkyN1A-1 Received: by mail-wm1-f69.google.com with SMTP id p24so778898wmc.1 for ; Fri, 22 May 2020 09:38:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GPfSgBN6V2tVMS8P3LJc7AXq2ATI7aQPyqGZHft5RHs=; b=b75YR0VXwE2kAWXhV9fOWaW2gnvWrVzNJk6CEn9gcvbRkgHgNKdQYwIuthHuPKT8Ip HCO1bRrtQvIxsyKho0toBZW+4X340O2A79+SAdeiqE4mxJMmskwtFkV5m2q+7jZw+AA3 tze7JjI36NKH7lxB2GfZ3dF5SH85NrlSB0ZQGIXTz/z9mgWbA+iQuxcV1wHzSS9ybSqv D83UPGmaXDMZ0jx7oIkSsVqmITXRHAwbN5Pbhnyg+y++ZOcCmg4pr8AqZalR6/G8tTco ukW395Zr23v3f5ql0xj800IixlqypcQGDqxKO+RsABK9u+FpTT4jflwZi70+u4Gux1/E xTIw== X-Gm-Message-State: AOAM533c3XIZraM/CZFjK6diuid8uutKcNVTMXDubq4gQO+MdtSqSr9t /2EaHYdAro3i9v+SYB66FCVPg+5mstD16dk6hd+ln3hNGxEu/P5kpjvt9Hvl7yIM5k9jtkLqstr 9cdI/TQQcQF8ZSmY= X-Received: by 2002:a5d:5710:: with SMTP id a16mr3908144wrv.209.1590165512812; Fri, 22 May 2020 09:38:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZupFUNt2hW8Y0TWlvCF+LCTOs7rLwEc7n9VszcVJIZdGI2nsYz7n/5zPGagJLYybYksrfgw== X-Received: by 2002:a5d:5710:: with SMTP id a16mr3908130wrv.209.1590165512676; Fri, 22 May 2020 09:38:32 -0700 (PDT) Received: from localhost.localdomain (17.red-88-21-202.staticip.rima-tde.net. [88.21.202.17]) by smtp.gmail.com with ESMTPSA id d9sm9930474wmd.10.2020.05.22.09.38.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2020 09:38:32 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v4 07/11] Makefile: Write MINIKCONF variables as one entry per line Date: Fri, 22 May 2020 18:37:55 +0200 Message-Id: <20200522163759.11480-8-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200522163759.11480-1-philmd@redhat.com> References: <20200522163759.11480-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=207.211.31.81; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/22 11:12:54 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Having one entry per line helps reviews/refactors. As we are going to modify the MINIKCONF variables, split them now to ease further review. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 6c9d718b2c..7666f81e8a 100644 --- a/Makefile +++ b/Makefile @@ -418,12 +418,15 @@ MINIKCONF_ARGS = \ CONFIG_LINUX=$(CONFIG_LINUX) \ CONFIG_PVRDMA=$(CONFIG_PVRDMA) -MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host $(SRC_PATH)/hw/Kconfig -MINIKCONF_DEPS = $(MINIKCONF_INPUTS) $(wildcard $(SRC_PATH)/hw/*/Kconfig) +MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host \ + $(SRC_PATH)/hw/Kconfig +MINIKCONF_DEPS = $(MINIKCONF_INPUTS) \ + $(wildcard $(SRC_PATH)/hw/*/Kconfig) MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py $(SUBDIR_DEVICES_MAK): %/config-devices.mak: default-configs/%.mak $(MINIKCONF_DEPS) $(BUILD_DIR)/config-host.mak - $(call quiet-command, $(MINIKCONF) $(MINIKCONF_ARGS) > $@.tmp, "GEN", "$@.tmp") + $(call quiet-command, $(MINIKCONF) $(MINIKCONF_ARGS) \ + > $@.tmp, "GEN", "$@.tmp") $(call quiet-command, if test -f $@; then \ if cmp -s $@.old $@; then \ mv $@.tmp $@; \