Message ID | 20200519182024.14638-6-philmd@redhat.com |
---|---|
State | New |
Headers | show |
Series | fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites | expand |
On 05/19/20 20:20, Philippe Mathieu-Daudé wrote: > Since our format is consumable by the fw_cfg device, > we can implement the FW_CFG_DATA_GENERATOR interface. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > crypto/tls-cipher-suites.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) (1) s/product/produce/ in the subject line. This patch looks OK to me otherwise (but I don't feel confident enough to give an R-b): Acked-by: Laszlo Ersek <lersek@redhat.com> Thanks Laszlo > > diff --git a/crypto/tls-cipher-suites.c b/crypto/tls-cipher-suites.c > index c6c51359bd..11872783eb 100644 > --- a/crypto/tls-cipher-suites.c > +++ b/crypto/tls-cipher-suites.c > @@ -14,6 +14,7 @@ > #include "qemu/error-report.h" > #include "crypto/tlscreds.h" > #include "crypto/tls-cipher-suites.h" > +#include "hw/nvram/fw_cfg.h" > > static void parse_cipher_suites(QCryptoTLSCipherSuites *s, > const char *priority_name, Error **errp) > @@ -101,11 +102,28 @@ static void qcrypto_tls_cipher_suites_finalize(Object *obj) > g_free(s->cipher_list); > } > > +static const void *qcrypto_tls_cipher_suites_get_data(Object *obj) > +{ > + QCryptoTLSCipherSuites *s = QCRYPTO_TLS_CIPHER_SUITES(obj); > + > + return s->cipher_list; > +} > + > +static size_t qcrypto_tls_cipher_suites_get_length(Object *obj) > +{ > + QCryptoTLSCipherSuites *s = QCRYPTO_TLS_CIPHER_SUITES(obj); > + > + return s->cipher_count * sizeof(IANA_TLS_CIPHER); > +} > + > static void qcrypto_tls_cipher_suites_class_init(ObjectClass *oc, void *data) > { > UserCreatableClass *ucc = USER_CREATABLE_CLASS(oc); > + FWCfgDataGeneratorClass *fwgc = FW_CFG_DATA_GENERATOR_CLASS(oc); > > ucc->complete = qcrypto_tls_cipher_suites_complete; > + fwgc->get_data = qcrypto_tls_cipher_suites_get_data; > + fwgc->get_length = qcrypto_tls_cipher_suites_get_length; > > object_class_property_add_bool(oc, "verbose", > qcrypto_tls_cipher_suites_get_verbose, > @@ -121,6 +139,7 @@ static const TypeInfo qcrypto_tls_cipher_suites_info = { > .class_init = qcrypto_tls_cipher_suites_class_init, > .interfaces = (InterfaceInfo[]) { > { TYPE_USER_CREATABLE }, > + { TYPE_FW_CFG_DATA_GENERATOR_INTERFACE }, > { } > } > }; >
diff --git a/crypto/tls-cipher-suites.c b/crypto/tls-cipher-suites.c index c6c51359bd..11872783eb 100644 --- a/crypto/tls-cipher-suites.c +++ b/crypto/tls-cipher-suites.c @@ -14,6 +14,7 @@ #include "qemu/error-report.h" #include "crypto/tlscreds.h" #include "crypto/tls-cipher-suites.h" +#include "hw/nvram/fw_cfg.h" static void parse_cipher_suites(QCryptoTLSCipherSuites *s, const char *priority_name, Error **errp) @@ -101,11 +102,28 @@ static void qcrypto_tls_cipher_suites_finalize(Object *obj) g_free(s->cipher_list); } +static const void *qcrypto_tls_cipher_suites_get_data(Object *obj) +{ + QCryptoTLSCipherSuites *s = QCRYPTO_TLS_CIPHER_SUITES(obj); + + return s->cipher_list; +} + +static size_t qcrypto_tls_cipher_suites_get_length(Object *obj) +{ + QCryptoTLSCipherSuites *s = QCRYPTO_TLS_CIPHER_SUITES(obj); + + return s->cipher_count * sizeof(IANA_TLS_CIPHER); +} + static void qcrypto_tls_cipher_suites_class_init(ObjectClass *oc, void *data) { UserCreatableClass *ucc = USER_CREATABLE_CLASS(oc); + FWCfgDataGeneratorClass *fwgc = FW_CFG_DATA_GENERATOR_CLASS(oc); ucc->complete = qcrypto_tls_cipher_suites_complete; + fwgc->get_data = qcrypto_tls_cipher_suites_get_data; + fwgc->get_length = qcrypto_tls_cipher_suites_get_length; object_class_property_add_bool(oc, "verbose", qcrypto_tls_cipher_suites_get_verbose, @@ -121,6 +139,7 @@ static const TypeInfo qcrypto_tls_cipher_suites_info = { .class_init = qcrypto_tls_cipher_suites_class_init, .interfaces = (InterfaceInfo[]) { { TYPE_USER_CREATABLE }, + { TYPE_FW_CFG_DATA_GENERATOR_INTERFACE }, { } } };
Since our format is consumable by the fw_cfg device, we can implement the FW_CFG_DATA_GENERATOR interface. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- crypto/tls-cipher-suites.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)