diff mbox series

qom/object: simplify type_initialize_interface()

Message ID 20200512182501.2300530-1-masahiroy@kernel.org
State New
Headers show
Series qom/object: simplify type_initialize_interface() | expand

Commit Message

Masahiro Yamada May 12, 2020, 6:25 p.m. UTC
iface_impl->class is the same as new_iface. Make it more readable.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 qom/object.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Paolo Bonzini May 21, 2020, 2:45 p.m. UTC | #1
On 12/05/20 20:25, Masahiro Yamada wrote:
> iface_impl->class is the same as new_iface. Make it more readable.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  qom/object.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/qom/object.c b/qom/object.c
> index 9d1a918e42..75c628591d 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -262,8 +262,7 @@ static void type_initialize_interface(TypeImpl *ti, TypeImpl *interface_type,
>      new_iface->concrete_class = ti->class;
>      new_iface->interface_type = interface_type;
>  
> -    ti->class->interfaces = g_slist_append(ti->class->interfaces,
> -                                           iface_impl->class);
> +    ti->class->interfaces = g_slist_append(ti->class->interfaces, new_iface);
>  }
>  
>  static void object_property_free(gpointer data)
> 

Queued, thanks.

Paolo
diff mbox series

Patch

diff --git a/qom/object.c b/qom/object.c
index 9d1a918e42..75c628591d 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -262,8 +262,7 @@  static void type_initialize_interface(TypeImpl *ti, TypeImpl *interface_type,
     new_iface->concrete_class = ti->class;
     new_iface->interface_type = interface_type;
 
-    ti->class->interfaces = g_slist_append(ti->class->interfaces,
-                                           iface_impl->class);
+    ti->class->interfaces = g_slist_append(ti->class->interfaces, new_iface);
 }
 
 static void object_property_free(gpointer data)