diff mbox series

[1/2] vl.c: run preconfig loop before creating default RAM backend

Message ID 20200511141103.43768-2-imammedo@redhat.com
State New
Headers show
Series make -M memory-backend and -numa memdev mutually exclusive | expand

Commit Message

Igor Mammedov May 11, 2020, 2:11 p.m. UTC
Default RAM backend depends on numa_uses_legacy_mem(), which is
infulenced by -numa options on CLI or set-numa-node QMP command
at preconfig time. If QEMU is started with  '-preconfig'
without -numa, it will lead to creating default RAM backend
even if later set-numa-node is used to assing RAM to NUMA nodes
using 'memdev' NUMA option.
That at best will waste RAM object created by default and with
next patch adding a check to prevent usage of conflicting
 '-M memory-backend' and '-numa memdev'
options, it will make QEMU error out if user tries to configure
NUMA at preconfig time with memdev option, making set-numa-node

To fix issue, move preconfig loop before default RAM backend is
created, so that numa_uses_legacy_mem() would take into account
effects of set-numa-node commands executed at preconfig time.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
 softmmu/vl.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox series


diff --git a/softmmu/vl.c b/softmmu/vl.c
index afd2615fb3..8e806c9b25 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -4333,12 +4333,13 @@  void qemu_init(int argc, char **argv, char **envp)
+    /* do monitor/qmp handling at preconfig state if requested */
+    qemu_main_loop();
     if (machine_class->default_ram_id && current_machine->ram_size &&
         numa_uses_legacy_mem() && !current_machine->ram_memdev_id) {
         create_default_memdev(current_machine, mem_path);
-    /* do monitor/qmp handling at preconfig state if requested */
-    qemu_main_loop();