diff mbox series

[4/6] block/block: Document BlockSizes fields

Message ID 20200504094641.4963-5-philmd@redhat.com
State New
Headers show
Series block/nvme: Align block pages queue to host page size | expand

Commit Message

Philippe Mathieu-Daudé May 4, 2020, 9:46 a.m. UTC 
As it is not obvious for a block neophyte what means
the 'log' value, document it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 include/block/block.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stefan Hajnoczi May 7, 2020, 8:58 a.m. UTC | #1 
On Mon, May 04, 2020 at 11:46:39AM +0200, Philippe Mathieu-Daudé wrote:
> As it is not obvious for a block neophyte what means
> the 'log' value, document it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  include/block/block.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
diff mbox series

Patch

diff --git a/include/block/block.h b/include/block/block.h
index c57fdecf9a..94517c92b6 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -86,8 +86,8 @@  typedef enum {
 } BdrvRequestFlags;
 
 typedef struct BlockSizes {
-    uint32_t phys;
-    uint32_t log;
+    uint32_t phys;  /* physical block size */
+    uint32_t log;   /* logical block size */
 } BlockSizes;
 
 typedef struct HDGeometry {