| Message ID | 20200501111505.4225-5-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | testing/next updates | expand |
On 5/1/20 1:15 PM, Alex Bennée wrote: > This seems to be timing out quite often and occasionally running out > of disk space. Relegate it to light duties. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index 49267b73b3..fe708792ca 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -458,7 +458,7 @@ jobs: > - genisoimage > env: > - TEST_CMD="make check check-tcg V=1" > - - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS},ppc64le-linux-user" > + - CONFIG="--disable-containers --target-list=ppc64-softmmu,ppc64le-linux-user" Cc'ing David, since I'm not sure about this one... Maybe split as we did with other jobs? > > - name: "[s390x] GCC check-tcg" > arch: s390x >
Philippe Mathieu-Daudé <philmd@redhat.com> writes: > On 5/1/20 1:15 PM, Alex Bennée wrote: >> This seems to be timing out quite often and occasionally running out >> of disk space. Relegate it to light duties. >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >> --- >> .travis.yml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> diff --git a/.travis.yml b/.travis.yml >> index 49267b73b3..fe708792ca 100644 >> --- a/.travis.yml >> +++ b/.travis.yml >> @@ -458,7 +458,7 @@ jobs: >> - genisoimage >> env: >> - TEST_CMD="make check check-tcg V=1" >> - - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS},ppc64le-linux-user" >> + - CONFIG="--disable-containers --target-list=ppc64-softmmu,ppc64le-linux-user" > > Cc'ing David, since I'm not sure about this one... Maybe split as we > did with other jobs? We could do but it lengthens the run even more. Having ppc64le-linux-user ensures we exercise the majority of the TCG code generator so I think the only area we aren't covering is the PPC TCG softmmu backend. We could add another softmmu target but I didn't want to play favourites. > >> - name: "[s390x] GCC check-tcg" >> arch: s390x >>
On 5/1/20 4:15 AM, Alex Bennée wrote: > This seems to be timing out quite often and occasionally running out > of disk space. Relegate it to light duties. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On Fri, May 01, 2020 at 01:58:47PM +0100, Alex Bennée wrote: > > Philippe Mathieu-Daudé <philmd@redhat.com> writes: > > > On 5/1/20 1:15 PM, Alex Bennée wrote: > >> This seems to be timing out quite often and occasionally running out > >> of disk space. Relegate it to light duties. > >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > >> --- > >> .travis.yml | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> diff --git a/.travis.yml b/.travis.yml > >> index 49267b73b3..fe708792ca 100644 > >> --- a/.travis.yml > >> +++ b/.travis.yml > >> @@ -458,7 +458,7 @@ jobs: > >> - genisoimage > >> env: > >> - TEST_CMD="make check check-tcg V=1" > >> - - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS},ppc64le-linux-user" > >> + - CONFIG="--disable-containers --target-list=ppc64-softmmu,ppc64le-linux-user" > > > > Cc'ing David, since I'm not sure about this one... Maybe split as we > > did with other jobs? > > We could do but it lengthens the run even more. Having > ppc64le-linux-user ensures we exercise the majority of the TCG code > generator so I think the only area we aren't covering is the PPC TCG > softmmu backend. We could add another softmmu target but I didn't want > to play favourites. Hrm. I'd prefer not to drop this coverage if we can avoid it. What we're not testing with the proposed patch is TCG generation for a ppc host but a non-ppc target. e.g. if the x86 or ARM target side generates some pattern of TCG ops that's very rare for the ppc target, and is buggy in the ppc host side. I'll grant you, bugs that specific aren't particularly likely. But, such a regression would also be very unlikely to be caught by ad-hoc testing, so it would be good to have at least some coverage in Travis.
On 5/3/20 7:10 PM, David Gibson wrote: >>>> - TEST_CMD="make check check-tcg V=1" >>>> - - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS},ppc64le-linux-user" >>>> + - CONFIG="--disable-containers --target-list=ppc64-softmmu,ppc64le-linux-user" >>> >>> Cc'ing David, since I'm not sure about this one... Maybe split as we >>> did with other jobs? ... > Hrm. I'd prefer not to drop this coverage if we can avoid it. What > we're not testing with the proposed patch is TCG generation for a ppc > host but a non-ppc target. e.g. if the x86 or ARM target side generates > some pattern of TCG ops that's very rare for the ppc target, and is > buggy in the ppc host side. Are we actually testing those here? As far as I can see, we're not installing any cross-compilers here, so we're not building any non-ppc binaries. Nor are we running check-acceptance which would download pre-built foreign binaries. r~
Richard Henderson <richard.henderson@linaro.org> writes: > On 5/3/20 7:10 PM, David Gibson wrote: >>>>> - TEST_CMD="make check check-tcg V=1" >>>>> - - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS},ppc64le-linux-user" >>>>> + - CONFIG="--disable-containers --target-list=ppc64-softmmu,ppc64le-linux-user" >>>> >>>> Cc'ing David, since I'm not sure about this one... Maybe split as we >>>> did with other jobs? > ... >> Hrm. I'd prefer not to drop this coverage if we can avoid it. What >> we're not testing with the proposed patch is TCG generation for a ppc >> host but a non-ppc target. e.g. if the x86 or ARM target side generates >> some pattern of TCG ops that's very rare for the ppc target, and is >> buggy in the ppc host side. > > Are we actually testing those here? As far as I can see, we're not installing > any cross-compilers here, so we're not building any non-ppc binaries. Nor are > we running check-acceptance which would download pre-built foreign > binaries. We are testing the very minimal boot stubs that each -system binary has in qtest but they are hardly going to be exercising the majority of the TCG. Basically the $SELF-linux-user is going to be exercising more of the TCG than anything else. > > > r~
On Mon, May 04, 2020 at 08:48:46PM +0100, Alex Bennée wrote: > > Richard Henderson <richard.henderson@linaro.org> writes: > > > On 5/3/20 7:10 PM, David Gibson wrote: > >>>>> - TEST_CMD="make check check-tcg V=1" > >>>>> - - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS},ppc64le-linux-user" > >>>>> + - CONFIG="--disable-containers --target-list=ppc64-softmmu,ppc64le-linux-user" > >>>> > >>>> Cc'ing David, since I'm not sure about this one... Maybe split as we > >>>> did with other jobs? > > ... > >> Hrm. I'd prefer not to drop this coverage if we can avoid it. What > >> we're not testing with the proposed patch is TCG generation for a ppc > >> host but a non-ppc target. e.g. if the x86 or ARM target side generates > >> some pattern of TCG ops that's very rare for the ppc target, and is > >> buggy in the ppc host side. > > > > Are we actually testing those here? As far as I can see, we're not installing > > any cross-compilers here, so we're not building any non-ppc binaries. Nor are > > we running check-acceptance which would download pre-built foreign > > binaries. > > We are testing the very minimal boot stubs that each -system binary has > in qtest but they are hardly going to be exercising the majority of the > TCG. Basically the $SELF-linux-user is going to be exercising more of > the TCG than anything else. Oh, good points. Go ahead then. In fact we should probably do that for all the check-tcg builds that don't install cross compilers.
diff --git a/.travis.yml b/.travis.yml index 49267b73b3..fe708792ca 100644 --- a/.travis.yml +++ b/.travis.yml @@ -458,7 +458,7 @@ jobs: - genisoimage env: - TEST_CMD="make check check-tcg V=1" - - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS},ppc64le-linux-user" + - CONFIG="--disable-containers --target-list=ppc64-softmmu,ppc64le-linux-user" - name: "[s390x] GCC check-tcg" arch: s390x
This seems to be timing out quite often and occasionally running out of disk space. Relegate it to light duties. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)