| Message ID | 20200430190122.4592-2-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | gdbstub/next | expand |
On 4/30/20 9:01 PM, Alex Bennée wrote: > As gdb will generally be talking to "foreign" guests lets use that if > we can. Otherwise the chances of gdb barfing are considerably higher. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 23b5e93752..c58787100f 100755 > --- a/configure > +++ b/configure > @@ -303,7 +303,7 @@ libs_qga="" > debug_info="yes" > stack_protector="" > use_containers="yes" > -gdb_bin=$(command -v "gdb") > +gdb_bin=$(command -v "gdb-multiarch" || command -v "gdb") > > if test -e "$source_path/.git" > then > This was also already reviewed: https://www.mail-archive.com/qemu-devel@nongnu.org/msg697748.html There seem to be a problem in your workflow. Again: Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Philippe Mathieu-Daudé <philmd@redhat.com> writes: > On 4/30/20 9:01 PM, Alex Bennée wrote: >> As gdb will generally be talking to "foreign" guests lets use that if >> we can. Otherwise the chances of gdb barfing are considerably higher. >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >> --- >> configure | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> diff --git a/configure b/configure >> index 23b5e93752..c58787100f 100755 >> --- a/configure >> +++ b/configure >> @@ -303,7 +303,7 @@ libs_qga="" >> debug_info="yes" >> stack_protector="" >> use_containers="yes" >> -gdb_bin=$(command -v "gdb") >> +gdb_bin=$(command -v "gdb-multiarch" || command -v "gdb") >> if test -e "$source_path/.git" >> then >> > > This was also already reviewed: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg697748.html > > There seem to be a problem in your workflow. Ahh I was only calling: #+CALL: check-and-fix-missing-signoffs() in my PR workflow... fixed now thanks
diff --git a/configure b/configure index 23b5e93752..c58787100f 100755 --- a/configure +++ b/configure @@ -303,7 +303,7 @@ libs_qga="" debug_info="yes" stack_protector="" use_containers="yes" -gdb_bin=$(command -v "gdb") +gdb_bin=$(command -v "gdb-multiarch" || command -v "gdb") if test -e "$source_path/.git" then
As gdb will generally be talking to "foreign" guests lets use that if we can. Otherwise the chances of gdb barfing are considerably higher. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)